Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 851393002: add previously focused node to WebClient::focusedNodeChanged (Closed)

Created:
5 years, 11 months ago by Evan Stade
Modified:
5 years, 11 months ago
Reviewers:
dmazzoni, Mike West
CC:
blink-reviews, tyoshino+watch_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, Nate Chapin, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

add previously focused node to WebClient::focusedNodeChanged Chrome patch that will follow: https://codereview.chromium.org/812033016 BUG=433486 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188770

Patch Set 1 #

Patch Set 2 : dont break chrome #

Total comments: 6

Patch Set 3 : merge, review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -12 lines) Patch
M Source/core/dom/Document.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/EmptyClients.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Chrome.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Chrome.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/page/ChromeClient.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ChromeClientImpl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ChromeClientImpl.cpp View 1 2 1 chunk +6 lines, -4 lines 0 comments Download
M public/web/WebViewClient.h View 1 2 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
Evan Stade
5 years, 11 months ago (2015-01-17 00:34:14 UTC) #2
Mike West
LGTM, assuming you can get the bots happy. :) https://codereview.chromium.org/851393002/diff/20001/Source/web/ChromeClientImpl.cpp File Source/web/ChromeClientImpl.cpp (right): https://codereview.chromium.org/851393002/diff/20001/Source/web/ChromeClientImpl.cpp#newcode202 Source/web/ChromeClientImpl.cpp:202: ...
5 years, 11 months ago (2015-01-19 08:52:16 UTC) #3
dmazzoni
lgtm https://codereview.chromium.org/851393002/diff/20001/public/web/WebViewClient.h File public/web/WebViewClient.h (right): https://codereview.chromium.org/851393002/diff/20001/public/web/WebViewClient.h#newcode193 public/web/WebViewClient.h:193: virtual void focusedNodeChanged(const WebNode&, const WebNode&) { } ...
5 years, 11 months ago (2015-01-20 07:31:53 UTC) #5
Evan Stade
https://codereview.chromium.org/851393002/diff/20001/Source/web/ChromeClientImpl.cpp File Source/web/ChromeClientImpl.cpp (right): https://codereview.chromium.org/851393002/diff/20001/Source/web/ChromeClientImpl.cpp#newcode202 Source/web/ChromeClientImpl.cpp:202: // TODO(estade): remove. On 2015/01/19 08:52:16, Mike West wrote: ...
5 years, 11 months ago (2015-01-20 22:23:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/851393002/40001
5 years, 11 months ago (2015-01-20 22:24:31 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/96604)
5 years, 11 months ago (2015-01-21 01:16:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/851393002/40001
5 years, 11 months ago (2015-01-21 20:38:15 UTC) #12
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 21:32:43 UTC) #13
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188770

Powered by Google App Engine
This is Rietveld 408576698