Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 812033016: Add RenderFrameObserver::FocusedNodeChanged (Closed)

Created:
5 years, 11 months ago by Evan Stade
Modified:
5 years, 11 months ago
Reviewers:
dmazzoni, nasko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, browser-components-watch_chromium.org, nasko+codewatch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add RenderFrameObserver::FocusedNodeChanged make AutofillAgent use that instead of RenderViewObserver::FocusedNodeChanged. requires: https://codereview.chromium.org/851393002/ BUG=433486 Committed: https://crrev.com/31c54340954175d130706f0be45231f807d042e2 Cr-Commit-Position: refs/heads/master@{#312764}

Patch Set 1 #

Total comments: 4

Patch Set 2 : formatting #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : merge with step backwards #

Patch Set 6 : fix test #

Patch Set 7 : . #

Patch Set 8 : fix bad merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -31 lines) Patch
M components/autofill/content/renderer/autofill_agent.h View 1 2 3 4 5 6 7 2 chunks +1 line, -2 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 1 2 3 4 5 6 7 2 chunks +0 lines, -12 lines 0 comments Download
M content/public/renderer/render_frame_observer.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/public/test/render_view_test.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/accessibility/renderer_accessibility.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/accessibility/renderer_accessibility.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.h View 1 1 chunk +6 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 2 chunks +8 lines, -4 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 1 chunk +21 lines, -7 lines 0 comments Download

Messages

Total messages: 32 (13 generated)
Evan Stade
5 years, 11 months ago (2015-01-17 00:35:27 UTC) #2
nasko
Just one question, otherwise looks good. https://codereview.chromium.org/812033016/diff/1/content/renderer/render_frame_impl.cc File content/renderer/render_frame_impl.cc (right): https://codereview.chromium.org/812033016/diff/1/content/renderer/render_frame_impl.cc#newcode3744 content/renderer/render_frame_impl.cc:3744: FOR_EACH_OBSERVER(RenderFrameObserver, observers_, FocusedNodeChanged(node)); ...
5 years, 11 months ago (2015-01-20 05:09:51 UTC) #3
dmazzoni
lgtm lgtm for accessibility https://codereview.chromium.org/812033016/diff/1/content/renderer/render_frame_impl.cc File content/renderer/render_frame_impl.cc (right): https://codereview.chromium.org/812033016/diff/1/content/renderer/render_frame_impl.cc#newcode3744 content/renderer/render_frame_impl.cc:3744: FOR_EACH_OBSERVER(RenderFrameObserver, observers_, FocusedNodeChanged(node)); On 2015/01/20 ...
5 years, 11 months ago (2015-01-20 07:41:46 UTC) #4
Evan Stade
https://codereview.chromium.org/812033016/diff/1/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (right): https://codereview.chromium.org/812033016/diff/1/content/renderer/render_view_impl.cc#newcode1933 content/renderer/render_view_impl.cc:1933: if (!focusedNode.isNull()) { On 2015/01/20 05:09:51, nasko wrote: > ...
5 years, 11 months ago (2015-01-20 22:31:02 UTC) #5
nasko
LGTM
5 years, 11 months ago (2015-01-20 22:59:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/812033016/60001
5 years, 11 months ago (2015-01-22 00:49:52 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/47364) Try jobs failed on following ...
5 years, 11 months ago (2015-01-22 01:09:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/812033016/40002
5 years, 11 months ago (2015-01-22 03:45:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/812033016/90001
5 years, 11 months ago (2015-01-22 03:48:21 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/35099)
5 years, 11 months ago (2015-01-22 03:58:48 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/812033016/110001
5 years, 11 months ago (2015-01-22 16:57:22 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/17161)
5 years, 11 months ago (2015-01-22 18:06:14 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/812033016/130001
5 years, 11 months ago (2015-01-22 22:13:51 UTC) #22
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
5 years, 11 months ago (2015-01-23 00:25:55 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/812033016/130001
5 years, 11 months ago (2015-01-23 01:50:57 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/18782)
5 years, 11 months ago (2015-01-23 01:52:19 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/812033016/130001
5 years, 11 months ago (2015-01-23 02:18:13 UTC) #30
commit-bot: I haz the power
Committed patchset #8 (id:130001)
5 years, 11 months ago (2015-01-23 03:35:18 UTC) #31
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 03:36:25 UTC) #32
Message was sent while issue was closed. 
Patchset 8 (id:??) landed as
https://crrev.com/31c54340954175d130706f0be45231f807d042e2
Cr-Commit-Position: refs/heads/master@{#312764}

Powered by Google App Engine
This is Rietveld 408576698