testing/embedder_test.h - Issue 851283006: Fix build of pdfium_embeddertest under V8_USE_EXTERNAL_STARTUP_DATA.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: testing/embedder_test.h

Issue 851283006: Fix build of pdfium_embeddertest under V8_USE_EXTERNAL_STARTUP_DATA. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: One less ifdef Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: testing/embedder_test.h

diff --git a/testing/embedder_test.h b/testing/embedder_test.h

index 48ea415e19d550e35b7fbbdf332b2447f814cca4..ae8e7e6496d70a37be55d5f32baeb4e269d9b360 100644

--- a/testing/embedder_test.h

+++ b/testing/embedder_test.h

@@ -33,6 +33,8 @@ class EmbedderTest : public ::testing::Test {

virtual ~EmbedderTest() { }

+ static void SetExePath(const char* exe_path);

void SetUp() override;

void TearDown() override;

@@ -66,6 +68,8 @@ class EmbedderTest : public ::testing::Test {

virtual void UnloadPage(FPDF_PAGE page, FPDF_FORMHANDLE form);

private:

+ static const char* g_exe_path_;

Lei Zhang 2015/01/23 01:10:11 Just put this in embedder_test.cpp in an anonymous

FPDF_DOCUMENT document_;

FPDF_AVAIL avail_;

FX_DOWNLOADHINTS hints_;

« no previous file with comments | « pdfium.gyp ('k') | testing/embedder_test.cpp » ('j') | no next file with comments »