Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 851263002: [turbofan] Initial attempt to cleanup Node and related classes. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer
Modified:
5 years, 11 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Initial attempt to cleanup Node and related classes. - Make Node::Inputs and Node::Uses mostly STL compliant. - Get rid of some pre-C++11 crappiness. - Start moving unit tests from cctest to unittests. - TrimInputCount() now tries to reserve inputs slots for later appending. - Fix numerous style guide violations. TEST=cctest,unittests R=dcarney@chromium.org Committed: https://crrev.com/835cc463a8c8c50b812224c5f246164d30066da2 Cr-Commit-Position: refs/heads/master@{#26098}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+747 lines, -670 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M src/compiler/common-operator.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/common-operator.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/control-reducer.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M src/compiler/graph-reducer.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M src/compiler/graph-visualizer.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M src/compiler/instruction-selector.cc View 2 chunks +10 lines, -4 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/compiler/machine-operator-reducer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 5 chunks +9 lines, -8 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 5 chunks +10 lines, -9 lines 0 comments Download
M src/compiler/node.h View 14 chunks +174 lines, -340 lines 0 comments Download
M src/compiler/node.cc View 4 chunks +191 lines, -33 lines 0 comments Download
M src/compiler/node-properties.h View 1 chunk +3 lines, -1 line 0 comments Download
A src/compiler/node-properties.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M src/compiler/scheduler.cc View 6 chunks +14 lines, -16 lines 0 comments Download
M src/compiler/verifier.cc View 4 chunks +11 lines, -17 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 5 chunks +10 lines, -9 lines 0 comments Download
M test/cctest/compiler/test-control-reducer.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-node.cc View 7 chunks +14 lines, -194 lines 0 comments Download
M test/unittests/compiler/graph-unittest.cc View 1 chunk +20 lines, -0 lines 0 comments Download
A test/unittests/compiler/node-properties-unittest.cc View 1 chunk +32 lines, -0 lines 0 comments Download
A test/unittests/compiler/node-unittest.cc View 1 chunk +170 lines, -0 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 11 months ago (2015-01-16 10:12:05 UTC) #1
Benedikt Meurer
PTAL
5 years, 11 months ago (2015-01-16 10:12:14 UTC) #2
dcarney
lgtm
5 years, 11 months ago (2015-01-16 10:28:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/851263002/1
5 years, 11 months ago (2015-01-16 10:28:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-16 11:04:06 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 11:04:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/835cc463a8c8c50b812224c5f246164d30066da2
Cr-Commit-Position: refs/heads/master@{#26098}

Powered by Google App Engine
This is Rietveld 408576698