Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 851123003: Update {virtual,override,final} to follow C++11 style in chrome/browser/chromeos/settings. (Closed)

Created:
5 years, 11 months ago by dcheng
Modified:
5 years, 11 months ago
CC:
chromium-reviews, davemoore+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style in chrome/browser/chromeos/settings. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with a ChromeOS build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=mnissler@chromium.org Committed: https://crrev.com/0e941015b1284d3833cd03c6c37d0192e64efa28 Cr-Commit-Position: refs/heads/master@{#311868}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -113 lines) Patch
M chrome/browser/chromeos/settings/cros_settings_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/device_identity_provider.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/settings/device_oauth2_token_service.h View 2 chunks +15 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/settings/device_oauth2_token_service_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_provider.h View 1 chunk +9 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_service.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/device_settings_test_helper.h View 4 chunks +36 lines, -42 lines 0 comments Download
M chrome/browser/chromeos/settings/owner_flags_storage.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/settings/session_manager_operation.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/settings/shutdown_policy_handler_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/settings/stub_cros_settings_provider.h View 1 chunk +5 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/settings/stub_cros_settings_provider_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/settings/system_settings_provider.h View 1 chunk +6 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/settings/token_encryptor.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
dcheng
5 years, 11 months ago (2015-01-15 21:18:53 UTC) #1
Mattias Nissler (ping if slow)
LGTM
5 years, 11 months ago (2015-01-16 08:49:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/851123003/1
5 years, 11 months ago (2015-01-16 08:49:48 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-16 11:36:53 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 11:38:55 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e941015b1284d3833cd03c6c37d0192e64efa28
Cr-Commit-Position: refs/heads/master@{#311868}

Powered by Google App Engine
This is Rietveld 408576698