chrome/browser/chromeos/settings/device_settings_service.h - Issue 851123003: Update {virtual,override,final} to follow C++11 style in chrome/browser/chromeos/settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/settings/device_settings_service.h

Issue 851123003: Update {virtual,override,final} to follow C++11 style in chrome/browser/chromeos/settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/settings/device_settings_provider.h ('k') | chrome/browser/chromeos/settings/device_settings_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/settings/device_settings_service.h

diff --git a/chrome/browser/chromeos/settings/device_settings_service.h b/chrome/browser/chromeos/settings/device_settings_service.h

index dbf315b65e3dfc02f1c466afc44a0d3f1d765b2a..34c99b713a461fd20622cbfb66c19241eb1bb928 100644

--- a/chrome/browser/chromeos/settings/device_settings_service.h

+++ b/chrome/browser/chromeos/settings/device_settings_service.h

@@ -95,7 +95,7 @@ class DeviceSettingsService : public SessionManagerClient::Observer {

// Creates a device settings service instance. This is meant for unit tests,

// production code uses the singleton returned by Get() above.

DeviceSettingsService();

- virtual ~DeviceSettingsService();

+ ~DeviceSettingsService() override;

// To be called on startup once threads are initialized and DBus is ready.

void SetSessionManager(SessionManagerClient* session_manager_client,

@@ -174,8 +174,8 @@ class DeviceSettingsService : public SessionManagerClient::Observer {

void RemoveObserver(Observer* observer);

// SessionManagerClient::Observer:

- virtual void OwnerKeySet(bool success) override;

- virtual void PropertyChangeComplete(bool success) override;

+ void OwnerKeySet(bool success) override;

+ void PropertyChangeComplete(bool success) override;

private:

friend class OwnerSettingsServiceChromeOS;