Issue 851103004: Remove the 'author_counts_as_owner' option from CheckOwners().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 851103004: Remove the 'author_counts_as_owner' option from CheckOwners(). (Closed)

Created:
5 years, 11 months ago by Dirk Pranke

Modified:
5 years, 11 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, cmp-cc_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Target Ref:
refs/heads/master

Project:
tools

Visibility:
Public.

More Reviews

Description

Remove the 'author_counts_as_owner' option from CheckOwners(). Way back in r185294 I added the ability to request that, when checking owners, the patch author *should not* count (normally it does count). We did this in order to be able to mimic the review processes of WebKit in the Blink repo. However, we ended up never using this feature, so I'm finally getting around to deleting it. R=maruel@chromium.org BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293685

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -25 lines)			Patch
	M	presubmit_canned_checks.py	View		2 chunks	+2 lines, -3 lines	0 comments	Download
	M	tests/presubmit_unittest.py	View		4 chunks	+5 lines, -22 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/851103004/1

5 years, 11 months ago (2015-01-16 22:35:42 UTC) #4

commit-bot: I haz the power

5 years, 11 months ago (2015-01-16 22:38:39 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=293685

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages