presubmit_canned_checks.py - Issue 851103004: Remove the 'author_counts_as_owner' option from CheckOwners().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_canned_checks.py

Issue 851103004: Remove the 'author_counts_as_owner' option from CheckOwners(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: presubmit_canned_checks.py

diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py

index 34b7df4519625a8a2b7f19dc15cd9592a32009ff..bd628fb3665c4cc289f22c02c91a5510348eb1c0 100644

--- a/presubmit_canned_checks.py

+++ b/presubmit_canned_checks.py

@@ -847,8 +847,7 @@ def CheckBuildbotPendingBuilds(input_api, output_api, url, max_pendings,

return []

-def CheckOwners(input_api, output_api, source_file_filter=None,

- author_counts_as_owner=True):

+def CheckOwners(input_api, output_api, source_file_filter=None):

if input_api.is_committing:

if input_api.tbr:

return [output_api.PresubmitNotifyResult(

@@ -873,7 +872,7 @@ def CheckOwners(input_api, output_api, source_file_filter=None,

owner_email = owner_email or input_api.change.author_email

- if author_counts_as_owner and owner_email:

+ if owner_email:

reviewers_plus_owner = set([owner_email]).union(reviewers)

missing_files = owners_db.files_not_covered_by(affected_files,

reviewers_plus_owner)

« no previous file with comments | « no previous file | tests/presubmit_unittest.py » ('j') | no next file with comments »