Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 850953002: Remove the use of page id from NavController's GetVisibleEntry. (Closed)

Created:
5 years, 11 months ago by Avi (use Gerrit)
Modified:
5 years, 11 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the use of page id from NavController's GetVisibleEntry. BUG=369661 TEST=tests stay green Committed: https://crrev.com/6b988de501639cc9a8f9d40aa25fc44b431de71d Reverted: https://crrev.com/67d33496116a22ce2244977569314d818525da04 Committed: https://crrev.com/0dca04d9ff641aaba46bfb3281f3ad21e76e0c0b Cr-Commit-Position: refs/heads/master@{#313115}

Patch Set 1 #

Patch Set 2 : fix, rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/frame_host/navigation_controller_impl.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Charlie Reis
lgtm
5 years, 11 months ago (2015-01-23 07:24:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/850953002/20001
5 years, 11 months ago (2015-01-23 07:24:53 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-23 07:41:47 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/6b988de501639cc9a8f9d40aa25fc44b431de71d Cr-Commit-Position: refs/heads/master@{#312792}
5 years, 11 months ago (2015-01-23 07:43:22 UTC) #6
kochi
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/873583004/ by kochi@chromium.org. ...
5 years, 11 months ago (2015-01-23 09:28:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/850953002/40001
5 years, 11 months ago (2015-01-26 20:10:23 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-26 20:21:38 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 20:23:32 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0dca04d9ff641aaba46bfb3281f3ad21e76e0c0b
Cr-Commit-Position: refs/heads/master@{#313115}

Powered by Google App Engine
This is Rietveld 408576698