Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1167)

Unified Diff: content/browser/frame_host/navigation_controller_impl.cc

Issue 850953002: Remove the use of page id from NavController's GetVisibleEntry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigation_controller_impl.cc
diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc
index e5014071e573f18197629dc3ea6a7d37b48ae787..3168892556ced7a8aafd4ce2a9dbf3f82608ea5e 100644
--- a/content/browser/frame_host/navigation_controller_impl.cc
+++ b/content/browser/frame_host/navigation_controller_impl.cc
@@ -448,7 +448,7 @@ NavigationEntry* NavigationControllerImpl::GetVisibleEntry() const {
bool safe_to_show_pending =
pending_entry_ &&
// Require a new navigation.
- pending_entry_->GetPageID() == -1 &&
+ pending_entry_index_ == -1 &&
// Require either browser-initiated or an unmodified new tab.
(!pending_entry_->is_renderer_initiated() || IsUnmodifiedBlankTab());
@@ -457,7 +457,7 @@ NavigationEntry* NavigationControllerImpl::GetVisibleEntry() const {
// can script the new tab before it commits.
if (!safe_to_show_pending &&
pending_entry_ &&
- pending_entry_->GetPageID() != -1 &&
+ pending_entry_index_ != -1 &&
IsInitialNavigation() &&
!pending_entry_->is_renderer_initiated())
safe_to_show_pending = true;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698