Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 850853002: Extensions: Consolidate extension id hashing / searching. (Closed)

Created:
5 years, 11 months ago by Lei Zhang
Modified:
5 years, 10 months ago
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, zea+watch_chromium.org, tfarina, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, noyau+watch_chromium.org, chromium-apps-reviews_chromium.org, markusheintz_, maniscalco+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extensions: Consolidate extension id hashing / searching. Committed: https://crrev.com/83cbcc4f27ee5c07f74dc2a3bab9b18213c28d25 Cr-Commit-Position: refs/heads/master@{#313747}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 1

Patch Set 5 : crx_file #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -56 lines) Patch
M chrome/browser/background/background_application_list_model.cc View 1 2 3 4 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/content_settings/content_settings_internal_extension_provider.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_api.cc View 4 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/extensions/external_component_loader.cc View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/sync/glue/extension_backed_data_type_controller.cc View 1 2 3 4 3 chunks +2 lines, -13 lines 0 comments Download
M chrome/browser/ui/bookmarks/enhanced_bookmark_key_service.cc View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
M components/crx_file/id_util.h View 1 2 3 4 1 chunk +5 lines, -2 lines 0 comments Download
M components/crx_file/id_util.cc View 1 2 3 4 2 chunks +7 lines, -0 lines 0 comments Download
M extensions/browser/api/app_window/app_window_api.cc View 7 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Lei Zhang
5 years, 11 months ago (2015-01-15 21:37:13 UTC) #2
Yoyo Zhou
https://codereview.chromium.org/850853002/diff/60001/extensions/common/extension.cc File extensions/common/extension.cc (right): https://codereview.chromium.org/850853002/diff/60001/extensions/common/extension.cc#newcode394 extensions/common/extension.cc:394: std::string Extension::HashedIdInHex() const { Can this go in id_util.h ...
5 years, 11 months ago (2015-01-22 00:59:13 UTC) #3
Lei Zhang
On 2015/01/22 00:59:13, Yoyo Zhou wrote: > https://codereview.chromium.org/850853002/diff/60001/extensions/common/extension.cc > File extensions/common/extension.cc (right): > > https://codereview.chromium.org/850853002/diff/60001/extensions/common/extension.cc#newcode394 ...
5 years, 11 months ago (2015-01-24 01:25:22 UTC) #4
Yoyo Zhou
LGTM
5 years, 10 months ago (2015-01-28 23:44:53 UTC) #5
Lei Zhang
The crx_file component has no owners, so +erikwright
5 years, 10 months ago (2015-01-29 04:16:22 UTC) #7
erikwright (departed)
It looks like yoz@ would be an appropriate OWNER for this directory. yoz: Please submit ...
5 years, 10 months ago (2015-01-29 15:17:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/850853002/100001
5 years, 10 months ago (2015-01-29 17:59:17 UTC) #10
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 10 months ago (2015-01-29 18:51:05 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 18:52:02 UTC) #12
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/83cbcc4f27ee5c07f74dc2a3bab9b18213c28d25
Cr-Commit-Position: refs/heads/master@{#313747}

Powered by Google App Engine
This is Rietveld 408576698