Extensions: Consolidate extension id hashing / searching.

extensions/common/extension.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/extension.h"
 
 #include "base/base64.h"
 #include "base/basictypes.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/i18n/rtl.h"
 #include "base/logging.h"
 #include "base/memory/singleton.h"
+#include "base/sha1.h"
 #include "base/stl_util.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_piece.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "base/version.h"
 #include "components/crx_file/id_util.h"
@@ skipping 359 matching lines @@
 const std::string Extension::VersionString() const {
   return version()->GetString();
 }
 
 const std::string Extension::GetVersionForDisplay() const {
   if (version_name_.size() > 0)
     return version_name_;
   return VersionString();
 }
 
+std::string Extension::HashedIdInHex() const {

[Yoyo Zhou, 2015/01/22 00:59:13]

Can this go in id_util.h instead of extension.h?

crx_file::id_util::HashedIdInHex(string id)

+  const std::string id_hash = base::SHA1HashString(id());
+  DCHECK_EQ(base::kSHA1Length, id_hash.length());
+  return base::HexEncode(id_hash.c_str(), id_hash.length());
+}
+
 void Extension::AddInstallWarning(const InstallWarning& new_warning) {
   install_warnings_.push_back(new_warning);
 }
 
 void Extension::AddInstallWarnings(
     const std::vector<InstallWarning>& new_warnings) {
   install_warnings_.insert(install_warnings_.end(),
                            new_warnings.begin(), new_warnings.end());
 }
 
@@ skipping 372 matching lines @@
 
 UpdatedExtensionPermissionsInfo::UpdatedExtensionPermissionsInfo(
     const Extension* extension,
     const PermissionSet* permissions,
     Reason reason)
     : reason(reason),
       extension(extension),
       permissions(permissions) {}
 
 }   // namespace extensions