Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 850833004: Fix shelf dimming on secondary display (Closed)

Created:
5 years, 11 months ago by pkotwicz
Modified:
5 years, 11 months ago
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix shelf dimming on secondary display BUG=449863 TEST=ShelfLayoutManagerTest.DimmingBehaviorDualDisplay Committed: https://crrev.com/665d66d93fe22a50ba3623397b596a394098faef Cr-Commit-Position: refs/heads/master@{#312244}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -5 lines) Patch
M ash/shelf/shelf_layout_manager_unittest.cc View 2 chunks +57 lines, -2 lines 0 comments Download
M ash/shelf/shelf_widget.cc View 3 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
pkotwicz
skuhne@ PTAL
5 years, 11 months ago (2015-01-18 23:40:57 UTC) #2
pkotwicz
skuhne@ PTAL
5 years, 11 months ago (2015-01-18 23:40:58 UTC) #4
Mr4D (OOO till 08-26)
lgtm
5 years, 11 months ago (2015-01-20 16:14:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/850833004/40001
5 years, 11 months ago (2015-01-20 18:37:55 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 11 months ago (2015-01-20 19:26:53 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/665d66d93fe22a50ba3623397b596a394098faef Cr-Commit-Position: refs/heads/master@{#312244}
5 years, 11 months ago (2015-01-20 19:28:53 UTC) #11
achaulk
5 years, 10 months ago (2015-01-29 17:27:41 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:40001) has been created in
https://codereview.chromium.org/883063003/ by achaulk@chromium.org.

The reason for reverting is: Causing crbug.com/451804 - probably using an
invalid window.

Powered by Google App Engine
This is Rietveld 408576698