Fix shelf dimming on secondary display

ash/shelf/shelf_layout_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/shelf/shelf_layout_manager.h"
 
 #include "ash/accelerators/accelerator_controller.h"
 #include "ash/accelerators/accelerator_table.h"
 #include "ash/ash_switches.h"
 #include "ash/display/display_controller.h"
@@ skipping 1100 matching lines @@
   EXPECT_TRUE(shelf_widget->status_area_widget()->IsVisible());
   StepWidgetLayerAnimatorToEnd(shelf_widget);
   StepWidgetLayerAnimatorToEnd(shelf_widget->status_area_widget());
   EXPECT_EQ(SHELF_VISIBLE, shelf->visibility_state());
   EXPECT_EQ(Shell::GetScreen()->GetDisplayNearestWindow(
                 window).work_area().bottom(),
             widget->GetWorkAreaBoundsInScreen().bottom());
 }
 
 // Basic assertions around the dimming of the shelf.
-TEST_F(ShelfLayoutManagerTest, TestDimmingBehavior) {
+TEST_F(ShelfLayoutManagerTest, DimmingBehavior) {
   // Since ShelfLayoutManager queries for mouse location, move the mouse so
   // it isn't over the shelf.
   ui::test::EventGenerator generator(Shell::GetPrimaryRootWindow(),
                                      gfx::Point());
   generator.MoveMouseTo(0, 0);
 
   ShelfLayoutManager* shelf = GetShelfLayoutManager();
   shelf->shelf_widget()->DisableDimmingAnimationsForTest();
 
   views::Widget* widget = new views::Widget;
@@ skipping 52 matching lines @@
   generator.MoveTouch(off_shelf);
   EXPECT_EQ(0, shelf->shelf_widget()->GetDimmingAlphaForTest());
   generator.MoveTouch(on_shelf);
   generator.ReleaseTouch();
 
   // After restore, the dimming object should be deleted again.
   widget->Restore();
   EXPECT_EQ(-1, shelf->shelf_widget()->GetDimmingAlphaForTest());
 }
 
+// Test that dimming works correctly with multiple displays.
+TEST_F(ShelfLayoutManagerTest, DimmingBehaviorDualDisplay) {
+  if (!SupportsMultipleDisplays())
+    return;
+
+  // Create two displays.
+  Shell* shell = Shell::GetInstance();
+  UpdateDisplay("0+0-200x200,+200+0-100x100");
+  EXPECT_EQ(2U, shell->display_manager()->GetNumDisplays());
+
+  DisplayController* display_controller = shell->display_controller();
+  aura::Window::Windows root_windows = display_controller->GetAllRootWindows();
+  EXPECT_EQ(root_windows.size(), 2U);
+
+  std::vector<ShelfWidget*> shelf_widgets;
+  for (auto& root_window : root_windows) {
+    ShelfLayoutManager* shelf =
+        GetRootWindowController(root_window)->GetShelfLayoutManager();
+    shelf_widgets.push_back(shelf->shelf_widget());
+
+    // For disabling the dimming animation to work, the animation must be
+    // disabled prior to creating the dimmer.
+    shelf_widgets.back()->DisableDimmingAnimationsForTest();
+
+    // Create a maximized window to create the dimmer.
+    views::Widget* widget = new views::Widget;
+    views::Widget::InitParams params(views::Widget::InitParams::TYPE_WINDOW);
+    params.context = root_window;
+    params.bounds = root_window->GetBoundsInScreen();
+    params.show_state = ui::SHOW_STATE_MAXIMIZED;
+    widget->Init(params);
+    widget->Show();
+  }
+
+  ui::test::EventGenerator& generator(GetEventGenerator());
+
+  generator.MoveMouseTo(root_windows[0]->GetBoundsInScreen().CenterPoint());
+  EXPECT_LT(0, shelf_widgets[0]->GetDimmingAlphaForTest());
+  EXPECT_LT(0, shelf_widgets[1]->GetDimmingAlphaForTest());
+
+  generator.MoveMouseTo(
+      shelf_widgets[0]->GetWindowBoundsInScreen().CenterPoint());
+  EXPECT_EQ(0, shelf_widgets[0]->GetDimmingAlphaForTest());
+  EXPECT_LT(0, shelf_widgets[1]->GetDimmingAlphaForTest());
+
+  generator.MoveMouseTo(
+      shelf_widgets[1]->GetWindowBoundsInScreen().CenterPoint());
+  EXPECT_LT(0, shelf_widgets[0]->GetDimmingAlphaForTest());
+  EXPECT_EQ(0, shelf_widgets[1]->GetDimmingAlphaForTest());
+
+  generator.MoveMouseTo(root_windows[1]->GetBoundsInScreen().CenterPoint());
+  EXPECT_LT(0, shelf_widgets[0]->GetDimmingAlphaForTest());
+  EXPECT_LT(0, shelf_widgets[1]->GetDimmingAlphaForTest());
+}
+
 // Assertions around the dimming of the shelf in conjunction with menus.
-TEST_F(ShelfLayoutManagerTest, TestDimmingBehaviorWithMenus) {
+TEST_F(ShelfLayoutManagerTest, DimmingBehaviorWithMenus) {
   // Since ShelfLayoutManager queries for mouse location, move the mouse so
   // it isn't over the shelf.
   ui::test::EventGenerator generator(Shell::GetPrimaryRootWindow(),
                                      gfx::Point());
   generator.MoveMouseTo(0, 0);
 
   ShelfLayoutManager* shelf = GetShelfLayoutManager();
   shelf->shelf_widget()->DisableDimmingAnimationsForTest();
 
   views::Widget* widget = new views::Widget;
@@ skipping 1009 matching lines @@
   shelf_manager->SetAutoHideBehavior(SHELF_AUTO_HIDE_ALWAYS_HIDDEN);
   gfx::Rect hide_target_bounds =  status_window->GetTargetBounds();
   EXPECT_GT(hide_target_bounds.y(), initial_bounds.y());
 
   shelf_manager->SetAutoHideBehavior(SHELF_AUTO_HIDE_BEHAVIOR_NEVER);
   gfx::Rect reshow_target_bounds = status_window->GetTargetBounds();
   EXPECT_EQ(initial_bounds, reshow_target_bounds);
 }
 
 }  // namespace ash