Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 850783002: Disable two PagedArrayTests that fail under AddressSanitizer on Windows (Closed)

Created:
5 years, 11 months ago by Timur Iskhodzhanov
Modified:
5 years, 11 months ago
Reviewers:
dgarrett, Will Harris
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable two PagedArrayTests that fail under AddressSanitizer on Windows This should make courgette_unittests green in this configuration. BUG=345874 TBR=dgarrett@chromium.org Committed: https://crrev.com/949c22c964e43aa078bd72a01732943379052ca4 Cr-Commit-Position: refs/heads/master@{#311453}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Reword the comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M courgette/third_party/paged_array_unittest.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Timur Iskhodzhanov
Don, Will, Can either of you please review this tiny change? Thanks, Tim
5 years, 11 months ago (2015-01-13 17:47:46 UTC) #2
dgarrett
https://codereview.chromium.org/850783002/diff/1/courgette/third_party/paged_array_unittest.cc File courgette/third_party/paged_array_unittest.cc (right): https://codereview.chromium.org/850783002/diff/1/courgette/third_party/paged_array_unittest.cc#newcode17 courgette/third_party/paged_array_unittest.cc:17: // Disable these tests under AddressSanitizer on Windows as ...
5 years, 11 months ago (2015-01-13 22:16:11 UTC) #3
dgarrett
Otherwise, looks good.
5 years, 11 months ago (2015-01-13 22:16:26 UTC) #4
Timur Iskhodzhanov
Done. Looks like I was trying to explain more things than necessary in the comment ...
5 years, 11 months ago (2015-01-14 10:26:14 UTC) #5
Timur Iskhodzhanov
Thanks for the quick review!
5 years, 11 months ago (2015-01-14 10:26:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/850783002/20001
5 years, 11 months ago (2015-01-14 10:27:20 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-14 11:22:05 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 11:23:34 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/949c22c964e43aa078bd72a01732943379052ca4
Cr-Commit-Position: refs/heads/master@{#311453}

Powered by Google App Engine
This is Rietveld 408576698