Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1245)

Unified Diff: courgette/third_party/paged_array_unittest.cc

Issue 850783002: Disable two PagedArrayTests that fail under AddressSanitizer on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reword the comment Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: courgette/third_party/paged_array_unittest.cc
diff --git a/courgette/third_party/paged_array_unittest.cc b/courgette/third_party/paged_array_unittest.cc
index f65d68683bca0a69f2d50392faa66c108d643281..faa5548fb8f13d870b7ce8666a57b6a0e6817477 100644
--- a/courgette/third_party/paged_array_unittest.cc
+++ b/courgette/third_party/paged_array_unittest.cc
@@ -14,6 +14,9 @@ class PagedArrayTest : public testing::Test {
static const int kSize = 200 * 1024 * 1024 / sizeof(int); // 200MB
};
+// AddressSanitizer on Windows adds additional memory overhead, which
+// causes these tests to go OOM and fail.
+#if !defined(ADDRESS_SANITIZER) || !defined(OS_WIN)
TEST_F(PagedArrayTest, TestManyAllocationsDestructorFree) {
for (int i = 0; i < kIterations; ++i) {
courgette::PagedArray<int> a;
@@ -28,6 +31,7 @@ TEST_F(PagedArrayTest, TestManyAllocationsManualFree) {
a.clear();
}
}
+#endif
TEST_F(PagedArrayTest, TestAccess) {
const int kAccessSize = 3 * 1024 * 1024;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698