Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 8506017: Fix IdleNotification to correctly free objects.

Created:
9 years, 1 month ago by Peter Varga
Modified:
9 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

Fix IdleNotification to correctly free objects. Heap::IdleNotification doesn't free all objects in special cases since incremental marking is enabled. Use the slower precise sweeper in the last phase of Heap::IdleNotification. Patch by Peter Varga BUG=none TEST=cctest/test-api/IdleNotificationForceGC

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -1 line) Patch
M src/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Peter Varga
9 years, 1 month ago (2011-11-09 16:08:49 UTC) #1
Vyacheslav Egorov (Chromium)
I am not sure we want IdleNotification to force V8 abandon incremental marking and do ...
9 years, 1 month ago (2011-11-09 16:11:32 UTC) #2
Peter Varga
9 years, 1 month ago (2011-11-09 16:25:47 UTC) #3
Thank you for the quick answer.
The LowMemoryNotification is exactly what I need.

Powered by Google App Engine
This is Rietveld 408576698