Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: public/web/WebServiceWorkerContextClient.h

Issue 850413002: [ServiceWorker] Implement ServiceWorkerClients.openWindow(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@sw_client_info_cb
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/web/WebServiceWorkerContextClient.h
diff --git a/public/web/WebServiceWorkerContextClient.h b/public/web/WebServiceWorkerContextClient.h
index 4d63b8389a3e08ce6126c4a024de8e134b12f7db..14eb7b3cf8e40232c114ab0ba9e6d8c54d16cd3b 100644
--- a/public/web/WebServiceWorkerContextClient.h
+++ b/public/web/WebServiceWorkerContextClient.h
@@ -153,6 +153,12 @@ public:
// passed to the WebServiceWorkerClientsCallbacks implementation.
virtual void getClients(WebServiceWorkerClientsCallbacks*) { BLINK_ASSERT_NOT_REACHED(); }
+ // Ownership of the passed callbacks is transferred to the callee, callee
+ // should delete the callbacks after calling either onSuccess or onError.
+ // WebServiceWorkerClientInfo and WebServiceWorkerError ownerships are
+ // passed to the WebServiceWorkerClientsCallbacks implementation.
Michael van Ouwerkerk 2015/01/30 14:56:28 WebServiceWorkerClientCallbacks
+ virtual void openWindow(const WebURL& url, WebServiceWorkerClientCallbacks*) { BLINK_ASSERT_NOT_REACHED(); }
+
// Callee receives ownership of the passed vector.
// FIXME: Blob refs should be passed to maintain ref counts. crbug.com/351753
virtual void postMessageToClient(int clientID, const WebString&, WebMessagePortChannelArray*) { BLINK_ASSERT_NOT_REACHED(); }

Powered by Google App Engine
This is Rietveld 408576698