Source/modules/serviceworkers/ServiceWorkerWindowClient.h - Issue 850413002: [ServiceWorker] Implement ServiceWorkerClients.openWindow().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerWindowClient.h

Issue 850413002: [ServiceWorker] Implement ServiceWorkerClients.openWindow(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@sw_client_info_cb

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/serviceworkers/ServiceWorkerClients.cpp ('K') | « Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h ('k') | Source/modules/serviceworkers/ServiceWorkerWindowClient.cpp » ('j') | public/web/WebServiceWorkerContextClient.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/ServiceWorkerWindowClient.h

diff --git a/Source/modules/serviceworkers/ServiceWorkerWindowClient.h b/Source/modules/serviceworkers/ServiceWorkerWindowClient.h

index 57feb92377f080227c562287cef10d3b97c73085..11792efd055c52757ebab7bd1fb1bc798cb90587 100644

--- a/Source/modules/serviceworkers/ServiceWorkerWindowClient.h

+++ b/Source/modules/serviceworkers/ServiceWorkerWindowClient.h

@@ -12,11 +12,18 @@

namespace blink {

+class ScriptPromiseResolver;

class ScriptState;

class ServiceWorkerWindowClient final : public ServiceWorkerClient {

DEFINE_WRAPPERTYPEINFO();

public:

+ // To be used by CallbackPromiseAdapter.

+ typedef blink::WebServiceWorkerClientInfo WebType;

Michael van Ouwerkerk 2015/01/30 14:56:28 nit: omit namespace

mlamouri (slow - plz ping) 2015/02/02 16:09:26 Done.

+ static ServiceWorkerWindowClient* take(ScriptPromiseResolver*, WebType*);

+ static void dispose(WebType*);

static ServiceWorkerWindowClient* create(const WebServiceWorkerClientInfo&);

~ServiceWorkerWindowClient() override;