Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h - Issue 850413002: [ServiceWorker] Implement ServiceWorkerClients.openWindow().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

Issue 850413002: [ServiceWorker] Implement ServiceWorkerClients.openWindow(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@sw_client_info_cb

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/serviceworkers/ServiceWorkerClients.cpp ('K') | « Source/modules/serviceworkers/ServiceWorkerClients.cpp ('k') | Source/modules/serviceworkers/ServiceWorkerWindowClient.h » ('j') | Source/modules/serviceworkers/ServiceWorkerWindowClient.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

diff --git a/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h b/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

index 1ee2e29a07f61fad98f99e85fc1db0e4f48a1e9d..0c0a4a74629a8b5e0fba9fd10019f7c717162827 100644

--- a/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

+++ b/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

@@ -56,7 +56,10 @@ class ServiceWorkerGlobalScopeClient : public WillBeHeapSupplement<WorkerClients

public:

virtual ~ServiceWorkerGlobalScopeClient() { }

+ // Called from ServiceWorkerClients.

virtual void getClients(WebServiceWorkerClientsCallbacks*) = 0;

+ virtual void openWindow(const WebURL&, WebServiceWorkerClientCallbacks*) = 0;

virtual WebURL scope() const = 0;

virtual WebServiceWorkerCacheStorage* cacheStorage() const = 0;