Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Unified Diff: scripts/slave/recipe_modules/skia/api.py

Issue 850403002: Blacklist the new DM features of drawing SKPs and images into GPU canvases on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/skia/skia.expected/Test-Android-GalaxyS4-SGX544-Arm7-Debug.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/skia/api.py
diff --git a/scripts/slave/recipe_modules/skia/api.py b/scripts/slave/recipe_modules/skia/api.py
index 357d1bc79012833326c95737d471265713691a86..6af790189d7cc3cbd0f54d65cc9e9b2d7e1b8fae 100644
--- a/scripts/slave/recipe_modules/skia/api.py
+++ b/scripts/slave/recipe_modules/skia/api.py
@@ -408,6 +408,12 @@ class SkiaApi(recipe_api.RecipeApi):
args.append('--key')
args.extend(self._KeyParams())
+ # Drawing SKPs, images, or image subsets into GPU canvases is a New Thing.
+ # It seems like we're running out of RAM on some Android bots, so start off
+ # with a very wide blacklist disabling all these tests on all Android bots.
+ if 'Android' in self.c.BUILDER_NAME: # skia:3255
+ args.append('--blacklist gpu skp _ gpu image _ gpu subset _')
+
match = []
if 'Alex' in self.c.BUILDER_NAME: # skia:2793
# This machine looks to be running out of heap.
« no previous file with comments | « no previous file | scripts/slave/recipes/skia/skia.expected/Test-Android-GalaxyS4-SGX544-Arm7-Debug.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698