Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: scripts/slave/recipe_modules/skia/api.py

Issue 850403002: Blacklist the new DM features of drawing SKPs and images into GPU canvases on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/skia/skia.expected/Test-Android-GalaxyS4-SGX544-Arm7-Debug.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 5
6 from slave import recipe_api 6 from slave import recipe_api
7 from slave import recipe_config_types 7 from slave import recipe_config_types
8 from common.skia import builder_name_schema 8 from common.skia import builder_name_schema
9 from common.skia import global_constants 9 from common.skia import global_constants
10 from . import android_flavor 10 from . import android_flavor
(...skipping 390 matching lines...) Expand 10 before | Expand all | Expand 10 after
401 '--skps', self.device_dirs.skp_dir, 401 '--skps', self.device_dirs.skp_dir,
402 '--images', self.device_dirs.images_dir, 402 '--images', self.device_dirs.images_dir,
403 '--writePath', self.device_dirs.dm_dir, 403 '--writePath', self.device_dirs.dm_dir,
404 '--nameByHash', 404 '--nameByHash',
405 '--properties', 'gitHash', self.got_revision, 405 '--properties', 'gitHash', self.got_revision,
406 'build_number', self.m.properties['buildnumber'], 406 'build_number', self.m.properties['buildnumber'],
407 ] 407 ]
408 args.append('--key') 408 args.append('--key')
409 args.extend(self._KeyParams()) 409 args.extend(self._KeyParams())
410 410
411 # Drawing SKPs, images, or image subsets into GPU canvases is a New Thing.
412 # It seems like we're running out of RAM on some Android bots, so start off
413 # with a very wide blacklist disabling all these tests on all Android bots.
414 if 'Android' in self.c.BUILDER_NAME: # skia:3255
415 args.append('--blacklist gpu skp _ gpu image _ gpu subset _')
416
411 match = [] 417 match = []
412 if 'Alex' in self.c.BUILDER_NAME: # skia:2793 418 if 'Alex' in self.c.BUILDER_NAME: # skia:2793
413 # This machine looks to be running out of heap. 419 # This machine looks to be running out of heap.
414 # Running with fewer threads may help. 420 # Running with fewer threads may help.
415 args.extend(['--threads', '1']) 421 args.extend(['--threads', '1'])
416 if 'Valgrind' in self.c.BUILDER_NAME: # skia:3021 422 if 'Valgrind' in self.c.BUILDER_NAME: # skia:3021
417 match.append('~Threaded') 423 match.append('~Threaded')
418 if 'Xoom' in self.c.BUILDER_NAME: # skia:1699 424 if 'Xoom' in self.c.BUILDER_NAME: # skia:1699
419 match.append('~WritePixels') 425 match.append('~WritePixels')
420 426
(...skipping 157 matching lines...) Expand 10 before | Expand all | Expand 10 after
578 # TryBots are uploaded elsewhere so they can use the same key. 584 # TryBots are uploaded elsewhere so they can use the same key.
579 blacklist = ['role', 'is_trybot'] 585 blacklist = ['role', 'is_trybot']
580 586
581 params = builder_name_schema.DictForBuilderName(self.c.BUILDER_NAME) 587 params = builder_name_schema.DictForBuilderName(self.c.BUILDER_NAME)
582 flat = [] 588 flat = []
583 for k in sorted(params.keys()): 589 for k in sorted(params.keys()):
584 if k not in blacklist: 590 if k not in blacklist:
585 flat.append(k) 591 flat.append(k)
586 flat.append(params[k]) 592 flat.append(params[k])
587 return flat 593 return flat
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipes/skia/skia.expected/Test-Android-GalaxyS4-SGX544-Arm7-Debug.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698