Use std::vector<char> rather than std::string to represent a base::BinaryValue

Use std::vector<char> rather than std::string to represent a base::BinaryValue
in the JSON Schema Compiler.

BUG=...

[pneubeck (no reviews), 2015-01-15 11:11:39]

pneubeck@chromium.org changed reviewers:
+ pneubeck@chromium.org

[pneubeck (no reviews), 2015-01-15 11:11:40]

Tried going this route.
This will at least need this change to the compiler as well:

diff --git a/tools/json_schema_compiler/util.cc
b/tools/json_schema_compiler/util.cc
index 2806cfc..17cfa43 100644
--- a/tools/json_schema_compiler/util.cc
+++ b/tools/json_schema_compiler/util.cc
@@ -27,6 +27,16 @@ bool GetItemFromList(const base::ListValue& from, int index,
std::string* out) {
 
 bool GetItemFromList(const base::ListValue& from,
                      int index,
+                     std::vector<char>* out) {
+  const base::BinaryValue* binary = NULL;
+  if (!from.GetBinary(index, &binary))
+    return false;
+  out->assign(binary->GetBuffer(), binary->GetBuffer() + binary->GetSize());
+  return true;
+}
+
+bool GetItemFromList(const base::ListValue& from,
+                     int index,
                      linked_ptr<base::Value>* out) {
   const base::Value* value = NULL;
   if (!from.Get(index, &value))
@@ -60,6 +70,11 @@ void AddItemToList(const std::string& from, base::ListValue*
out) {
   out->Append(new base::StringValue(from));
 }
 
+void AddItemToList(const std::vector<char>& from, base::ListValue* out) {
+  out->Append(
+      base::BinaryValue::CreateWithCopiedBuffer(&from[0], from.size()));
+}
+
 void AddItemToList(const linked_ptr<base::Value>& from,
                    base::ListValue* out) {
   out->Append(from->DeepCopy());
diff --git a/tools/json_schema_compiler/util.h
b/tools/json_schema_compiler/util.h
index 228eced..29cd470 100644
--- a/tools/json_schema_compiler/util.h
+++ b/tools/json_schema_compiler/util.h
@@ -24,6 +24,9 @@ bool GetItemFromList(const base::ListValue& from, int index,
double* out);
 bool GetItemFromList(const base::ListValue& from, int index, std::string* out);
 bool GetItemFromList(const base::ListValue& from,
                      int index,
+                     std::vector<char>* out);
+bool GetItemFromList(const base::ListValue& from,
+                     int index,
                      linked_ptr<base::Value>* out);
 bool GetItemFromList(const base::ListValue& from,
                      int index,
@@ -123,6 +126,7 @@ void AddItemToList(const int from, base::ListValue* out);
 void AddItemToList(const bool from, base::ListValue* out);
 void AddItemToList(const double from, base::ListValue* out);
 void AddItemToList(const std::string& from, base::ListValue* out);
+void AddItemToList(const std::vector<char>& from, base::ListValue* out);
 void AddItemToList(const linked_ptr<base::Value>& from,
                    base::ListValue* out);
 void AddItemToList(const linked_ptr<base::DictionaryValue>& from,


Compiling leads to several errors. A search for uses of ArrayBuffer in IDLs (no
idea about .jsons) reveals 24 files with several matches:
 
https://code.google.com/p/chromium/codesearch#search/&q=file:extension.*idl$%...

Not that small a refactoring.

[not at google - send to devlin, 2015-01-15 20:50:07]

On 2015/01/15 11:11:40, pneubeck wrote:
> Tried going this route.
> This will at least need this change to the compiler as well:
> 
> diff --git a/tools/json_schema_compiler/util.cc
> b/tools/json_schema_compiler/util.cc
> index 2806cfc..17cfa43 100644
> --- a/tools/json_schema_compiler/util.cc
> +++ b/tools/json_schema_compiler/util.cc
> @@ -27,6 +27,16 @@ bool GetItemFromList(const base::ListValue& from, int
index,
> std::string* out) {
>  
>  bool GetItemFromList(const base::ListValue& from,
>                       int index,
> +                     std::vector<char>* out) {
> +  const base::BinaryValue* binary = NULL;
> +  if (!from.GetBinary(index, &binary))
> +    return false;
> +  out->assign(binary->GetBuffer(), binary->GetBuffer() + binary->GetSize());
> +  return true;
> +}
> +
> +bool GetItemFromList(const base::ListValue& from,
> +                     int index,
>                       linked_ptr<base::Value>* out) {
>    const base::Value* value = NULL;
>    if (!from.Get(index, &value))
> @@ -60,6 +70,11 @@ void AddItemToList(const std::string& from,
base::ListValue*
> out) {
>    out->Append(new base::StringValue(from));
>  }
>  
> +void AddItemToList(const std::vector<char>& from, base::ListValue* out) {
> +  out->Append(
> +      base::BinaryValue::CreateWithCopiedBuffer(&from[0], from.size()));
> +}
> +
>  void AddItemToList(const linked_ptr<base::Value>& from,
>                     base::ListValue* out) {
>    out->Append(from->DeepCopy());
> diff --git a/tools/json_schema_compiler/util.h
> b/tools/json_schema_compiler/util.h
> index 228eced..29cd470 100644
> --- a/tools/json_schema_compiler/util.h
> +++ b/tools/json_schema_compiler/util.h
> @@ -24,6 +24,9 @@ bool GetItemFromList(const base::ListValue& from, int index,
> double* out);
>  bool GetItemFromList(const base::ListValue& from, int index, std::string*
out);
>  bool GetItemFromList(const base::ListValue& from,
>                       int index,
> +                     std::vector<char>* out);
> +bool GetItemFromList(const base::ListValue& from,
> +                     int index,
>                       linked_ptr<base::Value>* out);
>  bool GetItemFromList(const base::ListValue& from,
>                       int index,
> @@ -123,6 +126,7 @@ void AddItemToList(const int from, base::ListValue* out);
>  void AddItemToList(const bool from, base::ListValue* out);
>  void AddItemToList(const double from, base::ListValue* out);
>  void AddItemToList(const std::string& from, base::ListValue* out);
> +void AddItemToList(const std::vector<char>& from, base::ListValue* out);
>  void AddItemToList(const linked_ptr<base::Value>& from,
>                     base::ListValue* out);
>  void AddItemToList(const linked_ptr<base::DictionaryValue>& from,
> 
> 
> Compiling leads to several errors. A search for uses of ArrayBuffer in IDLs
(no
> idea about .jsons) reveals 24 files with several matches:
>  
>
https://code.google.com/p/chromium/codesearch#search/&q=file:extension.*idl$%...
> 
> Not that small a refactoring.

That SGTM, worst case you can write a little helper in util.h/cc which does the
necessary conversion in a single line, when it's not trivial to do so already.

[not at google - send to devlin, 2015-01-15 20:50:28]

Btw I'm assuming you're going to do it, not me :)

[pneubeck (no reviews), 2015-01-16 17:27:44]

On 2015/01/15 20:50:28, kalman wrote:
> Btw I'm assuming you're going to do it, not me :)

superseded by https://codereview.chromium.org/820673004/

[pneubeck (no reviews), 2015-01-19 07:42:37]

pneubeck@chromium.org changed reviewers:
- pneubeck@chromium.org