Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 850043002: Fix PDFBrowserTest.Basic crash. (Closed)

Created:
5 years, 11 months ago by eustas
Modified:
5 years, 11 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix PDFBrowserTest.Basic crash. Lock pixels before using them BUG=446347 Committed: https://crrev.com/4af83d259760738b1dbf59036a422ffbca308c79 Cr-Commit-Position: refs/heads/master@{#311577}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/pdf/pdf_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/pdf/pdf_browsertest_base.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
eustas
5 years, 11 months ago (2015-01-14 12:50:58 UTC) #2
Lei Zhang
lgtm
5 years, 11 months ago (2015-01-14 23:02:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/850043002/1
5 years, 11 months ago (2015-01-14 23:03:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-15 00:00:58 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 00:01:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4af83d259760738b1dbf59036a422ffbca308c79
Cr-Commit-Position: refs/heads/master@{#311577}

Powered by Google App Engine
This is Rietveld 408576698