chrome/browser/ui/pdf/pdf_browsertest_base.cc - Issue 850043002: Fix PDFBrowserTest.Basic crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/pdf/pdf_browsertest_base.cc

Issue 850043002: Fix PDFBrowserTest.Basic crash. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/pdf/pdf_browsertest_base.cc

diff --git a/chrome/browser/ui/pdf/pdf_browsertest_base.cc b/chrome/browser/ui/pdf/pdf_browsertest_base.cc

index fb6927ad15f687928f2544f9253bc70972d049e9..a230021d09ac12d9de328153e0af8b56e8da7bc4 100644

--- a/chrome/browser/ui/pdf/pdf_browsertest_base.cc

+++ b/chrome/browser/ui/pdf/pdf_browsertest_base.cc

@@ -133,6 +133,7 @@ void PDFBrowserTest::CopyFromBackingStoreCallback(

gfx::PNGCodec::FORMAT_BGRA, &decoded, &w, &h));

int32* ref_pixels = reinterpret_cast<int32*>(&decoded[0]);

+ SkAutoLockPixels lock_image(bitmap);

int32* pixels = static_cast<int32*>(bitmap.getPixels());

// Get the background color, and use it to figure out the x-offsets in

« no previous file with comments | « chrome/browser/ui/pdf/pdf_browsertest.cc ('k') | no next file » | no next file with comments »