Remove use of deprecated mirror API from pkg/unittest.

pkg/unittest/lib/mirror_matchers.dart

Index: pkg/unittest/lib/mirror_matchers.dart
diff --git a/pkg/unittest/lib/mirror_matchers.dart b/pkg/unittest/lib/mirror_matchers.dart
index 7d1597f2ac27f59c752109141a93a6a58ce6c51c..372b1357a4c93750aced10dccf82c9d2b2e5f59f 100644
--- a/pkg/unittest/lib/mirror_matchers.dart
+++ b/pkg/unittest/lib/mirror_matchers.dart
@@ -49,7 +49,11 @@ class _HasProperty extends Matcher {
     var mirror = reflect(item);
     var classMirror = mirror.type;
     var symbol = new Symbol(_name);
-    if (!classMirror.getters.containsKey(symbol)) {
+    var candidate = classMirror.declarations[symbol];
+    if (candidate == null ||
+        candidate is! MethodMirror ||

[Siggi Cherem (dart-lang), 2013/11/25 20:28:47]

shouldn't we exclude if candidate is a VariableMirror?

+        !candidate.isGetter ||
+        candidate.isStatic) {

[rmacnak, 2013/11/25 19:54:01]

This last clause changes the behavior. Presumably you only meant to test for an
instance getter.

[Siggi Cherem (dart-lang), 2013/11/25 20:28:47]

Makes sense, sgtm. Could we however split this check separately so we can
display an appropriate error message below?

       addStateInfo(matchState, {'reason': 'has no property named "$_name"'});
       return false;
     }