Remove use of deprecated mirror API from pkg/unittest.

pkg/unittest/lib/mirror_matchers.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 /**
  * The mirror matchers library provides some additional matchers that
  * make use of dart:mirrors.
  *
  * ## Installing ##
  *
  * Use [pub][] to install this package. Add the following to your `pubspec.yaml`
@@ skipping 31 matching lines @@
 class _HasProperty extends Matcher {
   final String _name;
   final Matcher _matcher;
 
   const _HasProperty(this._name, [this._matcher]);
 
   bool matches(item, Map matchState) {
     var mirror = reflect(item);
     var classMirror = mirror.type;
     var symbol = new Symbol(_name);
-    if (!classMirror.getters.containsKey(symbol)) {
+    var candidate = classMirror.declarations[symbol];
+    if (candidate == null ||
+        candidate is! MethodMirror ||

[Siggi Cherem (dart-lang), 2013/11/25 20:28:47]

shouldn't we exclude if candidate is a VariableMirror?

+        !candidate.isGetter ||
+        candidate.isStatic) {

[rmacnak, 2013/11/25 19:54:01]

This last clause changes the behavior. Presumably you only meant to test for an
instance getter.

[Siggi Cherem (dart-lang), 2013/11/25 20:28:47]

Makes sense, sgtm. Could we however split this check separately so we can
display an appropriate error message below?

       addStateInfo(matchState, {'reason': 'has no property named "$_name"'});
       return false;
     }
     if (_matcher == null) return true;
     var result = mirror.getField(symbol);
     var resultMatches = _matcher.matches(result.reflectee, matchState);
     if (!resultMatches) {
       addStateInfo(matchState, {'value': result.reflectee});
     }
     return resultMatches;
@@ skipping 18 matching lines @@
       var innerDescription = new StringDescription();
       _matcher.describeMismatch(matchState['value'], innerDescription,
           matchState['state'], verbose);
       if (innerDescription.length > 0) {
         mismatchDescription.add(' which ').add(innerDescription.toString());
       }
     }
     return mismatchDescription;
   }
 }