Event.path should include Window

Source/core/events/TreeScopeEventContext.cpp

Index: Source/core/events/TreeScopeEventContext.cpp
diff --git a/Source/core/events/TreeScopeEventContext.cpp b/Source/core/events/TreeScopeEventContext.cpp
index bdf4c0fbed4690d62932af0a6b500b38df85007c..dd3cc9059a65cce786b9a81dc0c78b8400488b2e 100644
--- a/Source/core/events/TreeScopeEventContext.cpp
+++ b/Source/core/events/TreeScopeEventContext.cpp
@@ -34,22 +34,24 @@
 
 namespace blink {
 
-PassRefPtrWillBeRawPtr<StaticNodeList> TreeScopeEventContext::ensureEventPath(EventPath& path)
+WillBeHeapVector<RefPtrWillBeRawPtr<EventTarget>>& TreeScopeEventContext::ensureEventPath(EventPath& path)
 {
     if (m_eventPath)
-        return m_eventPath;
+        return *m_eventPath;
 
-    WillBeHeapVector<RefPtrWillBeMember<Node>> nodes;
-    nodes.reserveInitialCapacity(path.size());
+    LocalDOMWindow* window = path.hasWindowEventContext() ? path.windowEventContext().window() : nullptr;

[hayato, 2015/01/15 08:27:39]

I've taken a look at Event::path(). I think Event::path() never calls
TreeScopeEventContext::ensureEventPath() when path.m_WindowEventContext is not
set because it calls TreeScopeEventContext::ensureEventPath() only when an event
dispatch is finished (or while being dispatched).

I guess path.windowEventContext() is guaranteed to be set here. You can revert
EventPath::hasWindowEventContext() if you can agree.

You could also move this line into line 52. That's preferred.

e.g. 
if (LocalDOMWindow* window = ....)
  m_eventPath->append(window);

[kojii, 2015/01/16 08:37:23]

Reverted. I thought |LocalDOMWindow::dispatchLoadEvent()| will hit this, but
you're right that in that case |Event::path()| returns without calling this
function.
I need |window| in line 44 to determine the capacity. Swapped 42 and 43 to  make
it more obvious.

+    m_eventPath = adoptPtrWillBeNoop(new WillBeHeapVector<RefPtrWillBeRawPtr<EventTarget>>());
+    m_eventPath->reserveCapacity(path.size() + window ? 1 : 0);
     for (size_t i = 0; i < path.size(); ++i) {
         Node& rootNode = path[i].treeScopeEventContext().rootNode();
         if (rootNode.isShadowRoot() && toShadowRoot(rootNode).type() == ShadowRoot::AuthorShadowRoot)
-            nodes.append(path[i].node());
+            m_eventPath->append(path[i].node());
         else if (path[i].treeScopeEventContext().isInclusiveAncestorOf(*this))
-            nodes.append(path[i].node());
+            m_eventPath->append(path[i].node());
     }
-    m_eventPath = StaticNodeList::adopt(nodes);
-    return m_eventPath;
+    if (window)
+        m_eventPath->append(window);
+    return *m_eventPath;
 }
 
 TouchEventContext* TreeScopeEventContext::ensureTouchEventContext()