Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: Source/core/events/Event.cpp

Issue 849783002: Event.path should include Window (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: comments fixed Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/events/Event.cpp
diff --git a/Source/core/events/Event.cpp b/Source/core/events/Event.cpp
index 09aea35a8b7f01ca55c0788ab8aff6a4c95ffd6b..235eddd49219e2abb9a71ba2a363d817038bf392 100644
--- a/Source/core/events/Event.cpp
+++ b/Source/core/events/Event.cpp
@@ -236,20 +236,20 @@ void Event::initEventPath(Node& node)
m_eventPath = adoptPtrWillBeNoop(new EventPath(node, this));
}
-PassRefPtrWillBeRawPtr<StaticNodeList> Event::path() const
+Vector<RefPtrWillBeRawPtr<EventTarget>> Event::path() const
hayato 2015/01/15 08:27:39 WillBeHeapVector?
kojii 2015/01/16 08:37:23 Done.
{
if (!m_currentTarget) {
ASSERT(m_eventPhase == Event::NONE);
if (!m_eventPath) {
// Before dispatching the event
- return StaticNodeList::createEmpty();
+ return WillBeHeapVector<RefPtrWillBeRawPtr<EventTarget>>();
}
ASSERT(!m_eventPath->isEmpty());
// After dispatching the event
return m_eventPath->last().treeScopeEventContext().ensureEventPath(*m_eventPath);
}
if (!m_currentTarget->toNode())
- return StaticNodeList::createEmpty();
+ return WillBeHeapVector<RefPtrWillBeRawPtr<EventTarget>>();
Node* node = m_currentTarget->toNode();
size_t eventPathSize = m_eventPath->size();
for (size_t i = 0; i < eventPathSize; ++i) {
@@ -257,7 +257,7 @@ PassRefPtrWillBeRawPtr<StaticNodeList> Event::path() const
return (*m_eventPath)[i].treeScopeEventContext().ensureEventPath(*m_eventPath);
}
}
- return StaticNodeList::createEmpty();
+ return WillBeHeapVector<RefPtrWillBeRawPtr<EventTarget>>();
}
EventTarget* Event::currentTarget() const

Powered by Google App Engine
This is Rietveld 408576698