Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 8497006: Merge 107584 - [cros] Don't succeed if user has default profile picture. Merge 108860 - [cros] Fi... (Closed)

Created:
9 years, 1 month ago by Ivan Korotkov
Modified:
9 years, 1 month ago
Reviewers:
whywhat
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Merge 107584 - [cros] Don't succeed if user has default profile picture. Merge 108860 - [cros] Fix default profile photo detection. R=ivankr@chromium.org BUG=chromium-os:22125 TEST=Verify that for users with default profile picture it's not downloaded and shown on image screen or change picture page. Review URL: http://codereview.chromium.org/8399005 Review URL: http://codereview.chromium.org/8490012 TBR=avayvod@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108980

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -2 lines) Patch
M chrome/browser/chromeos/login/profile_image_downloader.h View 3 chunks +18 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/profile_image_downloader.cc View 1 4 chunks +57 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/user_image_screen.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/user_image_screen.cc View 1 chunk +17 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_manager.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager.cc View 3 chunks +21 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc View 2 chunks +26 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Ivan Korotkov
9 years, 1 month ago (2011-11-08 07:39:18 UTC) #1
Ivan Korotkov
9 years, 1 month ago (2011-11-08 07:41:21 UTC) #2

          

Powered by Google App Engine
This is Rietveld 408576698