Issue 8399005: [cros] Don't succeed if user has default profile picturewq

Issue 8399005: [cros] Don't succeed if user has default profile picturewq (Closed)

Created:
9 years, 1 month ago by whywhat

Modified:
9 years, 1 month ago

Reviewers:
Ivan Korotkov

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[cros] Don't succeed if user has default profile picturewq R=ivankr@chromium.org BUG=chromium-os:22125 TEST=Verify that for users with default profile picture it's not downloaded and shown on image screen or change picture page. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107584

Patch Set 1 #

Total comments: 2

Patch Set 2 : Histograms with download results. Better path parsing #

Total comments: 1

Patch Set 3 : Fixed stats for change picture options #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+138 lines, -2 lines)			Patch
M	chrome/browser/chromeos/login/profile_image_downloader.h	View	1	3 chunks	+18 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/profile_image_downloader.cc	View	1	4 chunks	+50 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/user_image_screen.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/user_image_screen.cc	View	1	1 chunk	+17 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/user_manager.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/user_manager.cc	View	1	3 chunks	+21 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc	View	1 2	2 chunks	+26 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Korotkov

http://codereview.chromium.org/8399005/diff/1/chrome/browser/chromeos/login/profile_image_downloader.cc File chrome/browser/chromeos/login/profile_image_downloader.cc (right): http://codereview.chromium.org/8399005/diff/1/chrome/browser/chromeos/login/profile_image_downloader.cc#newcode123 chrome/browser/chromeos/login/profile_image_downloader.cc:123: if (image_url_object.path().find(component) != std::string::npos) This will match /AAAAAAAAAA/ anywhere ...

9 years, 1 month ago (2011-10-26 20:43:57 UTC) #2

whywhat

Added histograms http://codereview.chromium.org/8399005/diff/1/chrome/browser/chromeos/login/profile_image_downloader.cc File chrome/browser/chromeos/login/profile_image_downloader.cc (right): http://codereview.chromium.org/8399005/diff/1/chrome/browser/chromeos/login/profile_image_downloader.cc#newcode123 chrome/browser/chromeos/login/profile_image_downloader.cc:123: if (image_url_object.path().find(component) != std::string::npos) On 2011/10/26 20:43:57, ...

9 years, 1 month ago (2011-10-27 13:28:10 UTC) #3

Ivan Korotkov

9 years, 1 month ago (2011-10-27 13:58:15 UTC) #4

LGTM

http://codereview.chromium.org/8399005/diff/5001/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc
(right):

http://codereview.chromium.org/8399005/diff/5001/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc:314:
VLOG(1) << "Updating profile image for the user";
As discussed offline, this will report a change everytime a profile image is
download and profile_image_data_url_ is kAboutUrl.

Expand Messages | Collapse Messages