Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 849693003: Support concatenating with zero-size arrays with DICTIONARY_ELEMENTS in Runtime_ArrayConcat. (Closed)

Created:
5 years, 11 months ago by Igor Sheludko
Modified:
5 years, 11 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Support concatenating with zero-size arrays with DICTIONARY_ELEMENTS in Runtime_ArrayConcat. BUG=chromium:450895 LOG=y Committed: https://crrev.com/8ccc696bf64248f7f1cd228362f21f12f80db96d Cr-Commit-Position: refs/heads/master@{#26219}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/runtime/runtime-array.cc View 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-450895.js View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Igor Sheludko
PTAL
5 years, 11 months ago (2015-01-22 09:55:34 UTC) #2
Yang
lgtm
5 years, 11 months ago (2015-01-22 10:44:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/849693003/1
5 years, 11 months ago (2015-01-22 10:45:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-22 11:15:21 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 11:15:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ccc696bf64248f7f1cd228362f21f12f80db96d
Cr-Commit-Position: refs/heads/master@{#26219}

Powered by Google App Engine
This is Rietveld 408576698