Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: src/runtime/runtime-array.cc

Issue 849693003: Support concatenating with zero-size arrays with DICTIONARY_ELEMENTS in Runtime_ArrayConcat. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-450895.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/runtime/runtime-utils.h" 8 #include "src/runtime/runtime-utils.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 832 matching lines...) Expand 10 before | Expand all | Expand 10 after
843 break; 843 break;
844 } 844 }
845 int32_t int_value = Smi::cast(element)->value(); 845 int32_t int_value = Smi::cast(element)->value();
846 double_storage->set(j, int_value); 846 double_storage->set(j, int_value);
847 j++; 847 j++;
848 } 848 }
849 break; 849 break;
850 } 850 }
851 case FAST_HOLEY_ELEMENTS: 851 case FAST_HOLEY_ELEMENTS:
852 case FAST_ELEMENTS: 852 case FAST_ELEMENTS:
853 case DICTIONARY_ELEMENTS:
853 DCHECK_EQ(0, length); 854 DCHECK_EQ(0, length);
854 break; 855 break;
855 default: 856 default:
856 UNREACHABLE(); 857 UNREACHABLE();
857 } 858 }
858 } 859 }
859 if (failure) break; 860 if (failure) break;
860 } 861 }
861 } 862 }
862 if (!failure) { 863 if (!failure) {
(...skipping 446 matching lines...) Expand 10 before | Expand all | Expand 10 after
1309 } 1310 }
1310 1311
1311 1312
1312 RUNTIME_FUNCTION(RuntimeReference_FastOneByteArrayJoin) { 1313 RUNTIME_FUNCTION(RuntimeReference_FastOneByteArrayJoin) {
1313 SealHandleScope shs(isolate); 1314 SealHandleScope shs(isolate);
1314 DCHECK(args.length() == 2); 1315 DCHECK(args.length() == 2);
1315 return isolate->heap()->undefined_value(); 1316 return isolate->heap()->undefined_value();
1316 } 1317 }
1317 } 1318 }
1318 } // namespace v8::internal 1319 } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-450895.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698