Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 849553002: Fix some sandbox memory leaks (Closed)

Created:
5 years, 11 months ago by Will Harris
Modified:
5 years, 11 months ago
CC:
chromium-reviews, wfh+watch_chromium.org, Yun
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix some sandbox memory leaks The memory allocated by AllocAndCopyName was not being freed under certain conditions. Credit to yunli.sharing@gmail.com for spotting these. BUG=414039 Committed: https://crrev.com/43aa4044b86faeab356265252b0fe9cac36e6568 Cr-Commit-Position: refs/heads/master@{#311079}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M sandbox/win/src/filesystem_interception.cc View 4 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Will Harris
PTAL
5 years, 11 months ago (2015-01-12 06:54:57 UTC) #2
Will Harris
actually ignoring git cl owners, best for cpu@ to review as he changed this same ...
5 years, 11 months ago (2015-01-12 07:32:26 UTC) #4
jschuh
Drive-by lgtm since this is a straightforward fix. cpu@, I hope you don't mind me ...
5 years, 11 months ago (2015-01-12 19:00:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/849553002/1
5 years, 11 months ago (2015-01-12 19:01:31 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-12 19:13:19 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-12 19:14:18 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43aa4044b86faeab356265252b0fe9cac36e6568
Cr-Commit-Position: refs/heads/master@{#311079}

Powered by Google App Engine
This is Rietveld 408576698