Fix some sandbox memory leaks

sandbox/win/src/filesystem_interception.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sandbox/win/src/filesystem_interception.h"
 
 #include "sandbox/win/src/crosscall_client.h"
 #include "sandbox/win/src/ipc_tags.h"
 #include "sandbox/win/src/policy_params.h"
 #include "sandbox/win/src/policy_target.h"
@@ skipping 56 matching lines @@
     SharedMemIPCClient ipc(memory);
     CrossCallReturn answer = {0};
     // The following call must match in the parameters with
     // FilesystemDispatcher::ProcessNtCreateFile.
     ResultCode code = CrossCall(ipc, IPC_NTCREATEFILE_TAG, name, attributes,
                                 desired_access_uint32, file_attributes, sharing,
                                 disposition, options_uint32, &answer);
     if (SBOX_ALL_OK != code)
       break;
 
+    status = answer.nt_status;
+
     if (!NT_SUCCESS(answer.nt_status))
-        return answer.nt_status;
+      break;
 
     __try {
       *file = answer.handle;
       io_status->Status = answer.nt_status;
       io_status->Information = answer.extended[0].ulong_ptr;
-      status = io_status->Status;
     } __except(EXCEPTION_EXECUTE_HANDLER) {
       break;
     }
   } while (false);
 
   if (name)
     operator delete(name, NT_ALLOC);
 
   return status;
 }
@@ skipping 43 matching lines @@
       break;
 
     SharedMemIPCClient ipc(memory);
     CrossCallReturn answer = {0};
     ResultCode code = CrossCall(ipc, IPC_NTOPENFILE_TAG, name, attributes,
                                 desired_access_uint32, sharing, options_uint32,
                                 &answer);
     if (SBOX_ALL_OK != code)
       break;
 
+    status = answer.nt_status;
+
     if (!NT_SUCCESS(answer.nt_status))
-      return answer.nt_status;
+      break;
 
     __try {
       *file = answer.handle;
       io_status->Status = answer.nt_status;
       io_status->Information = answer.extended[0].ulong_ptr;
-      status = io_status->Status;
     } __except(EXCEPTION_EXECUTE_HANDLER) {
       break;
     }
   } while (false);
 
   if (name)
     operator delete(name, NT_ALLOC);
 
   return status;
 }
@@ skipping 35 matching lines @@
     params[FileName::BROKER] = ParamPickerMake(broker);
 
     if (!QueryBroker(IPC_NTQUERYATTRIBUTESFILE_TAG, params.GetBase()))
       break;
 
     SharedMemIPCClient ipc(memory);
     CrossCallReturn answer = {0};
     ResultCode code = CrossCall(ipc, IPC_NTQUERYATTRIBUTESFILE_TAG, name,
                                 attributes, file_info, &answer);
 
-    operator delete(name, NT_ALLOC);
-
     if (SBOX_ALL_OK != code)
       break;
 
-    return answer.nt_status;
+    status = answer.nt_status;
 
   } while (false);
 
   if (name)
     operator delete(name, NT_ALLOC);
 
   return status;
 }
 
 NTSTATUS WINAPI TargetNtQueryFullAttributesFile(
@@ skipping 35 matching lines @@
     params[FileName::BROKER] = ParamPickerMake(broker);
 
     if (!QueryBroker(IPC_NTQUERYFULLATTRIBUTESFILE_TAG, params.GetBase()))
       break;
 
     SharedMemIPCClient ipc(memory);
     CrossCallReturn answer = {0};
     ResultCode code = CrossCall(ipc, IPC_NTQUERYFULLATTRIBUTESFILE_TAG, name,
                                 attributes, file_info, &answer);
 
-    operator delete(name, NT_ALLOC);
-
     if (SBOX_ALL_OK != code)
       break;
 
-    return answer.nt_status;
+    status = answer.nt_status;
   } while (false);
 
   if (name)
     operator delete(name, NT_ALLOC);
 
   return status;
 }
 
 NTSTATUS WINAPI TargetNtSetInformationFile(
     NtSetInformationFileFunction orig_SetInformationFile, HANDLE file,
@@ skipping 68 matching lines @@
     status = answer.nt_status;
   } while (false);
 
   if (name)
     operator delete(name, NT_ALLOC);
 
   return status;
 }
 
 }  // namespace sandbox