Change the default for the len argument to writeFrom on OutputStream

Change the default for the len argument to writeFrom on OutputStream

Fixed a bug in the writing code as a result.

Also added copyByffer argument to one of the write methods on the OutputStream interface.

R=ager@google.com

BUG=dart:292
TEST=EchoServerStreamTest.dart

Committed: https://code.google.com/p/dart/source/detail?r=1293

[Mads Ager (google), 2011-11-07 09:18:34]

lgtm

http://codereview.chromium.org/8493002/diff/2001/runtime/bin/output_stream.dart
File runtime/bin/output_stream.dart (right):

http://codereview.chromium.org/8493002/diff/2001/runtime/bin/output_stream.da...
runtime/bin/output_stream.dart:21: * true ownership of the specified buffer is
passed to the system
Really? I would have guessed that copyBuffer means that a copy is taken and
therefore the caller is free to do what it wants with what it passed in?

http://codereview.chromium.org/8493002/diff/2001/runtime/bin/socket_stream.dart
File runtime/bin/socket_stream.dart (right):

http://codereview.chromium.org/8493002/diff/2001/runtime/bin/socket_stream.da...
runtime/bin/socket_stream.dart:110: bool write(List<int> buffer, [bool
copyBuffer = false]) {
Ah, it is actually false by default. Update comment in socket_stream.dart.

[Søren Gjesse, 2011-11-08 09:31:53]

http://codereview.chromium.org/8493002/diff/2001/runtime/bin/output_stream.dart
File runtime/bin/output_stream.dart (right):

http://codereview.chromium.org/8493002/diff/2001/runtime/bin/output_stream.da...
runtime/bin/output_stream.dart:21: * true ownership of the specified buffer is
passed to the system
On 2011/11/07 09:18:34, Mads Ager wrote:
> Really? I would have guessed that copyBuffer means that a copy is taken and
> therefore the caller is free to do what it wants with what it passed in?

Of cause that was wrong. copyBuffer == true means that a copy is taken.

http://codereview.chromium.org/8493002/diff/2001/runtime/bin/socket_stream.dart
File runtime/bin/socket_stream.dart (right):

http://codereview.chromium.org/8493002/diff/2001/runtime/bin/socket_stream.da...
runtime/bin/socket_stream.dart:110: bool write(List<int> buffer, [bool
copyBuffer = false]) {
On 2011/11/07 09:18:34, Mads Ager wrote:
> Ah, it is actually false by default. Update comment in socket_stream.dart.

Changed to default to be true (as stated in the comment). I think it is the
right conservative default.