Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: tests/standalone/src/EchoServerStreamTest.dart

Issue 8493002: Change the default for the len argument to writeFrom on OutputStream (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments from ager@ Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/socket_stream.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/src/EchoServerStreamTest.dart
diff --git a/tests/standalone/src/EchoServerStreamTest.dart b/tests/standalone/src/EchoServerStreamTest.dart
index 992c42262d2a48c62df718542677bac94b8a6368..a132f3568b28c6dc2e95ba5fe6295df208dd7697 100644
--- a/tests/standalone/src/EchoServerStreamTest.dart
+++ b/tests/standalone/src/EchoServerStreamTest.dart
@@ -91,7 +91,23 @@ class EchoServerGame {
_socket.closeHandler = closeHandler;
_socket.errorHandler = errorHandler;
- stream.write(_buffer);
+
+ // Test both write and writeFrom in different forms.
+ switch (_messages % 2) {
+ case 0:
+ stream.write(_buffer);
+ break;
+ case 1:
+ stream.write(_buffer, false);
+ break;
+ case 2:
+ stream.writeFrom(_buffer);
+ break;
+ case 3:
+ stream.writeFrom(_buffer, len: _buffer.length ~/ 2);
+ stream.writeFrom(_buffer, _buffer.length ~/ 2);
+ break;
+ }
stream.close();
dataSent();
}
« no previous file with comments | « runtime/bin/socket_stream.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698