Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 8493001: Merge 99067 - REGRESSION(r96870): WebKit generates background: transparent on blogger.com (Closed)

Created:
9 years, 1 month ago by rniwa-cr
Modified:
9 years, 1 month ago
Reviewers:
rniwa
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/912/
Visibility:
Public.

Description

Merge 99067 - REGRESSION(r96870): WebKit generates background: transparent on blogger.com https://bugs.webkit.org/show_bug.cgi?id=71203 Reviewed by Ojan Vafai. Source/WebCore: Remove the transparent background color from inline style declarations in the pasted content. Also fixed a bug in removeStyleFromRulesAndContext that it removes properties in inline style declarations even if those properties were overridden. Tests: editing/deleting/merge-paragraphs-with-transparent-background.html editing/deleting/paste-with-transparent-background-color.html * editing/EditingStyle.cpp: (WebCore::removePropertiesInStyle): (WebCore::EditingStyle::removeStyleFromRulesAndContext): (WebCore::EditingStyle::removePropertiesInElementDefaultStyle): LayoutTests: Added a test to merge paragraphs inside a document with background: transparent, and a test to cut and paste contents with background: transparent, which is overriding a style rule background: blue. WebKit should preserve the appearance of the pasted content but should not add a redundant background: transparent. * editing/deleting/merge-paragraphs-with-transparent-background-expected.txt: Added. * editing/deleting/merge-paragraphs-with-transparent-background.html: Added. * editing/deleting/paste-with-transparent-background-color-expected.txt: Added. * editing/deleting/paste-with-transparent-background-color.html: Added. TBR=rniwa@webkit.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99393

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14705 lines, -152 lines) Patch
M LayoutTests/ChangeLog View 114 chunks +5810 lines, -148 lines 0 comments Download
A + LayoutTests/editing/deleting/merge-paragraphs-with-transparent-background.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/editing/deleting/merge-paragraphs-with-transparent-background-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/editing/deleting/paste-with-transparent-background-color.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/editing/deleting/paste-with-transparent-background-color-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/ChangeLog View 1 chunk +8883 lines, -0 lines 0 comments Download
M Source/WebCore/editing/EditingStyle.cpp View 3 chunks +16 lines, -8 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
rniwa-cr
9 years, 1 month ago (2011-11-07 03:12:55 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698