Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: Source/WebCore/ChangeLog

Issue 8493001: Merge 99067 - REGRESSION(r96870): WebKit generates background: transparent on blogger.com (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/912/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 2011-11-02 Ryosuke Niwa <rniwa@webkit.org>
2
3 REGRESSION(r96870): WebKit generates background: transparent on blogger. com
4 https://bugs.webkit.org/show_bug.cgi?id=71203
5
6 Reviewed by Ojan Vafai.
7
8 Remove the transparent background color from inline style declarations i n the pasted content.
9 Also fixed a bug in removeStyleFromRulesAndContext that it removes prope rties in inline style
10 declarations even if those properties were overridden.
11
12 Tests: editing/deleting/merge-paragraphs-with-transparent-background.htm l
13 editing/deleting/paste-with-transparent-background-color.html
14
15 * editing/EditingStyle.cpp:
16 (WebCore::removePropertiesInStyle):
17 (WebCore::EditingStyle::removeStyleFromRulesAndContext):
18 (WebCore::EditingStyle::removePropertiesInElementDefaultStyle):
19
20 2011-11-02 Andreas Kling <kling@webkit.org>
21
22 CSSStyleRule: Devirtualize selectorText()
23 https://bugs.webkit.org/show_bug.cgi?id=71364
24
25 Reviewed by Antti Koivisto.
26
27 Have CSSStyleRule::selectorText() redirect to CSSPageRule::pageSelectorT ext()
28 if type() is PAGE_RULE.
29
30 * css/CSSPageRule.cpp:
31 (WebCore::CSSPageRule::pageSelectorText):
32 * css/CSSPageRule.h:
33 * css/CSSStyleRule.cpp:
34 (WebCore::CSSStyleRule::selectorText):
35 * css/CSSStyleRule.h:
36
37 2011-11-02 Andreas Kling <kling@webkit.org>
38
39 CSSRule: Devirtualize cssText()
40 https://bugs.webkit.org/show_bug.cgi?id=71292
41
42 Reviewed by Antti Koivisto.
43
44 Have CSSRule::cssText() redirect to the appropriate subclass based on ty pe().
45 This is one of the last steps of devirtualizing CSSRule completely, whic h will
46 allow us to get rid of its vtable, and each instance's pointer thereto.
47
48 * css/CSSCharsetRule.h:
49 * css/CSSFontFaceRule.h:
50 * css/CSSImportRule.h:
51 * css/CSSMediaRule.h:
52 * css/CSSRegionStyleRule.h:
53 * css/CSSRule.cpp:
54 (WebCore::CSSRule::cssText):
55 * css/CSSRule.h:
56 * css/CSSStyleRule.h:
57 * css/WebKitCSSKeyframeRule.h:
58 * css/WebKitCSSKeyframesRule.h:
59
60 2011-11-02 Patrick Gansterer <paroga@webkit.org>
61
62 Unreviewed build fix for !ENABLE(FILTERS) after r98989.
63
64 * rendering/svg/SVGResourcesCache.cpp:
65 (WebCore::SVGResourcesCache::clientLayoutChanged):
66
67 2011-11-02 Alexander Pavlov <apavlov@chromium.org>
68
69 Web Inspector: [REGRESSION] Clicking in a CSS property/value being edite d commits the editor
70 https://bugs.webkit.org/show_bug.cgi?id=71360
71
72 Reviewed by Pavel Feldman.
73
74 Selecting a selected TreeElement should be an idempotent operation.
75
76 * inspector/front-end/treeoutline.js:
77 (TreeElement.prototype.select):
78
79 2011-11-02 Ben Wells <benwells@chromium.org>
80
81 Canvas filling paths or rects need to be invalidate larger rects for som e compositing modes.
82 https://bugs.webkit.org/show_bug.cgi?id=70379
83
84 Reviewed by James Robinson.
85
86 Test: fast/canvas/canvas-composite-fill-repaint.html
87
88 * html/canvas/CanvasRenderingContext2D.cpp:
89 (WebCore::CanvasRenderingContext2D::fill):
90 (WebCore::CanvasRenderingContext2D::fillRect):
91 (WebCore::CanvasRenderingContext2D::drawImage):
92 (WebCore::CanvasRenderingContext2D::didDrawEntireCanvas):
93 * html/canvas/CanvasRenderingContext2D.h:
94
95 2011-11-01 Levi Weintraub <leviw@chromium.org>
96
97 Fix uses of LayoutUnit in Frame-, Scroll-, and RenderView
98 https://bugs.webkit.org/show_bug.cgi?id=71321
99
100 Reviewed by Darin Adler.
101
102 Updating the usage of LayoutUnits in the *View classes to mirror the pro per use
103 as derived in the subpixellayout branch.
104
105 This entails scrolling only with integers (and rounding once we've made the switch)
106 and using integers for window coordinates, with LayoutUnits for content coordinates.
107
108 No new tests -- no change in behavior.
109
110 * page/FrameView.cpp:
111 (WebCore::FrameView::invalidateRect):
112 (WebCore::FrameView::setFrameRect):
113 (WebCore::FrameView::zoomAnimatorTransformChanged):
114 (WebCore::FrameView::scrollContentsFastPath):
115 (WebCore::FrameView::scrollContentsSlowPath):
116 (WebCore::FrameView::scrollElementToRect):
117 (WebCore::FrameView::setScrollPosition):
118 (WebCore::FrameView::repaintContentRectangle):
119 (WebCore::FrameView::scrollTo):
120 (WebCore::FrameView::updateScrollCorner):
121 * page/FrameView.h:
122 (WebCore::FrameView::trackedRepaintRects):
123 * platform/ScrollView.cpp:
124 (WebCore::ScrollView::visibleContentRect):
125 (WebCore::ScrollView::layoutWidth):
126 (WebCore::ScrollView::layoutHeight):
127 (WebCore::ScrollView::fixedLayoutSize):
128 (WebCore::ScrollView::setFixedLayoutSize):
129 (WebCore::ScrollView::contentsSize):
130 (WebCore::ScrollView::setContentsSize):
131 (WebCore::ScrollView::overhangAmount):
132 (WebCore::ScrollView::updateScrollbars):
133 (WebCore::ScrollView::rectToCopyOnScroll):
134 (WebCore::ScrollView::scrollContents):
135 (WebCore::ScrollView::windowToContents):
136 (WebCore::ScrollView::screenToContents):
137 (WebCore::ScrollView::scrollbarAtPoint):
138 (WebCore::ScrollView::wheelEvent):
139 * platform/ScrollView.h:
140 (WebCore::ScrollView::visibleWidth):
141 (WebCore::ScrollView::visibleHeight):
142 (WebCore::ScrollView::contentsWidth):
143 (WebCore::ScrollView::contentsHeight):
144 (WebCore::ScrollView::adjustScrollPositionWithinRange):
145 * rendering/RenderView.cpp:
146 (WebCore::RenderView::paint):
147 (WebCore::RenderView::shouldRepaint):
148 (WebCore::RenderView::repaintViewRectangle):
149 (WebCore::RenderView::repaintRectangleInViewAndCompositedLayers):
150 (WebCore::RenderView::computeRectForRepaint):
151 (WebCore::RenderView::selectionBounds):
152 (WebCore::RenderView::viewRect):
153 (WebCore::RenderView::unscaledDocumentRect):
154 (WebCore::RenderView::documentRect):
155 * rendering/RenderView.h:
156 (WebCore::RenderView::printRect):
157 (WebCore::RenderView::setPrintRect):
158
159 2011-11-01 Anna Cavender <annacc@chromium.org>
160
161 Small fixes for WebVTTParser.
162 https://bugs.webkit.org/show_bug.cgi?id=71334
163
164 Reviewed by Darin Adler.
165
166 No new tests. This is needed to enable other tests, coming soon.
167
168 * html/track/WebVTTParser.cpp:
169 (WebCore::hasLongWebVTTIdentifier): changed to return true when header i s
170 exactly "WEBVTT"
171 (WebCore::WebVTTParser::collectTimingsAndSettings): fix typos, position should
172 only progress once when checking the character after a timestamp.
173
174 2011-11-01 Darin Adler <darin@apple.com>
175
176 Change HTMLSelectElement::setSelectedIndex to use enums instead of bools
177 https://bugs.webkit.org/show_bug.cgi?id=70184
178
179 Reviewed by Kent Tamura.
180
181 Refactoring that does not require new tests.
182
183 * bindings/objc/DOMHTML.mm:
184 (-[DOMHTMLSelectElement _activateItemAtIndex:]): Replaced setSelectedInd exByUser
185 call with a call to the renamed optionSelectedByUser, also removed one a rgument.
186 (-[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:]): Ditto.
187
188 * html/HTMLOptionElement.cpp:
189 (WebCore::HTMLOptionElement::setSelected): Replaced setSelectedIndex cal l with a
190 call to the new optionSelectionStateChanged function.
191 (WebCore::HTMLOptionElement::insertedIntoTree): Ditto.
192
193 * html/HTMLSelectElement.cpp:
194 (WebCore::HTMLSelectElement::HTMLSelectElement): Updated since m_userDri venChange
195 was renamed to m_isProcessingUserDrivenChange.
196 (WebCore::HTMLSelectElement::optionSelectedByUser): Removed deselect arg ument,
197 which was always true for all callers. Updated comment.
198 (WebCore::HTMLSelectElement::hasPlaceholderLabelOption): Updated comment .
199 (WebCore::HTMLSelectElement::setOption): Call the new optionSelectionSta teChanged
200 function. The code used to explicitly ask the function it calls to desel ect base
201 on the value of m_multiple, but that is no longer needed because the sel ectOption
202 function itself takes care of that check.
203 (WebCore::HTMLSelectElement::dispatchChangeEventForMenuList): Renamed th is function.
204 Also updated for name change to m_isProcessingUserDrivenChange.
205 (WebCore::HTMLSelectElement::setSelectedIndex): Moved the formerly-inlin ed function
206 here from the header and changed it to call the renamed selectOption fun ction.
207 (WebCore::HTMLSelectElement::optionSelectionStateChanged): Added this fu nction.
208 It is used by callers that were previously using setSelectedIndex and pa ssing
209 "false" for the deselect argument. It's better now that setSelectedIndex is now a
210 pure DOM setter function without the multiple purposes it had before. Th is function
211 now has the logic that handles the special handling when deselecting an option,
212 which used to be at the top of the next function.
213 (WebCore::HTMLSelectElement::selectOption): Renamed this from setSelecte dIndex.
214 Replaced boolean arguments with flags. Removed code to handle the specia l case
215 when we deselect an option; that's now handled in the optionSelectionSta teChanged
216 function. Added an assertion to replace a comment and updated for other renaming.
217 (WebCore::HTMLSelectElement::dispatchBlurEvent): Updated for name change .
218 (WebCore::HTMLSelectElement::platformHandleKeydownEvent): Ditto.
219 (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Changed to ca ll the
220 new selectOption function and also updated for other name changes.
221 (WebCore::HTMLSelectElement::typeAheadFind): Ditto.
222 (WebCore::HTMLSelectElement::accessKeySetSelectedIndex): Ditto.
223
224 * html/HTMLSelectElement.h: Changed the setSelectedIndex to be a pure se tter
225 function for the selectedIndex DOM property. Added a optionSelectedByUse r function
226 for the other use of setSelectedIndex, but removed the always true "dese lect"
227 argument from it. Added a optionSelectionStateChanged function for use i n the
228 HTMLOptionElement implementation. Renamed menuListOnChange to
229 dispatchChangeEventForMenuList for clarity. Added a SelectOptionFlag and
230 SelectOptionFlags type for the arguments to the selectOption function, f ormerly
231 implemented as an overload of setSelectedIndex (and called setSelectedIn dexInternal
232 before that). Renamed m_userDrivenChange to m_isProcessingUserDrivenChan ge.
233
234 * rendering/RenderMenuList.cpp:
235 (WebCore::RenderMenuList::valueChanged): Replaced setSelectedIndexByUser
236 call with a call to the renamed optionSelectedByUser, also removed one a rgument.
237
238 2011-11-01 Sam Weinig <sam@webkit.org>
239
240 Implement __lookupGetter__/__lookupSetter__ in terms of getPropertyDescr iptor
241 https://bugs.webkit.org/show_bug.cgi?id=71336
242
243 Reviewed by Darin Adler.
244
245 * bindings/js/JSDOMWindowCustom.cpp:
246 * bindings/js/JSDOMWindowShell.cpp:
247 * bindings/js/JSDOMWindowShell.h:
248 * page/DOMWindow.idl:
249 Remove overrides of lookupGetter/lookupSetter, which are no longer neede d
250 due to implementing getPropertyDescriptor.
251
252
253 2011-11-01 Nat Duca <nduca@chromium.org>
254
255 [chromium] Move resource-releasing logic into CCProxy and cleanup setNee dsCommit
256 https://bugs.webkit.org/show_bug.cgi?id=71269
257
258 Reviewed by James Robinson.
259
260 * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
261 (WebCore::CCLayerTreeHost::finishCommitOnImplThread):
262 (WebCore::CCLayerTreeHost::setZoomAnimatorTransform):
263 (WebCore::CCLayerTreeHost::setNeedsCommit):
264 (WebCore::CCLayerTreeHost::setViewport):
265 (WebCore::CCLayerTreeHost::setVisible):
266 * platform/graphics/chromium/cc/CCLayerTreeHost.h:
267 * platform/graphics/chromium/cc/CCProxy.h:
268 * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
269 (WebCore::CCSingleThreadProxy::doCommit):
270 (WebCore::CCSingleThreadProxy::setNeedsRedraw):
271 (WebCore::CCSingleThreadProxy::setVisible):
272 (WebCore::CCSingleThreadProxy::recreateContextIfNeeded):
273 (WebCore::CCSingleThreadProxy::doComposite):
274 * platform/graphics/chromium/cc/CCSingleThreadProxy.h:
275 (WebCore::CCSingleThreadProxy::setNeedsRedrawOnImplThread):
276 (WebCore::CCSingleThreadProxy::setNeedsCommitOnImplThread):
277 * platform/graphics/chromium/cc/CCThreadProxy.cpp:
278 (WebCore::CCThreadProxy::setNeedsCommit):
279 (WebCore::CCThreadProxy::setNeedsAnimateOnImplThread):
280 (WebCore::CCThreadProxy::setVisible):
281 * platform/graphics/chromium/cc/CCThreadProxy.h:
282
283 2011-11-01 Anna Cavender <annacc@chromium.org>
284
285 Makes [Reflect] work for constants.
286 This is needed to avoid platform-specific define conflicts, specifically
287 TextTrack::ERROR conflicts with a windows define.
288 https://bugs.webkit.org/show_bug.cgi?id=70951
289
290 Reviewed by Darin Adler.
291
292 Test: media/track/track-constants.html
293
294 * bindings/scripts/CodeGenerator.pm:
295 (GenerateCompileTimeCheckForEnumsIfNeeded):
296 Check for [Reflect] and assign name accordingly.
297
298 * bindings/scripts/test/CPP/WebDOMTestObj.h: Update test file.
299 * bindings/scripts/test/JS/JSTestObj.cpp: Update test file.
300 (WebCore::jsTestObjCONST_JAVASCRIPT):
301 * bindings/scripts/test/JS/JSTestObj.h: Update test file.
302 * bindings/scripts/test/ObjC/DOMTestObj.h: Update test file.
303 * bindings/scripts/test/TestObj.idl: Update test file.
304 * bindings/scripts/test/V8/V8TestObj.cpp: Update test file.
305
306 * html/LoadableTextTrack.cpp: Use new DOM const name.
307 (WebCore::LoadableTextTrack::cueLoadingStarted):
308 (WebCore::LoadableTextTrack::cueLoadingCompleted):
309 * html/TextTrack.cpp: Use new DOM const name.
310 (WebCore::TextTrack::TextTrack):
311 (WebCore::TextTrack::setMode):
312 * html/TextTrack.h: Use new DOM const name.
313 * html/TextTrack.idl: Use Reflect for ERROR, but leave other DOM const names.
314
315 2011-11-01 Levi Weintraub <leviw@chromium.org>
316
317 Amend missing uses of LayoutUnit in RenderBlock
318 https://bugs.webkit.org/show_bug.cgi?id=71254
319
320 Reviewed by Darin Adler.
321
322 Switching relevant uses of integers in RenderBlock to LayoutUnits.
323
324 No new tests -- no changes in behavior.
325
326 * rendering/RenderBlock.cpp:
327 (WebCore::RenderBlock::MarginInfo::MarginInfo):
328 (WebCore::RenderBlock::layoutBlock):
329 (WebCore::RenderBlock::adjustFloatingBlock):
330 (WebCore::RenderBlock::clearFloatsIfNeeded):
331 (WebCore::RenderBlock::layoutBlockChild):
332 (WebCore::RenderBlock::paintColumnRules):
333 (WebCore::RenderBlock::paintContents):
334 (WebCore::clipOutPositionedObjects):
335 (WebCore::RenderBlock::removeFloatingObject):
336 (WebCore::RenderBlock::nextFloatLogicalBottomBelow):
337 (WebCore::RenderBlock::getClearDelta):
338 (WebCore::positionForPointRespectingEditingBoundaries):
339 (WebCore::RenderBlock::calcColumnWidth):
340 (WebCore::RenderBlock::layoutColumns):
341 (WebCore::RenderBlock::adjustRectForColumns):
342 (WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
343 (WebCore::RenderBlock::baselinePosition):
344 (WebCore::getHeightForLineCount):
345 (WebCore::RenderBlock::setPaginationStrut):
346 (WebCore::RenderBlock::applyBeforeBreak):
347 (WebCore::RenderBlock::applyAfterBreak):
348 (WebCore::RenderBlock::adjustForUnsplittableChild):
349 * rendering/RenderBlock.h:
350 (WebCore::RenderBlock::availableLogicalWidthForLine):
351 (WebCore::RenderBlock::paginationStrut):
352 (WebCore::RenderBlock::availableLogicalWidthForContent):
353 (WebCore::RenderBlock::FloatWithRect::FloatWithRect):
354 (WebCore::RenderBlock::MarginInfo::setPositiveMargin):
355 (WebCore::RenderBlock::MarginInfo::setNegativeMargin):
356 (WebCore::RenderBlock::MarginInfo::setPositiveMarginIfLarger):
357 (WebCore::RenderBlock::MarginInfo::setNegativeMarginIfLarger):
358 (WebCore::RenderBlock::MarginInfo::setMargin):
359 (WebCore::RenderBlock::FloatIntervalSearchAdapter::FloatIntervalSearchAd apter):
360 (WebCore::RenderBlock::FloatIntervalSearchAdapter::lowValue):
361 (WebCore::RenderBlock::FloatIntervalSearchAdapter::highValue):
362 (WebCore::RenderBlock::RenderBlockRareData::positiveMarginBeforeDefault) :
363 (WebCore::RenderBlock::RenderBlockRareData::negativeMarginBeforeDefault) :
364 (WebCore::RenderBlock::RenderBlockRareData::positiveMarginAfterDefault):
365 (WebCore::RenderBlock::RenderBlockRareData::negativeMarginAfterDefault):
366
367 2011-11-01 Luke Macpherson <macpherson@chromium.org>
368
369 WIP: Add CSS property to control printing of backgrounds for individual elements.
370 https://bugs.webkit.org/show_bug.cgi?id=64583
371
372 Reviewed by Eric Seidel.
373
374 Added test LayoutTests/fast/css/webkit-color-adjust.html,
375 Updated tests under LayoutTests/fast/css/getComputedStyle
376 Updated test under LayoutTests/svg/css
377
378 * css/CSSComputedStyleDeclaration.cpp:
379 (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
380 * css/CSSParser.cpp:
381 (WebCore::CSSParser::parseValue):
382 * css/CSSPropertyNames.in:
383 * css/CSSStyleSelector.cpp:
384 (WebCore::CSSStyleSelector::styleForDocument):
385 (WebCore::CSSStyleSelector::applyProperty):
386 * rendering/RenderBoxModelObject.cpp:
387 (WebCore::RenderBoxModelObject::paintFillLayerExtended):
388 * rendering/style/RenderStyle.h:
389 (WebCore::InheritedFlags::initialForceBackgroundsToWhite):
390
391 2011-11-01 Dominic Cooney <dominicc@chromium.org>
392
393 Remove initErrorEvent method
394 https://bugs.webkit.org/show_bug.cgi?id=71338
395
396 Reviewed by Ojan Vafai.
397
398 * dom/ErrorEvent.cpp: Crush.
399 * dom/ErrorEvent.h: Kill.
400 * dom/ErrorEvent.idl: Destroy.
401
402 2011-11-01 Julien Chaffraix <jchaffraix@webkit.org>
403
404 Pack RenderTableCell bits
405 https://bugs.webkit.org/show_bug.cgi?id=71135
406
407 Reviewed by Darin Adler.
408
409 Tested by RenderTableCellTest unit test.
410 (unfortunately Chromium specific...)
411
412 This saves another 8 bytes on RenderTableCell on x86-64.
413
414 * rendering/RenderTableCell.cpp:
415 (WebCore::RenderTableCell::RenderTableCell):
416 * rendering/RenderTableCell.h:
417 Changed the field order to use more strict packing.
418
419 (WebCore::RenderTableCell::setCol):
420 (WebCore::RenderTableCell::setRow):
421 Added overflow checks to the 2 previous methods. We
422 CRASH even in release to avoid potential badness
423 (the limit is currently above 2 billions rows or columns
424 which is high enough to prevent it being hit by accident)
425
426 2011-11-01 Emil A Eklund <eae@chromium.org>
427
428 Switch background/border image back to Int
429 https://bugs.webkit.org/show_bug.cgi?id=71240
430
431 Reviewed by Darin Adler.
432
433 Switch background- and border-image rendering back to int to align with
434 device pixels.
435
436 No new tests.
437
438 * rendering/RenderBoxModelObject.cpp:
439 (WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions):
440 (WebCore::RenderBoxModelObject::calculateFillTileSize):
441 (WebCore::RenderBoxModelObject::BackgroundImageGeometry::useFixedAttachm ent):
442 (WebCore::RenderBoxModelObject::BackgroundImageGeometry::clip):
443 (WebCore::RenderBoxModelObject::BackgroundImageGeometry::relativePhase):
444 (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
445 (WebCore::RenderBoxModelObject::paintNinePieceImage):
446 (WebCore::calculateAdjustedInnerBorder):
447 * rendering/RenderBoxModelObject.h:
448 (WebCore::RenderBoxModelObject::BackgroundImageGeometry::destOrigin):
449 (WebCore::RenderBoxModelObject::BackgroundImageGeometry::setDestOrigin):
450 (WebCore::RenderBoxModelObject::BackgroundImageGeometry::destRect):
451 (WebCore::RenderBoxModelObject::BackgroundImageGeometry::setDestRect):
452 (WebCore::RenderBoxModelObject::BackgroundImageGeometry::phase):
453 (WebCore::RenderBoxModelObject::BackgroundImageGeometry::setPhase):
454 (WebCore::RenderBoxModelObject::BackgroundImageGeometry::tileSize):
455 (WebCore::RenderBoxModelObject::BackgroundImageGeometry::setTileSize):
456
457 2011-11-01 Mark Hahnenberg <mhahnenberg@apple.com>
458
459 De-virtualize JSObject::defineSetter
460 https://bugs.webkit.org/show_bug.cgi?id=71303
461
462 Reviewed by Darin Adler.
463
464 No new tests.
465
466 Added defineSetter to the MethodTable, changed all the virtual
467 implementations of defineSetter to static ones, and replaced
468 all call sites with corresponding lookups in the MethodTable.
469
470 * bindings/js/JSDOMWindowCustom.cpp:
471 (WebCore::JSDOMWindow::defineSetter):
472 * bindings/js/JSDOMWindowShell.cpp:
473 (WebCore::JSDOMWindowShell::defineSetter):
474 * bindings/js/JSDOMWindowShell.h:
475 * bindings/scripts/CodeGeneratorJS.pm:
476 (GenerateHeader):
477
478 2011-11-01 Emil A Eklund <eae@chromium.org>
479
480 Switch PopupMenuClient to layout abstraction
481 https://bugs.webkit.org/show_bug.cgi?id=71308
482
483 Reviewed by Darin Adler.
484
485 Switch PopupMenuClient and rendering classes implementing it to layout
486 type abstraction.
487
488 No new tests.
489
490 * platform/PopupMenuClient.h:
491 * rendering/RenderListBox.cpp:
492 (WebCore::RenderListBox::listIndexAtOffset):
493 (WebCore::RenderListBox::panScroll):
494 (WebCore::RenderListBox::scrollToward):
495 (WebCore::RenderListBox::scrollSize):
496 (WebCore::RenderListBox::scrollPosition):
497 (WebCore::RenderListBox::setScrollOffset):
498 (WebCore::RenderListBox::verticalScrollbarWidth):
499 Revert scroll positions and scroll offsets to ints to align with device
500 pixels.
501
502 * rendering/RenderListBox.h:
503 * rendering/RenderMenuList.cpp:
504 (WebCore::RenderMenuList::showPopup):
505 (WebCore::RenderMenuList::clientPaddingLeft):
506 (WebCore::RenderMenuList::clientPaddingRight):
507 * rendering/RenderMenuList.h:
508 * rendering/RenderTextControl.cpp:
509 (WebCore::RenderTextControl::hitInnerTextElement):
510 * rendering/RenderTextControlSingleLine.cpp:
511 (WebCore::RenderTextControlSingleLine::clientPaddingLeft):
512 (WebCore::RenderTextControlSingleLine::clientPaddingRight):
513 * rendering/RenderTextControlSingleLine.h:
514
515 2011-11-01 Nate Chapin <japhet@chromium.org>
516
517 [chromium] As of r98380, ThreadableLoaderClients are having their
518 ResourceRequest::TargetType clobbered. They set their own
519 type, but CachedResourceRequest (through which they now flow)
520 sets a TargetType without bothering to see if one has already been set.
521 https://bugs.webkit.org/show_bug.cgi?id=70972
522
523 Reviewed by Darin Fisher.
524
525 No new tests, this is chromium-specific and only affects
526 behavior seen in full builds of chromium.
527
528 * loader/cache/CachedResourceRequest.cpp:
529 (WebCore::CachedResourceRequest::load):Don't setTargetType()
530 if the value is something other than the default already.
531 * platform/network/chromium/ResourceRequest.h: Change default
532 TargetType to TargetIsUnspecified.
533
534 2011-11-01 Emil A Eklund <eae@chromium.org>
535
536 Use IntPoint for screen coordinates in MouseEvent
537 https://bugs.webkit.org/show_bug.cgi?id=71327
538
539 Reviewed by Darin Adler.
540
541 Change mouse events to use int/IntPoint for screen/window coordinates an d
542 LayoutUnit/LayoutPoint for coordinates adjusted for zooming.
543
544 No new tests.
545
546 * dom/MouseRelatedEvent.cpp:
547 (WebCore::MouseRelatedEvent::MouseRelatedEvent):
548 (WebCore::MouseRelatedEvent::computeRelativePosition):
549 * dom/MouseRelatedEvent.h:
550 (WebCore::MouseRelatedEvent::screenLocation):
551 Revert screenLocation and windowLocation back to int.
552
553 * page/DragController.cpp:
554 (WebCore::elementUnderMouse):
555 Change elementUnderMouse to use a LayoutPoint for hit testing.
556
557 * page/EventHandler.cpp:
558 (WebCore::EventHandler::clear):
559 (WebCore::EventHandler::currentMousePosition):
560 (WebCore::documentPointForWindowPoint):
561 (WebCore::EventHandler::fakeMouseMoveEventTimerFired):
562 * page/EventHandler.h:
563 Revert m_currentMousePosition to IntPoint as it represents a
564 screen coordinate.
565
566 * platform/PlatformMouseEvent.h:
567 (WebCore::PlatformMouseEvent::PlatformMouseEvent):
568 (WebCore::PlatformMouseEvent::pos):
569 (WebCore::PlatformMouseEvent::x):
570 (WebCore::PlatformMouseEvent::y):
571 (WebCore::PlatformMouseEvent::globalX):
572 (WebCore::PlatformMouseEvent::globalY):
573 * platform/mac/PlatformMouseEventMac.mm:
574 (WebCore::globalPoint):
575 (WebCore::pointForEvent):
576 (WebCore::globalPointForEvent):
577 Revert PlatformMouseEvent to int/IntPoint as it represents a screen
578 coordinate.
579
580 2011-11-01 Tony Chang <tony@chromium.org>
581
582 REGRESSION: -webkit-flex() should be an invalid value
583 https://bugs.webkit.org/show_bug.cgi?id=71320
584
585 Reviewed by Ojan Vafai.
586
587 This regressed in http://trac.webkit.org/changeset/98773 .
588
589 No new tests, covered by css3/flexbox/flex-parsing.html.
590
591 * css/CSSParser.cpp:
592 (WebCore::CSSParser::parseFlex):
593
594 2011-11-01 David Grogan <dgrogan@chromium.org>
595
596 IndexedDB: get EventQueue from ScriptExecutionContext instead of Documen t
597 https://bugs.webkit.org/show_bug.cgi?id=71147
598
599 When IDB is used from a worker thread ScriptExecutionContext will
600 be a WorkerContext, not a Document. This was the impetus behind
601 moving EventQueue into ScriptExecutionContext in r98656.
602
603 Reviewed by Nate Chapin.
604
605 No new tests. No new functionality yet.
606
607 * storage/IDBDatabase.cpp:
608 (WebCore::IDBDatabase::close):
609 (WebCore::IDBDatabase::enqueueEvent):
610 * storage/IDBRequest.cpp:
611 (WebCore::IDBRequest::abort):
612 (WebCore::IDBRequest::enqueueEvent):
613 * storage/IDBTransaction.cpp:
614 (WebCore::IDBTransaction::enqueueEvent):
615
616 2011-11-01 Andreas Kling <kling@webkit.org>
617
618 CSS: Remove unused virtual parseString() in style and keyframe rules.
619 https://bugs.webkit.org/show_bug.cgi?id=71300
620
621 Reviewed by Darin Adler.
622
623 * css/CSSStyleRule.cpp:
624 * css/CSSStyleRule.h:
625 * css/WebKitCSSKeyframeRule.cpp:
626 * css/WebKitCSSKeyframeRule.h:
627
628 2011-11-01 Emil A Eklund <eae@chromium.org>
629
630 Switch RenderObject to layout abstraction
631 https://bugs.webkit.org/show_bug.cgi?id=71249
632
633 Switch RenderObject to LayoutRect/Size/Point abstraction.
634
635 Reviewed by Darin Adler.
636
637 No new tests.
638
639 * rendering/RenderObject.cpp:
640 (WebCore::RenderObject::drawLineForBoxSide):
641 (WebCore::RenderObject::addPDFURLRect):
642 (WebCore::RenderObject::absoluteBoundingBoxRect):
643 (WebCore::RenderObject::absoluteFocusRingQuads):
644 (WebCore::RenderObject::addAbsoluteRectForLayer):
645 (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
646 (WebCore::RenderObject::computeRectForRepaint):
647 (WebCore::RenderObject::viewRect):
648 (WebCore::RenderObject::mapLocalToContainer):
649 (WebCore::RenderObject::localCaretRect):
650 (WebCore::RenderObject::addDashboardRegions):
651 (WebCore::RenderObject::maximalOutlineSize):
652 (WebCore::RenderObject::adjustRectForOutlineAndShadow):
653 * rendering/RenderObject.h:
654 (WebCore::RenderObject::absoluteBoundingBoxRectIgnoringTransforms):
655 (WebCore::RenderObject::absoluteClippedOverflowRect):
656 (WebCore::RenderObject::computeAbsoluteRepaintRect):
657 (WebCore::RenderObject::absoluteOutlineBounds):
658 (WebCore::RenderObject::outlineBoundsForRepaint):
659 (WebCore::adjustForAbsoluteZoom):
660
661 2011-11-01 Xiaomei Ji <xji@chromium.org>
662
663 Refactor: change Scrollable::m_scrollOrigin from protected to private.
664 https://bugs.webkit.org/show_bug.cgi?id=71236
665
666 Reviewed by Darin Adler.
667
668 Only refactor, no new tests needed.
669
670 * page/FrameView.cpp:
671 (WebCore::FrameView::scrollXForFixedPosition):
672 (WebCore::FrameView::scrollYForFixedPosition):
673 * platform/ScrollView.cpp:
674 (WebCore::ScrollView::maximumScrollPosition):
675 (WebCore::ScrollView::minimumScrollPosition):
676 (WebCore::ScrollView::setScrollOffset):
677 (WebCore::ScrollView::scrollPosition):
678 (WebCore::ScrollView::overhangAmount):
679 (WebCore::ScrollView::updateScrollbars):
680 (WebCore::ScrollView::wheelEvent):
681 * platform/ScrollView.h:
682 * platform/ScrollableArea.h:
683 (WebCore::ScrollableArea::setScrollOrigin):
684 (WebCore::ScrollableArea::setScrollOriginX):
685 (WebCore::ScrollableArea::setScrollOriginY):
686 * rendering/RenderLayer.cpp:
687 (WebCore::RenderLayer::scrollTo):
688 (WebCore::RenderLayer::scrollPosition):
689 (WebCore::RenderLayer::minimumScrollPosition):
690 (WebCore::RenderLayer::maximumScrollPosition):
691 (WebCore::RenderLayer::computeScrollDimensions):
692 * rendering/RenderLayer.h:
693 (WebCore::RenderLayer::scrollXOffset):
694 (WebCore::RenderLayer::scrollYOffset):
695
696 2011-11-01 Dominic Cooney <dominicc@chromium.org>
697
698 display: table-cell and box-sizing: border-box calculates content-box he ight
699 https://bugs.webkit.org/show_bug.cgi?id=69425
700
701 Reviewed by Dan Bernstein.
702
703 Test: fast/box-sizing/table-cell.html
704
705 * rendering/RenderTableSection.cpp:
706 (WebCore::RenderTableSection::calcRowLogicalHeight):
707
708 2011-11-01 Alok Priyadarshi <alokp@chromium.org>
709
710 [chromium] Add testing for --enable-accelerated-drawing
711 https://bugs.webkit.org/show_bug.cgi?id=70822
712
713 Reviewed by James Robinson.
714
715 Test: platform/chromium/compositing/accelerated-drawing/alpha.html
716
717 * WebCore.exp.in:
718 * page/Settings.cpp:
719 * page/Settings.h:
720 (WebCore::Settings::setAcceleratedDrawingEnabled):
721 * testing/Internals.cpp:
722 (WebCore::Internals::setAcceleratedDrawingEnabled):
723 * testing/Internals.h:
724 * testing/Internals.idl:
725
726 2011-11-01 Tim Horton <timothy_horton@apple.com>
727
728 SVG Filter on a group doesn't invalidate when children are moved
729 https://bugs.webkit.org/show_bug.cgi?id=70044
730 <rdar://problem/10281530>
731
732 Reviewed by Nikolas Zimmermann.
733
734 Call SVGResourcesCache::clientLayoutChanged whenever the element or its children need layout. Previously,
735 invalidation was only performed if the element itself needed layout; now we also invalidate if any child
736 needs layout and there is a filter applied, as the cached filter result can depend on the layout of children.
737
738 Test: svg/filters/invalidate-on-child-layout.svg
739
740 * rendering/svg/RenderSVGContainer.cpp:
741 (WebCore::RenderSVGContainer::layout):
742 * rendering/svg/SVGResourcesCache.cpp:
743 (WebCore::SVGResourcesCache::clientLayoutChanged):
744
745 2011-11-01 Jer Noble <jer.noble@apple.com>
746
747 Four media tests failing on Lion due to incorrect cached times.
748 https://bugs.webkit.org/show_bug.cgi?id=69574
749
750 Reviewed by Eric Carlson.
751
752 Do not invalidate the cached time when receiving a mediaPlayerRateChange d notification
753 while paused. AVFoundation in particular can return different results fo r currentTime()
754 when asked after being paused, breaking layout tests.
755
756 * html/HTMLMediaElement.cpp:
757 (WebCore::HTMLMediaElement::mediaPlayerRateChanged):
758
759 2011-11-01 Gavin Peters <gavinp@chromium.org>
760
761 properly end requests when a bad status code return happens
762 https://bugs.webkit.org/show_bug.cgi?id=71122
763
764 Calling error without ending the request set up the CachedResourceReques t so that it could
765 actually send out two notifyFinished() events. This probably was the ro ot cause of
766 lots of crashing instability; I know from crbug.com/75604 that this bug was causing lots
767 of crashes in ScriptRunner/ScriptElement for instance.
768
769 The fix is easy: just properly end the request instead of just calling e rror, and we won't
770 re-notify.
771
772 Reviewed by Nate Chapin.
773
774 No new tests, as the problem wasn't very amenable to layout tests.
775 There is a chromium test going through code review at http://codereview. chromium.org/8404001/
776
777 * loader/cache/CachedResourceRequest.cpp:
778 (WebCore::CachedResourceRequest::didReceiveData):
779
780 2011-11-01 Erik Arvidsson <arv@chromium.org>
781
782 Remove LegacyDefaultOptionalArguments flag from CanvasRenderingContext2d
783 https://bugs.webkit.org/show_bug.cgi?id=64628
784
785 Reviewed by Adam Barth.
786
787 Covered by existing tests.
788
789 * html/canvas/CanvasRenderingContext2D.idl:
790
791 2011-11-01 Julien Chaffraix <jchaffraix@webkit.org>
792
793 REGRESSION(98738): RenderTableSection::recalcCells does not properly shr ink the RowStruct grid
794 https://bugs.webkit.org/show_bug.cgi?id=71246
795
796 Reviewed by Darin Adler.
797
798 Tests: fast/table/crash-empty-section-calcBorder.html
799 fast/table/crash-empty-section-fixed-layout-calcArray.html
800
801 The refactoring in r98738 changed the way we handle the size to avoid th rowing off
802 the memory. The new logic would end up never shrinking the grid's size ( prior to that
803 we would grow to the appropriate size and throw the excess capacity with shrinkToFit).
804 Not shrinking would mean that we would potentially read RowStruct with t he default values
805 (for instance no |rowRenderer|).
806
807 addCell will properly grow the grid as needed to accomodate the rows and the protruding
808 cells with a rowspan so we introduce a variable to keep track of the siz e needed. At the
809 end, we just shrink it to this size.
810
811 * rendering/RenderTableSection.cpp:
812 (WebCore::RenderTableSection::recalcCells):
813 Introduce a variable to keep the grid size and shrink to that size to ma tch the old code.
814
815 2011-11-01 Andrey Kosyakov <caseq@chromium.org>
816
817 [Chromium] Some media/video-*.html layout tests occasionally crash on WI N GPU
818 https://bugs.webkit.org/show_bug.cgi?id=71277
819
820 Reviewed by Simon Fraser.
821
822 Disabled assert() in hasVisibleDescendant() until callers are fixed.
823
824 * rendering/RenderLayer.h:
825 (WebCore::RenderLayer::hasVisibleDescendant):
826
827 2011-11-01 Mike Reed <reed@google.com>
828
829 [skia] call readPixels on canvas instead of device (will be private on d evice soon) and check for error
830 https://bugs.webkit.org/show_bug.cgi?id=71284
831
832 Reviewed by Stephen White.
833
834 No new tests. This is preparing for an API change to Skia.
835
836 * platform/graphics/skia/ImageBufferSkia.cpp:
837 (WebCore::getImageData):
838 (WebCore::ImageBuffer::getUnmultipliedImageData):
839 (WebCore::ImageBuffer::getPremultipliedImageData):
840
841 2011-11-01 Andreas Kling <kling@webkit.org>
842
843 CSSStyleSheet: Operate directly on the rule vector internally.
844
845 Rubber-stamped by Antti Koivisto.
846
847 There's no need to go through the public, range-checking item() method
848 working on m_children. Also changed length() -> m_children.size().
849
850 * css/CSSStyleSheet.cpp:
851 (WebCore::CSSStyleSheet::~CSSStyleSheet):
852 (WebCore::CSSStyleSheet::insertRule):
853 (WebCore::CSSStyleSheet::addRule):
854 (WebCore::CSSStyleSheet::deleteRule):
855 (WebCore::CSSStyleSheet::isLoading):
856 (WebCore::CSSStyleSheet::addSubresourceStyleURLs):
857
858 2011-11-01 Andreas Kling <kling@webkit.org>
859
860 CSSRule: Devirtualize addSubresourceStyleURLs()
861 https://bugs.webkit.org/show_bug.cgi?id=71285
862
863 Reviewed by Antti Koivisto.
864
865 Move addSubresourceStyleURLs() into the rules that actually implement it .
866 Add type checks and casts at the (only) call site.
867
868 * css/CSSFontFaceRule.h:
869 * css/CSSImportRule.h:
870 * css/CSSRule.h:
871 * css/CSSStyleRule.h:
872 * css/CSSStyleSheet.cpp:
873 (WebCore::CSSStyleSheet::addSubresourceStyleURLs):
874
875 2011-11-01 Chris Fleizach <cfleizach@apple.com>
876
877 AX: some popup buttons not announced by VoiceOver
878 https://bugs.webkit.org/show_bug.cgi?id=67743
879
880 Reviewed by Darin Adler.
881
882 Test: platform/mac/accessibility/aria-popup-buttons-on-native-elements.h tml
883
884 * accessibility/AccessibilityRenderObject.cpp:
885 (WebCore::AccessibilityRenderObject::stringValue):
886 (WebCore::AccessibilityRenderObject::title):
887 (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
888
889 2011-11-01 Alexander Pavlov <apavlov@chromium.org>
890
891 Web Inspector: [Styles] Style-based CSS properties are editable and togg leable
892 https://bugs.webkit.org/show_bug.cgi?id=71275
893
894 Reviewed by Pavel Feldman.
895
896 * inspector/front-end/StylesSidebarPane.js:
897 (WebInspector.StylePropertiesSection.prototype.onpopulate):
898
899 2011-11-01 Pavel Feldman <pfeldman@google.com>
900
901 Web Inspector: do not switch panels on Cmd + -> while in console.
902 https://bugs.webkit.org/show_bug.cgi?id=71281
903
904 Reviewed by Yury Semikhatsky.
905
906 * inspector/front-end/InspectorView.js:
907 (WebInspector.InspectorView.prototype._keyDown):
908
909 2011-11-01 Zeno Albisser <zeno.albisser@nokia.com>
910
911 [Qt] bad codegen, pointer diff in JSC::JSCallbackConstructor::JSCallback Constructor
912 https://bugs.webkit.org/show_bug.cgi?id=60951
913
914 Adjust symbols visibility for WebCore.
915
916 Reviewed by Simon Hausmann.
917
918 * WebCore.pro:
919
920 2011-11-01 Pavel Feldman <pfeldman@google.com>
921
922 Not reviewed: add InspectorView.js entry into WebKit.qrc
923
924 * inspector/front-end/WebKit.qrc:
925
926 2011-11-01 Pavel Feldman <pfeldman@google.com>
927
928
929 Web Inspector: introduce PanelContainer class, start moving panel manage ment from inspector.js to the new class.
930 https://bugs.webkit.org/show_bug.cgi?id=71272
931
932 Reviewed by Yury Semikhatsky.
933
934 * WebCore.gypi:
935 * WebCore.vcproj/WebCore.vcproj:
936 * inspector/compile-front-end.sh:
937 * inspector/front-end/Drawer.js:
938 (WebInspector.Drawer.prototype.show.animationFinished):
939 (WebInspector.Drawer.prototype.show):
940 (WebInspector.Drawer.prototype.hide):
941 (WebInspector.Drawer.prototype._statusBarDragging):
942 * inspector/front-end/ElementsPanel.js:
943 (WebInspector.ElementsPanel.prototype.switchToAndFocus):
944 (WebInspector.ElementsPanel.prototype.revealAndSelectNode):
945 * inspector/front-end/ElementsTreeOutline.js:
946 (WebInspector.ElementsTreeOutline.prototype.setVisible):
947 * inspector/front-end/InspectorView.js: Added.
948 (WebInspector.InspectorView):
949 (WebInspector.InspectorView.prototype.addPanel):
950 (WebInspector.InspectorView.prototype.currentPanel):
951 (WebInspector.InspectorView.prototype._keyDown):
952 (WebInspector.InspectorView.prototype._canGoBackInHistory):
953 (WebInspector.InspectorView.prototype._goBackInHistory):
954 (WebInspector.InspectorView.prototype._canGoForwardInHistory):
955 (WebInspector.InspectorView.prototype._goForwardInHistory):
956 (WebInspector.InspectorView.prototype._pushToHistory):
957 * inspector/front-end/KeyboardShortcut.js:
958 (WebInspector.KeyboardShortcut.eventHasCtrlOrMeta):
959 * inspector/front-end/Panel.js:
960 (WebInspector.Panel.prototype.show):
961 * inspector/front-end/ScriptsPanel.js:
962 (WebInspector.ScriptsPanel.prototype._toggleBreakpointsClicked):
963 * inspector/front-end/SearchController.js:
964 (WebInspector.SearchController.prototype.updateSearchMatchesCount):
965 (WebInspector.SearchController.prototype.updateCurrentMatchIndex):
966 (WebInspector.SearchController.prototype.updateSearchLabel):
967 (WebInspector.SearchController.prototype.handleShortcut):
968 (WebInspector.SearchController.prototype._performSearch):
969 * inspector/front-end/Toolbar.js:
970 (WebInspector.Toolbar.createPanelToolbarItem.onToolbarItemClicked):
971 (WebInspector.Toolbar.createPanelToolbarItem):
972 * inspector/front-end/WebKit.qrc:
973 * inspector/front-end/externs.js:
974 * inspector/front-end/inspector.html:
975 * inspector/front-end/inspector.js:
976 (WebInspector._createPanels):
977 (WebInspector._panelSelected):
978 (WebInspector.addPanel):
979 (WebInspector.windowResize):
980 (WebInspector.documentKeyDown):
981 (WebInspector.documentCanCopy):
982 (WebInspector.documentCopy):
983 (WebInspector.showPanel):
984 (WebInspector.startUserInitiatedDebugging):
985 (WebInspector.inspect):
986 (WebInspector._showAnchorLocationInPanel):
987 (WebInspector._toolbarItemClicked):
988 * inspector/front-end/treeoutline.js:
989 (TreeElement.prototype.select):
990
991 2011-11-01 Simon Hausmann <simon.hausmann@nokia.com>
992
993 [WK2] Add WebGestureEvents to the Qt build and enable PlatformGestureEve nt::TapType
994 https://bugs.webkit.org/show_bug.cgi?id=71274
995
996 Reviewed by Kenneth Christiansen.
997
998 * features.pri: Enable GESTURE_EVENTS.
999
1000 2011-11-01 Sheriff Bot <webkit.review.bot@gmail.com>
1001
1002 Unreviewed, rolling out r98847.
1003 http://trac.webkit.org/changeset/98847
1004 https://bugs.webkit.org/show_bug.cgi?id=71268
1005
1006 "Debugger test failures on multiple platforms" (Requested by
1007 yurys on #webkit).
1008
1009 * inspector/front-end/DebuggerPresentationModel.js:
1010 (WebInspector.DebuggerPresentationModel):
1011 (WebInspector.DebuggerPresentationModel.prototype._addScript):
1012 (WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
1013 (WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
1014 (WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
1015 (WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScrip tWithURL):
1016 (WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScrip t):
1017 (WebInspector.DebuggerPresentationModel.prototype._scriptForRawSourceCod e):
1018 (WebInspector.DebuggerPresentationModel.prototype._createRawSourceCodeId ):
1019 (WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
1020 (WebInspector.DebuggerPresentationModel.Linkifier.prototype.reset):
1021 * inspector/front-end/RawSourceCode.js:
1022 (WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestCon tent.didFormatContent):
1023 (WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestCon tent):
1024 (WebInspector.RawSourceCode.prototype._createSourceMapping):
1025 * inspector/front-end/Script.js:
1026 (WebInspector.Script.prototype.editSource):
1027
1028 2011-10-30 Filip Pizlo <fpizlo@apple.com>
1029
1030 The GC should be parallel
1031 https://bugs.webkit.org/show_bug.cgi?id=70995
1032
1033 Reviewed by Geoff Garen.
1034
1035 Added parallel tracing to the GC. This required loosening some assertion s,
1036 since some code may now be called from outside the main thread.
1037
1038 No new tests, since no behavior was changed.
1039
1040 * platform/TreeShared.h:
1041 (WebCore::TreeShared::parent):
1042
1043 2011-10-31 Andy Estes <aestes@apple.com>
1044
1045 Document pointer not null-checked in FrameView::isOnActivePage()
1046 https://bugs.webkit.org/show_bug.cgi?id=71265
1047 <rdar://problem/10374427>
1048
1049 Reviewed by Dan Bernstein.
1050
1051 Return false in FrameView::isOnActivePage() if m_frame->document() is
1052 null. Other calls to m_frame->document() in FrameView also have a null
1053 check. The frame can have a null document if the FrameLoader is loading
1054 the initial empty document.
1055
1056 No test possible without triggering assertions in debug builds. This is
1057 tracked by <http://webkit.org/b/71264>.
1058
1059 * page/FrameView.cpp:
1060 (WebCore::FrameView::isOnActivePage):
1061
1062 2011-10-31 Jeremy Apthorp <jeremya@google.com>
1063
1064 Fix a crash relating to anonymous block merging in
1065 RenderFullScreen::unwrapRenderer.
1066 https://bugs.webkit.org/show_bug.cgi?id=70705
1067
1068 Reviewed by Simon Fraser.
1069
1070 Test: fullscreen/anonymous-block-merge-crash.html
1071
1072 * rendering/RenderFullScreen.cpp:
1073 (RenderFullScreen::unwrapRenderer):
1074
1075 2011-10-31 Dave Michael <dmichael@chromium.org>
1076
1077 V8MessageEvent::dataAccessorGetter does not return a reference to its ca ller
1078 https://bugs.webkit.org/show_bug.cgi?id=71229
1079
1080 Reviewed by Adam Barth.
1081
1082 Test: fast/events/dispatch-message-string-data.html
1083
1084 * bindings/v8/custom/V8MessageEventCustom.cpp:
1085 (WebCore::V8MessageEvent::dataAccessorGetter):
1086
1087 2011-10-31 Renata Hodovan <reni@webkit.org>
1088
1089 [Qt] Build fix after r98853.
1090
1091 Rubber-stamped by Andreas Kling.
1092
1093 * xml/XSLImportRule.cpp:
1094 * xml/XSLImportRule.h:
1095 (WebCore::XSLImportRule::parentStyleSheet):
1096
1097 2011-10-31 Mark Hahnenberg <mhahnenberg@apple.com>
1098
1099 De-virtualize JSObject::defaultValue
1100 https://bugs.webkit.org/show_bug.cgi?id=71146
1101
1102 Reviewed by Sam Weinig.
1103
1104 No new tests.
1105
1106 Added defaultValue to the MethodTable. Replaced all virtual versions of
1107 defaultValue with static versions. Replaced all call sites with lookups in the
1108 MethodTable.
1109
1110 * WebCore.exp.in:
1111 * bridge/objc/objc_runtime.h:
1112 * bridge/objc/objc_runtime.mm:
1113 (JSC::Bindings::ObjcFallbackObjectImp::defaultValue):
1114 * bridge/runtime_object.cpp:
1115 (JSC::Bindings::RuntimeObject::defaultValue):
1116 * bridge/runtime_object.h:
1117
1118 2011-10-31 Levi Weintraub <leviw@chromium.org>
1119
1120 Switch RoundedRect back to integers
1121 https://bugs.webkit.org/show_bug.cgi?id=71238
1122
1123 Reviewed by Darin Adler.
1124
1125 Changing RoundedRect back to ints from LayoutUnits. As further testing h as shown, this graphics-
1126 focused class should maintain values aligned to pixel boundaries, and th erefor kept as integers.
1127
1128 No new tests -- no change in behavior.
1129
1130 * platform/graphics/RoundedRect.cpp:
1131 (WebCore::RoundedRect::Radii::scale):
1132 (WebCore::RoundedRect::Radii::expand):
1133 (WebCore::RoundedRect::inflateWithRadii):
1134 (WebCore::RoundedRect::Radii::excludeLogicalEdges):
1135 (WebCore::RoundedRect::RoundedRect):
1136 * platform/graphics/RoundedRect.h:
1137 (WebCore::RoundedRect::Radii::Radii):
1138 (WebCore::RoundedRect::Radii::setTopLeft):
1139 (WebCore::RoundedRect::Radii::setTopRight):
1140 (WebCore::RoundedRect::Radii::setBottomLeft):
1141 (WebCore::RoundedRect::Radii::setBottomRight):
1142 (WebCore::RoundedRect::Radii::topLeft):
1143 (WebCore::RoundedRect::Radii::topRight):
1144 (WebCore::RoundedRect::Radii::bottomLeft):
1145 (WebCore::RoundedRect::Radii::bottomRight):
1146 (WebCore::RoundedRect::Radii::expand):
1147 (WebCore::RoundedRect::Radii::shrink):
1148 (WebCore::RoundedRect::rect):
1149 (WebCore::RoundedRect::setRect):
1150 (WebCore::RoundedRect::move):
1151 (WebCore::RoundedRect::inflate):
1152 (WebCore::RoundedRect::expandRadii):
1153 (WebCore::RoundedRect::shrinkRadii):
1154 * rendering/svg/SVGRenderSupport.h: Adding missing LayoutTypes.h include
1155
1156 2011-10-31 Peter Kasting <pkasting@google.com>
1157
1158 https://bugs.webkit.org/show_bug.cgi?id=70666
1159 BitmapImage::dataChanged() needs to clear all incomplete frames.
1160
1161 Reviewed by James Robinson.
1162
1163 No tests, as I don't know of a way to send an image to the renderer in
1164 small pieces (with script run between pieces no less).
1165
1166 * platform/graphics/BitmapImage.cpp:
1167 (WebCore::BitmapImage::dataChanged):
1168
1169 2011-10-31 Levi Weintraub <leviw@chromium.org>
1170
1171 Amend missing uses of LayoutUnits in RenderApplet, Button, and Deprecate dFlexibleBox
1172 https://bugs.webkit.org/show_bug.cgi?id=71243
1173
1174 Reviewed by Eric Seidel.
1175
1176 Replacing remaining integer uses with LayoutUnits in the aforementioned classes.
1177
1178 No new tests -- no change in behavior.
1179
1180 * rendering/RenderApplet.cpp:
1181 (WebCore::RenderApplet::intrinsicSize):
1182 (WebCore::RenderApplet::createWidgetIfNecessary):
1183 * rendering/RenderApplet.h:
1184 * rendering/RenderButton.cpp:
1185 (WebCore::RenderButton::controlClipRect):
1186 * rendering/RenderButton.h:
1187 * rendering/RenderDeprecatedFlexibleBox.cpp:
1188 (WebCore::marginWidthForChild):
1189 (WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths):
1190 (WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
1191 (WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
1192 (WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
1193 * rendering/RenderDeprecatedFlexibleBox.h:
1194
1195 2011-10-31 Tommy Widenflycht <tommyw@google.com>
1196
1197 [Chromium] Media Stream API: add the Chromium WebKit interfaces
1198 https://bugs.webkit.org/show_bug.cgi?id=58550
1199
1200 Changes the PeerHandler platform interface so that embedders can more ea sily use it.
1201
1202 Reviewed by Darin Fisher.
1203
1204 * GNUmakefile.am:
1205 * GNUmakefile.list.am:
1206 * WebCore.gyp/WebCore.gyp:
1207 * WebCore.gypi:
1208 * mediastream/PeerConnection.cpp:
1209 (WebCore::PeerConnection::PeerConnection):
1210 (WebCore::PeerConnection::didCompleteICEProcessing):
1211 (WebCore::PeerConnection::didGenerateSDP):
1212 (WebCore::PeerConnection::didReceiveDataStreamMessage):
1213 (WebCore::PeerConnection::didAddRemoteStream):
1214 (WebCore::PeerConnection::didRemoveRemoteStream):
1215 * mediastream/PeerConnection.h:
1216 * platform/mediastream/PeerConnectionHandlerClient.h: Copied from Source /WebCore/platform/mediastream/PeerHandler.cpp.
1217 (WebCore::PeerConnectionHandlerClient::~PeerConnectionHandlerClient):
1218 * platform/mediastream/chromium/PeerConnectionHandler.h: Copied from Sou rce/WebCore/platform/mediastream/PeerHandler.h.
1219 * platform/mediastream/gstreamer/PeerConnectionHandler.cpp: Copied from Source/WebCore/platform/mediastream/PeerHandler.cpp.
1220 (WebCore::PeerConnectionHandler::create):
1221 (WebCore::PeerConnectionHandler::PeerConnectionHandler):
1222 (WebCore::PeerConnectionHandler::~PeerConnectionHandler):
1223 (WebCore::PeerConnectionHandler::produceInitialOffer):
1224 (WebCore::PeerConnectionHandler::handleInitialOffer):
1225 (WebCore::PeerConnectionHandler::processSDP):
1226 (WebCore::PeerConnectionHandler::processPendingStreams):
1227 (WebCore::PeerConnectionHandler::sendDataStreamMessage):
1228 (WebCore::PeerConnectionHandler::stop):
1229 * platform/mediastream/gstreamer/PeerConnectionHandler.h: Renamed from S ource/WebCore/platform/mediastream/PeerHandler.h.
1230
1231 Tests for the Media Stream API will be provided by the bug 56587, pendin g enough landed code.
1232
1233 2011-10-31 Adam Roben <aroben@apple.com>
1234
1235 Fix linker warnings on Windows
1236
1237 * WebCore.vcproj/WebCore.vcproj: Exclude SpellingCorrectionCommand.cpp a nd
1238 JSRequestAnimationFrameCallback.cpp from all configurations. They are al ready getting
1239 compiled via *AllInOne.cpp files.
1240
1241 2011-10-31 Jonathon Jongsma <jonathon.jongsma@collabora.co.uk>
1242
1243 [GStreamer] Don't use GOwnPtr for ref-counted objects
1244 https://bugs.webkit.org/show_bug.cgi?id=71042
1245
1246 Reviewed by Martin Robinson.
1247
1248 * CMakeListsEfl.txt:
1249 * GNUmakefile.list.am:
1250 * WebCore.gypi:
1251 * WebCore.pro:
1252 * platform/graphics/gstreamer/GOwnPtrGStreamer.cpp: Removed.
1253 * platform/graphics/gstreamer/GOwnPtrGStreamer.h: Removed.
1254 * platform/graphics/gstreamer/GStreamerGWorld.cpp:
1255 (WebCore::GStreamerGWorld::enterFullscreen):
1256 (WebCore::GStreamerGWorld::exitFullscreen):
1257 * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
1258 (WebCore::MediaPlayerPrivateGStreamer::updateAudioSink):
1259 (WebCore::MediaPlayerPrivateGStreamer::sourceChanged):
1260
1261 2011-10-28 Nat Duca <nduca@chromium.org>
1262
1263 [chromium] Connect CCThreadProxy to FrameRateController and SchedulerSta teMachine via CCScheduler
1264 https://bugs.webkit.org/show_bug.cgi?id=71100
1265
1266 Reviewed by James Robinson.
1267
1268 * platform/graphics/chromium/cc/CCDelayBasedTimeSource.h:
1269 (WebCore::CCDelayBasedTimeSource::monotonicallyIncreasingTime):
1270 * platform/graphics/chromium/cc/CCLayerTreeHost.h:
1271 (WebCore::CCLayerTreeHostClient::didCommitAndDrawFrame):
1272 (WebCore::CCLayerTreeHost::didCommitAndDrawFrame):
1273 * platform/graphics/chromium/cc/CCScheduler.cpp:
1274 (WebCore::CCSchedulerFrameRateControllerClientAdapter::create):
1275 (WebCore::CCSchedulerFrameRateControllerClientAdapter::~CCSchedulerFrame RateControllerClientAdapter):
1276 (WebCore::CCSchedulerFrameRateControllerClientAdapter::beginFrame):
1277 (WebCore::CCSchedulerFrameRateControllerClientAdapter::CCSchedulerFrameR ateControllerClientAdapter):
1278 (WebCore::CCScheduler::CCScheduler):
1279 (WebCore::CCScheduler::~CCScheduler):
1280 (WebCore::CCScheduler::setNeedsAnimate):
1281 (WebCore::CCScheduler::setNeedsCommit):
1282 (WebCore::CCScheduler::setNeedsRedraw):
1283 (WebCore::CCScheduler::beginFrameComplete):
1284 (WebCore::CCScheduler::didSwapBuffersComplete):
1285 (WebCore::CCScheduler::didSwapBuffersAbort):
1286 (WebCore::CCScheduler::onBeginFrame):
1287 (WebCore::CCScheduler::processScheduledActions):
1288 * platform/graphics/chromium/cc/CCScheduler.h:
1289 (WebCore::CCScheduler::create):
1290 (WebCore::CCScheduler::commitPending):
1291 (WebCore::CCScheduler::redrawPending):
1292 * platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
1293 (WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
1294 (WebCore::CCSchedulerStateMachine::nextAction):
1295 (WebCore::CCSchedulerStateMachine::updateState):
1296 (WebCore::CCSchedulerStateMachine::beginUpdateMoreResourcesComplete):
1297 * platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
1298 (WebCore::CCSchedulerStateMachine::redrawPending):
1299 * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
1300 (WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
1301 (WebCore::CCSingleThreadProxy::doCommit):
1302 (WebCore::CCSingleThreadProxy::doComposite):
1303 * platform/graphics/chromium/cc/CCSingleThreadProxy.h:
1304 * platform/graphics/chromium/cc/CCTextureUpdater.cpp:
1305 (WebCore::CCTextureUpdater::hasMoreUpdates):
1306 * platform/graphics/chromium/cc/CCTextureUpdater.h:
1307 * platform/graphics/chromium/cc/CCThreadProxy.cpp:
1308 (WebCore::CCThreadProxy::CCThreadProxy):
1309 (WebCore::CCThreadProxy::compositeAndReadback):
1310 (WebCore::CCThreadProxy::requestReadbackOnImplThread):
1311 (WebCore::CCThreadProxy::setNeedsAnimateOnImplThread):
1312 (WebCore::CCThreadProxy::setNeedsCommitOnImplThread):
1313 (WebCore::CCThreadProxy::setNeedsRedrawOnImplThread):
1314 (WebCore::CCThreadProxy::finishAllRenderingOnImplThread):
1315 (WebCore::CCThreadProxy::scheduledActionBeginFrame):
1316 (WebCore::CCThreadProxy::beginFrameAndCommit):
1317 (WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
1318 (WebCore::CCThreadProxy::hasMoreResourceUpdates):
1319 (WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
1320 (WebCore::CCThreadProxy::scheduledActionCommit):
1321 (WebCore::CCThreadProxy::drawLayersAndSwapOnImplThread):
1322 (WebCore::CCThreadProxy::didCommitAndDrawFrame):
1323 (WebCore::CCThreadProxy::initializeImplOnImplThread):
1324 (WebCore::CCThreadProxy::layerTreeHostClosedOnImplThread):
1325 (WebCore::CCThreadProxy::scheduledActionDrawAndSwap):
1326 * platform/graphics/chromium/cc/CCThreadProxy.h:
1327
1328 2011-10-31 Nate Chapin <japhet@chromium.org>
1329
1330 Rename the remaining uses of Cue in WebCore/loader/
1331 to TextTrack.
1332 https://bugs.webkit.org/show_bug.cgi?id=71231
1333
1334 Reviewed by Eric Carlson.
1335
1336 No new tests, strictly a renaming.
1337
1338 * loader/TextTrackLoader.cpp:
1339 * loader/cache/CachedResource.cpp:
1340 * loader/cache/CachedResource.h:
1341 * loader/cache/CachedResourceLoader.cpp:
1342 * loader/cache/CachedResourceLoader.h:
1343 * loader/cache/CachedResourceRequest.cpp:
1344 * loader/cache/CachedTextTrack.cpp:
1345 * platform/network/chromium/ResourceRequest.h:
1346
1347 2011-10-27 Adam Klein <adamk@chromium.org>
1348
1349 [MutationObservers] Support characterDataOldValue for characterData muta tions
1350 https://bugs.webkit.org/show_bug.cgi?id=70862
1351
1352 Reviewed by Ojan Vafai.
1353
1354 * dom/CharacterData.cpp:
1355 (WebCore::hasOldValue):
1356 (WebCore::isOldValueRequested):
1357 (WebCore::CharacterData::dispatchModifiedEvent):
1358 * dom/MutationRecord.cpp:
1359 (WebCore::MutationRecord::createCharacterData):
1360 * dom/MutationRecord.h:
1361
1362 2011-10-31 Sam Weinig <sam@webkit.org>
1363
1364 Remove need for virtual JSObject::unwrappedObject
1365 https://bugs.webkit.org/show_bug.cgi?id=71034
1366
1367 Reviewed by Geoffrey Garen.
1368
1369 Move the member containing the global object from the JSDOMWindowShell
1370 down to the JSGlobalThis class, and update JSDOMWindowShell to go throug h
1371 an inline helper (which just casts) to get the window.
1372
1373 * bindings/js/JSDOMWindowShell.cpp:
1374 (WebCore::JSDOMWindowShell::setWindow):
1375 (WebCore::JSDOMWindowShell::className):
1376 (WebCore::JSDOMWindowShell::getOwnPropertySlot):
1377 (WebCore::JSDOMWindowShell::getOwnPropertyDescriptor):
1378 (WebCore::JSDOMWindowShell::put):
1379 (WebCore::JSDOMWindowShell::putWithAttributes):
1380 (WebCore::JSDOMWindowShell::defineOwnProperty):
1381 (WebCore::JSDOMWindowShell::deleteProperty):
1382 (WebCore::JSDOMWindowShell::getPropertyNames):
1383 (WebCore::JSDOMWindowShell::getOwnPropertyNames):
1384 (WebCore::JSDOMWindowShell::defineGetter):
1385 (WebCore::JSDOMWindowShell::defineSetter):
1386 (WebCore::JSDOMWindowShell::lookupGetter):
1387 (WebCore::JSDOMWindowShell::lookupSetter):
1388 (WebCore::JSDOMWindowShell::impl):
1389 * bindings/js/JSDOMWindowShell.h:
1390 (WebCore::JSDOMWindowShell::window):
1391 (WebCore::JSDOMWindowShell::setWindow):
1392 (WebCore::JSDOMWindowShell::createStructure):
1393
1394 2011-10-29 Ryosuke Niwa <rniwa@webkit.org>
1395
1396 WebKit nests pre on copy and paste when the pre is the root editable ele ment
1397 https://bugs.webkit.org/show_bug.cgi?id=70800
1398
1399 Reviewed by Darin Adler.
1400
1401 Fixed the bug by removing nested block elements in removeRedundantStyles AndKeepStyleSpanInline.
1402
1403 Tests: editing/pasteboard/contenteditable-pre-2.html
1404 editing/pasteboard/contenteditable-pre.html
1405
1406 * editing/ApplyStyleCommand.cpp:
1407 * editing/ReplaceSelectionCommand.cpp:
1408 (WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpan Inline): Remove block
1409 elements if it's identical to its parent and there are no contents betwe en the two. Also remove
1410 contenteditable attribute from an element if the parent is already richl y editable.
1411 (WebCore::ReplaceSelectionCommand::doApply): Remove redundant styles aft er removing the placeholder
1412 br so that the above check doesn't get affected by the placeholder.
1413 * editing/htmlediting.cpp:
1414 (WebCore::areIdenticalElements): Moved from ApplyStyleCommand.
1415 (WebCore::isNonTableCellHTMLBlockElement): Moved from markup.cpp.
1416 * editing/htmlediting.h:
1417 * editing/markup.cpp:
1418
1419 2011-10-31 Vineet Chaudhary <vineet.chaudhary@motorola.com>
1420
1421 text/plain form encoding ignored and incorrectly specified in request he ader.
1422 https://bugs.webkit.org/show_bug.cgi?id=20795
1423
1424 Reviewed by Darin Adler.
1425
1426 This patch fixes the behaviour of forms where enctype is set to
1427 text/plain, encoding is also text/plain.
1428
1429 Tests: fast/forms/form-get-textplain.html
1430 http/tests/misc/form-post-textplain.html
1431
1432 * loader/FormSubmission.cpp:
1433 (WebCore::FormSubmission::create):
1434 * platform/network/FormData.cpp:
1435 (WebCore::FormData::create):
1436 (WebCore::FormData::appendKeyValuePairItems):
1437 * platform/network/FormData.h:
1438 (WebCore::FormData::parseEncodingType):
1439 * platform/network/FormDataBuilder.cpp:
1440 (WebCore::FormDataBuilder::addKeyValuePairAsFormData): Modified encoding scheme for text/plain.
1441 * platform/network/FormDataBuilder.h:
1442
1443 2011-10-31 John Gregg <johnnyg@google.com>
1444
1445 RenderImage.cpp calls SVGImage even if it's not defined
1446 https://bugs.webkit.org/show_bug.cgi?id=71247
1447
1448 This fixes a compile error when ENABLE_SVG=0.
1449
1450 * rendering/RenderImage.cpp:
1451 (WebCore::RenderImage::embeddedContentBox):
1452
1453 2011-10-31 Pavel Podivilov <podivilov@chromium.org>
1454
1455 Update XMLHttpRequest.send idl declaration to match implementation.
1456 https://bugs.webkit.org/show_bug.cgi?id=71121
1457
1458 Reviewed by Adam Barth.
1459
1460 * xml/XMLHttpRequest.idl:
1461
1462 2011-10-31 Anders Carlsson <andersca@apple.com>
1463
1464 More work on making plug-ins work better with transforms
1465 https://bugs.webkit.org/show_bug.cgi?id=71241
1466
1467 Reviewed by Darin Adler.
1468
1469 Export symbols used by WebKit2.
1470
1471 * WebCore.exp.in:
1472
1473 2011-10-31 Mark Hahnenberg <mhahnenberg@apple.com>
1474
1475 De-virtualize JSObject::defineGetter
1476 https://bugs.webkit.org/show_bug.cgi?id=71134
1477
1478 Reviewed by Darin Adler.
1479
1480 No new tests.
1481
1482 Added defineGetter to the MethodTable. Replaced all virtual versions of defineGetter
1483 with static versions. Replaced all call sites with lookups in the Metho dTable.
1484
1485 * bindings/js/JSDOMWindowCustom.cpp:
1486 (WebCore::JSDOMWindow::defineGetter):
1487 * bindings/js/JSDOMWindowShell.cpp:
1488 (WebCore::JSDOMWindowShell::defineGetter):
1489 * bindings/js/JSDOMWindowShell.h:
1490 * bindings/js/JSLocationCustom.cpp:
1491 (WebCore::JSLocation::defineGetter):
1492 (WebCore::JSLocationPrototype::defineGetter):
1493 * bindings/scripts/CodeGeneratorJS.pm:
1494 (GenerateHeader):
1495
1496 2011-10-31 Arko Saha <arko@motorola.com>
1497
1498 Microdata: Support for itemid attribute.
1499 https://bugs.webkit.org/show_bug.cgi?id=71007
1500
1501 Reviewed by Ryosuke Niwa.
1502
1503 itemid attribute: To give a global identifier for the Microdata items.
1504 The itemid attribute, if specified, must have a value that is a valid UR L potentially
1505 surrounded by spaces.
1506 Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/microd ata.html#attr-itemid
1507
1508 Tests: fast/dom/MicroData/itemid-attribute-test.html
1509 fast/dom/MicroData/itemid-must-see-resolved-url.html
1510
1511 * html/HTMLElement.idl:
1512
1513 2011-10-31 Yury Semikhatsky <yurys@chromium.org>
1514
1515 window.onerror doesn't work with inline (attribute) scripts
1516 https://bugs.webkit.org/show_bug.cgi?id=70991
1517
1518 Uncaught syntax errors in inline event handlers are now reported to
1519 window.onerror handler.
1520
1521 Reviewed by Geoffrey Garen.
1522
1523 Tests: fast/events/window-onerror-exception-in-attr.html
1524 fast/events/window-onerror-syntax-error-in-attr.html
1525
1526 * bindings/js/JSLazyEventListener.cpp:
1527 (WebCore::JSLazyEventListener::initializeJSFunction): report exception a s usual
1528 if it happens during event handler compilation.
1529
1530 2011-10-31 Emil A Eklund <eae@chromium.org>
1531
1532 Overridden LayoutRect method still uses IntRects
1533 https://bugs.webkit.org/show_bug.cgi?id=71166
1534
1535 Reviewed by Eric Seidel.
1536
1537 Change all virtual controlClipRect, windowResizerRect, windowClipRect,
1538 visibleContentRect, scrollCornerRect, outlineBoundsForRepaint and
1539 localCaretRect functions to have the same signature.
1540
1541 * page/FrameView.cpp:
1542 (WebCore::FrameView::windowClipRect):
1543 (WebCore::FrameView::windowClipRectForLayer):
1544 (WebCore::FrameView::windowResizerRect):
1545 * page/FrameView.h:
1546 * platform/ScrollView.cpp:
1547 (WebCore::ScrollView::wheelEvent):
1548 * platform/ScrollView.h:
1549 * platform/ScrollableArea.h:
1550 * rendering/RenderButton.h:
1551 * rendering/RenderLayer.cpp:
1552 (WebCore::RenderLayer::visibleContentRect):
1553 * rendering/RenderLayer.h:
1554 * rendering/RenderObject.cpp:
1555 (WebCore::RenderObject::localCaretRect):
1556 * rendering/RenderObject.h:
1557 (WebCore::RenderObject::outlineBoundsForRepaint):
1558 * rendering/RenderText.cpp:
1559 (WebCore::RenderText::localCaretRect):
1560 (WebCore::RenderText::linesBoundingBox):
1561 * rendering/RenderText.h:
1562 * rendering/svg/RenderSVGInlineText.cpp:
1563 (WebCore::RenderSVGInlineText::localCaretRect):
1564 * rendering/svg/RenderSVGInlineText.h:
1565
1566 2011-10-31 Dmitry Lomov <dslomov@google.com>
1567
1568 https://bugs.webkit.org/show_bug.cgi?id=70658
1569 [JSC] Implement MessagePort transfer in JSC bindings implementation of w ebkitPostMessage.
1570 Transfer of MessagePorts implemented.
1571
1572 Reviewed by David Levin.
1573
1574 * bindings/js/SerializedScriptValue.cpp:
1575 (WebCore::CloneSerializer::serialize):
1576 (WebCore::CloneSerializer::CloneSerializer):
1577 (WebCore::CloneSerializer::dumpIfTerminal):
1578 (WebCore::CloneDeserializer::deserialize):
1579 (WebCore::CloneDeserializer::CloneDeserializer):
1580 (WebCore::CloneDeserializer::readTerminal):
1581 (WebCore::SerializedScriptValue::create):
1582 (WebCore::SerializedScriptValue::deserialize):
1583
1584 2011-10-31 Andreas Kling <kling@webkit.org>
1585
1586 CSSRule: Devirtualize insertedIntoParent()
1587 https://bugs.webkit.org/show_bug.cgi?id=71223
1588
1589 Reviewed by Antti Koivisto.
1590
1591 Moved insertedIntoParent() down into CSSImportRule and renamed it to
1592 requestStyleSheet(). CSSImportRule is the only user of this function.
1593
1594 * css/CSSImportRule.cpp:
1595 (WebCore::CSSImportRule::requestStyleSheet):
1596 * css/CSSImportRule.h:
1597 * css/CSSRule.h:
1598 * css/CSSStyleSheet.cpp:
1599 (WebCore::CSSStyleSheet::append):
1600 (WebCore::CSSStyleSheet::insertRule):
1601
1602 2011-10-31 Anna Cavender <annacc@chromium.org>
1603
1604 Implement load notification and events for <track>.
1605 https://bugs.webkit.org/show_bug.cgi?id=71054
1606
1607 Reviewed by Eric Carlson.
1608
1609 Tests: media/track/track-load-error-readyState.html
1610 media/track/track-load-from-element-readyState.html
1611 media/track/track-load-from-src-readyState.html
1612
1613 * html/HTMLMediaElement.cpp:
1614 (WebCore::HTMLMediaElement::trackWasAdded):
1615 (WebCore::HTMLMediaElement::trackWillBeRemoved):
1616 (WebCore::HTMLMediaElement::trackSourceChanged):
1617 * html/HTMLMediaElement.h:
1618 * html/HTMLTrackElement.cpp:
1619 (WebCore::HTMLTrackElement::insertedIntoTree):
1620 (WebCore::HTMLTrackElement::willRemove):
1621 (WebCore::HTMLTrackElement::parseMappedAttribute):
1622 (WebCore::HTMLTrackElement::attributeChanged):
1623 * html/HTMLTrackElement.h:
1624 * html/LoadableTextTrack.cpp:
1625 (WebCore::LoadableTextTrack::cueLoadingCompleted):
1626
1627 2011-10-31 Andreas Kling <kling@webkit.org>
1628
1629 CSSRule: Devirtualize type() and isFooRule()
1630 https://bugs.webkit.org/show_bug.cgi?id=71221
1631
1632 Reviewed by Antti Koivisto.
1633
1634 Store the rule type in a CSSRule member (packed with the parent-is-rule flag)
1635 and let the isFooRule() functions return type() == FOO_TYPE.
1636
1637 CSSPageRule will no longer return true for isStyleRule(), tweaked call s ites
1638 accordingly.
1639
1640 * css/CSSCharsetRule.cpp:
1641 (WebCore::CSSCharsetRule::CSSCharsetRule):
1642 * css/CSSCharsetRule.h:
1643 * css/CSSFontFaceRule.cpp:
1644 (WebCore::CSSFontFaceRule::CSSFontFaceRule):
1645 * css/CSSFontFaceRule.h:
1646 * css/CSSImportRule.cpp:
1647 (WebCore::CSSImportRule::CSSImportRule):
1648 * css/CSSImportRule.h:
1649 * css/CSSMediaRule.cpp:
1650 (WebCore::CSSMediaRule::CSSMediaRule):
1651 * css/CSSMediaRule.h:
1652 * css/CSSPageRule.cpp:
1653 (WebCore::CSSPageRule::CSSPageRule):
1654 * css/CSSPageRule.h:
1655 * css/CSSRegionStyleRule.cpp:
1656 (WebCore::CSSRegionStyleRule::CSSRegionStyleRule):
1657 * css/CSSRegionStyleRule.h:
1658 * css/CSSRule.h:
1659 (WebCore::CSSRule::type):
1660 (WebCore::CSSRule::isCharsetRule):
1661 (WebCore::CSSRule::isFontFaceRule):
1662 (WebCore::CSSRule::isKeyframeRule):
1663 (WebCore::CSSRule::isKeyframesRule):
1664 (WebCore::CSSRule::isMediaRule):
1665 (WebCore::CSSRule::isPageRule):
1666 (WebCore::CSSRule::isStyleRule):
1667 (WebCore::CSSRule::isRegionStyleRule):
1668 (WebCore::CSSRule::isImportRule):
1669 (WebCore::CSSRule::CSSRule):
1670 * css/CSSStyleRule.cpp:
1671 (WebCore::CSSStyleRule::CSSStyleRule):
1672 * css/CSSStyleRule.h:
1673 * css/CSSStyleSelector.cpp:
1674 (WebCore::RuleSet::addPageRule):
1675 (WebCore::RuleSet::addRulesFromSheet):
1676 (WebCore::RuleSet::addStyleRule):
1677 * css/CSSUnknownRule.h:
1678 (WebCore::CSSUnknownRule::CSSUnknownRule):
1679 * css/WebKitCSSKeyframeRule.cpp:
1680 (WebCore::WebKitCSSKeyframeRule::WebKitCSSKeyframeRule):
1681 * css/WebKitCSSKeyframeRule.h:
1682 * css/WebKitCSSKeyframesRule.cpp:
1683 (WebCore::WebKitCSSKeyframesRule::WebKitCSSKeyframesRule):
1684 * css/WebKitCSSKeyframesRule.h:
1685 * inspector/InspectorCSSAgent.cpp:
1686 (WebCore::InspectorCSSAgent::asCSSStyleRule):
1687
1688 2011-10-31 Pavel Feldman <pfeldman@google.com>
1689
1690 Not reviewed: reorder inspector js files to fix remote mode.
1691
1692 * inspector/front-end/inspector.html:
1693
1694 2011-10-28 Alexander Pavlov <apavlov@chromium.org>
1695
1696 Web Inspector: [refactoring] TextPrompt: ensure encapsulation, extract h istory management
1697 https://bugs.webkit.org/show_bug.cgi?id=70936
1698
1699 Reviewed by Pavel Feldman.
1700
1701 * inspector/front-end/ConsoleView.js:
1702 (WebInspector.ConsoleView):
1703 * inspector/front-end/DatabaseQueryView.js:
1704 (WebInspector.DatabaseQueryView):
1705 (WebInspector.DatabaseQueryView.prototype._enterKeyPressed):
1706 * inspector/front-end/StylesSidebarPane.js:
1707 (WebInspector.StylesSidebarPane.prototype._attributesModified):
1708 (WebInspector.StylePropertyTreeElement.prototype.selectElement):
1709 (WebInspector.StylePropertyTreeElement.prototype.selectElement.context):
1710 (WebInspector.StylePropertyTreeElement.prototype.selectElement.event):
1711 (WebInspector.StylePropertyTreeElement.prototype):
1712 (WebInspector.StylePropertyTreeElement.prototype.context.event):
1713 ():
1714 * inspector/front-end/TextPrompt.js:
1715 (WebInspector.TextPrompt):
1716 (WebInspector.TextPrompt.prototype.get proxyElement):
1717 (WebInspector.TextPrompt.prototype.attach):
1718 (WebInspector.TextPrompt.prototype.attachAndStartEditing):
1719 (WebInspector.TextPrompt.prototype._attachInternal):
1720 (WebInspector.TextPrompt.prototype.detach):
1721 (WebInspector.TextPrompt.prototype.get text):
1722 (WebInspector.TextPrompt.prototype.set text):
1723 (WebInspector.TextPrompt.prototype._removeFromElement):
1724 (WebInspector.TextPrompt.prototype._startEditing):
1725 (WebInspector.TextPrompt.prototype._stopEditing):
1726 (WebInspector.TextPrompt.prototype._selectStart.moveBackIfOutside):
1727 (WebInspector.TextPrompt.prototype._selectStart):
1728 (WebInspector.TextPrompt.prototype.defaultKeyHandler):
1729 (WebInspector.TextPrompt.prototype._onKeyDown):
1730 (WebInspector.TextPrompt.prototype.clearAutoComplete):
1731 (WebInspector.TextPrompt.prototype.complete):
1732 (WebInspector.TextPrompt.prototype._completionsReady):
1733 (WebInspector.TextPrompt.prototype.isCaretInsidePrompt):
1734 (WebInspector.TextPrompt.prototype.isCaretAtEndOfPrompt):
1735 (WebInspector.TextPrompt.prototype.isCaretOnFirstLine):
1736 (WebInspector.TextPrompt.prototype.isCaretOnLastLine):
1737 (WebInspector.TextPrompt.prototype.moveCaretToEndOfPrompt):
1738 (WebInspector.TextPrompt.prototype.upKeyPressed):
1739 (WebInspector.TextPrompt.prototype.downKeyPressed):
1740 (WebInspector.TextPrompt.prototype.tabKeyPressed):
1741 (WebInspector.TextPromptConfig):
1742 (WebInspector.TextPromptWithHistory):
1743 (WebInspector.TextPromptWithHistory.prototype.get historyData):
1744 (WebInspector.TextPromptWithHistory.prototype.setHistoryData):
1745 (WebInspector.TextPromptWithHistory.prototype.pushHistoryItem):
1746 (WebInspector.TextPromptWithHistory.prototype._pushCurrentText):
1747 (WebInspector.TextPromptWithHistory.prototype._previous):
1748 (WebInspector.TextPromptWithHistory.prototype._next):
1749 (WebInspector.TextPromptWithHistory.prototype._currentHistoryItem):
1750 (WebInspector.TextPromptWithHistory.prototype.defaultKeyHandler):
1751
1752 2011-10-31 Pavel Feldman <pfeldman@google.com>
1753
1754 Web Inspector: move localization support into UIUtil.js, reduce externs.
1755 https://bugs.webkit.org/show_bug.cgi?id=71220
1756
1757 Reviewed by Yury Semikhatsky.
1758
1759 * inspector/compile-front-end.sh:
1760 * inspector/front-end/AdvancedSearchController.js:
1761 (WebInspector.SearchView.prototype.focus):
1762 * inspector/front-end/ConsoleView.js:
1763 (WebInspector.ConsoleView.prototype.afterShow):
1764 * inspector/front-end/Drawer.js:
1765 * inspector/front-end/GoToLineDialog.js:
1766 (WebInspector.GoToLineDialog.prototype._hide):
1767 * inspector/front-end/HelpScreen.js:
1768 (WebInspector.HelpScreen.prototype.show):
1769 (WebInspector.HelpScreen.prototype.hide):
1770 (WebInspector.HelpScreen.prototype._onBlur):
1771 * inspector/front-end/InspectorFrontendHostStub.js:
1772 * inspector/front-end/KeyboardShortcut.js:
1773 (WebInspector.KeyboardShortcut._keyName):
1774 * inspector/front-end/Panel.js:
1775 (WebInspector.Panel.prototype.wasShown):
1776 * inspector/front-end/SearchController.js:
1777 (WebInspector.SearchController.prototype._onSearchFieldManualFocus):
1778 (WebInspector.SearchController.prototype._onKeyDown):
1779 * inspector/front-end/Settings.js:
1780 * inspector/front-end/SourceFrame.js:
1781 (WebInspector.SourceFrame):
1782 * inspector/front-end/Toolbar.js:
1783 (WebInspector.Toolbar.prototype._toolbarDragStart):
1784 * inspector/front-end/UIUtils.js:
1785 (WebInspector.startEditing.cleanUpAfterEditing):
1786 (WebInspector.startEditing.var):
1787 (WebInspector.startEditing):
1788 (WebInspector.UIString):
1789 (WebInspector.useLowerCaseMenuTitles):
1790 (WebInspector.platform):
1791 (WebInspector.isMac):
1792 (WebInspector.platformFlavor):
1793 (WebInspector.port):
1794 (WebInspector.installPortStyles):
1795 (WebInspector._windowFocused):
1796 (WebInspector._windowBlurred):
1797 (WebInspector.previousFocusElement):
1798 (WebInspector.currentFocusElement):
1799 (WebInspector._focusChanged):
1800 (WebInspector.setCurrentFocusElement):
1801 * inspector/front-end/externs.js:
1802 (Event.prototype.initWebKitWheelEvent):
1803 (window.getComputedStyle):
1804 (InspectorBackend.runAfterPendingDispatches):
1805 * inspector/front-end/inspector.js:
1806 (WebInspector.documentKeyDown):
1807 (WebInspector.addMainEventListeners):
1808
1809 2011-10-31 Andreas Kling <kling@webkit.org>
1810
1811 Kill StyleBase.
1812 https://bugs.webkit.org/show_bug.cgi?id=71218
1813
1814 Reviewed by Antti Koivisto.
1815
1816 Remove the StyleBase class and make all subclasses stand alone. CSSRule and StyleSheet
1817 now inherit from RefCounted<T> instead, and XSLImportRule doesn't even n eed that,
1818 so StyleBase is replaced by nothing.
1819
1820 * css/StyleBase.cpp:
1821 * css/StyleBase.h:
1822
1823 Removed.
1824
1825 * css/CSSRule.cpp:
1826 * css/CSSRule.h:
1827 (WebCore::CSSRule::~CSSRule):
1828 (WebCore::CSSRule::useStrictParsing):
1829 (WebCore::CSSRule::setParentStyleSheet):
1830 (WebCore::CSSRule::setParentRule):
1831 (WebCore::CSSRule::parentStyleSheet):
1832 (WebCore::CSSRule::parentRule):
1833 (WebCore::CSSRule::baseURL):
1834 (WebCore::CSSRule::CSSRule):
1835
1836 CSSRule now inherits directly from RefCounted, and has either a CSSR ule or a
1837 CSSStyleSheet as its parent. Made these getters/setters inline since they are
1838 trivial now.
1839
1840 * CMakeLists.txt:
1841 * GNUmakefile.list.am:
1842 * WebCore.gypi:
1843 * WebCore.pro:
1844 * WebCore.vcproj/WebCore.vcproj:
1845 * WebCore.xcodeproj/project.pbxproj:
1846
1847 Purge StyleBase.* from the build systems.
1848
1849 * bindings/js/JSDOMBinding.h:
1850 (WebCore::root):
1851
1852 New root() functions for CSSRule and StyleSheet.
1853
1854 * bindings/js/JSNodeCustom.h:
1855
1856 Remove StyleBase.h include.
1857
1858 * css/CSSStyleSheet.h:
1859 (WebCore::CSSStyleSheet::parentStyleSheet):
1860
1861 Added CSS-specific parentStyleSheet() so we don't have to cast it to a
1862 CSSStyleSheet* at the call sites.
1863
1864 * css/StyleSheet.cpp:
1865 (WebCore::StyleSheet::StyleSheet):
1866 (WebCore::StyleSheet::parentStyleSheet):
1867 (WebCore::StyleSheet::baseURL):
1868 * css/StyleSheet.h:
1869 (WebCore::StyleSheet::parentRule):
1870 (WebCore::StyleSheet::setParentRule):
1871 (WebCore::StyleSheet::isCSSStyleSheet):
1872 (WebCore::StyleSheet::isXSLStyleSheet):
1873
1874 StyleSheet now inherits directly from RefCounted and always has a pa rent CSSRule
1875 though it can be null. parentStyleSheet() returns that rule's parent style sheet.
1876 Moved the relevant guts from StyleBase down here.
1877
1878 * loader/cache/CachedStyleSheetClient.h:
1879
1880 Remove unnecessary WTF_MAKE_FAST_ALLOCATED, we get it from CachedRes ourceClient.
1881
1882 * xml/XSLImportRule.cpp:
1883 (WebCore::XSLImportRule::XSLImportRule):
1884 (WebCore::XSLImportRule::~XSLImportRule):
1885 (WebCore::XSLImportRule::parentStyleSheet):
1886 (WebCore::XSLImportRule::setXSLStyleSheet):
1887 (WebCore::XSLImportRule::loadSheet):
1888 * xml/XSLImportRule.h:
1889 (WebCore::XSLImportRule::create):
1890 (WebCore::XSLImportRule::setParentStyleSheet):
1891
1892 Remove inheritance from StyleBase, and have create() return a PassOw nPtr instead.
1893 This is fine, since XSLStyleSheet is the only object that ever manag es these rules.
1894
1895 * svg/SVGFontFaceElement.cpp:
1896 (WebCore::SVGFontFaceElement::insertedIntoDocument):
1897 * css/CSSStyleSheet.cpp:
1898 (WebCore::CSSStyleSheet::~CSSStyleSheet):
1899 (WebCore::CSSStyleSheet::ownerRule):
1900 (WebCore::CSSStyleSheet::deleteRule):
1901 (WebCore::CSSStyleSheet::checkLoaded):
1902 (WebCore::CSSStyleSheet::document):
1903 (WebCore::CSSStyleSheet::styleSheetChanged):
1904 * css/CSSImportRule.cpp:
1905 (WebCore::CSSImportRule::~CSSImportRule):
1906 (WebCore::CSSImportRule::setCSSStyleSheet):
1907 (WebCore::CSSImportRule::insertedIntoParent):
1908 * css/CSSMediaRule.cpp:
1909 (WebCore::CSSMediaRule::CSSMediaRule):
1910 (WebCore::CSSMediaRule::~CSSMediaRule):
1911 (WebCore::CSSMediaRule::append):
1912 (WebCore::CSSMediaRule::insertRule):
1913 (WebCore::CSSMediaRule::deleteRule):
1914 * css/CSSRegionStyleRule.cpp:
1915 (WebCore::CSSRegionStyleRule::CSSRegionStyleRule):
1916 (WebCore::CSSRegionStyleRule::~CSSRegionStyleRule):
1917 * css/CSSRuleList.cpp:
1918 (WebCore::CSSRuleList::deleteRule):
1919 * css/CSSStyleDeclaration.h:
1920 * css/WebKitCSSKeyframesRule.cpp:
1921 (WebCore::WebKitCSSKeyframesRule::~WebKitCSSKeyframesRule):
1922 (WebCore::WebKitCSSKeyframesRule::setName):
1923 (WebCore::WebKitCSSKeyframesRule::append):
1924 * dom/ProcessingInstruction.cpp:
1925 (WebCore::ProcessingInstruction::parseStyleSheet):
1926 * inspector/InspectorCSSAgent.cpp:
1927 (WebCore::InspectorCSSAgent::parentStyleSheet):
1928 * xml/XSLStyleSheet.h:
1929 * xml/XSLStyleSheetLibxslt.cpp:
1930 (WebCore::XSLStyleSheet::XSLStyleSheet):
1931 (WebCore::XSLStyleSheet::~XSLStyleSheet):
1932 (WebCore::XSLStyleSheet::checkLoaded):
1933 (WebCore::XSLStyleSheet::loadChildSheet):
1934 * xml/XSLStyleSheetQt.cpp:
1935 (WebCore::XSLStyleSheet::~XSLStyleSheet):
1936
1937 Use the new, more explicit, parenting functions of StyleSheet.
1938
1939 2011-10-31 Nikolas Zimmermann <nzimmermann@rim.com>
1940
1941 CSS 2.1 failure: background-intrinsic-*
1942 https://bugs.webkit.org/show_bug.cgi?id=47156
1943
1944 SVGs do not work as tiled background images
1945 https://bugs.webkit.org/show_bug.cgi?id=16281
1946
1947 Apply preserveAspectRatio and synthesize viewboxes in <img>
1948 https://bugs.webkit.org/show_bug.cgi?id=34521
1949
1950 SVG background doesn't resize properly when dimensions are changed
1951 https://bugs.webkit.org/show_bug.cgi?id=42944
1952
1953 Images with percent height inside a floated div should use intrinsic hei ght.
1954 https://bugs.webkit.org/show_bug.cgi?id=45439
1955
1956 SVG image in HTML changes size as the window is resized
1957 https://bugs.webkit.org/show_bug.cgi?id=52045
1958
1959 Reviewed by Antti Koivisto.
1960
1961 Implement intrinsic sizing support for SVGImage (svg embedded through <h tml:img>/<svg:image>/background-image/border-image/...).
1962 This is demanded by CSS 2.1, and covered by new layout tests in LayoutTe sts/css2.1 and several new custom testcases.
1963
1964 Tests: css2.1/20110323/background-intrinsic-001.htm
1965 css2.1/20110323/background-intrinsic-002.htm
1966 css2.1/20110323/background-intrinsic-003.htm
1967 css2.1/20110323/background-intrinsic-004.htm
1968 css2.1/20110323/background-intrinsic-005.htm
1969 css2.1/20110323/background-intrinsic-006.htm
1970 css2.1/20110323/background-intrinsic-007.htm
1971 css2.1/20110323/background-intrinsic-008.htm
1972 css2.1/20110323/background-intrinsic-009.htm
1973 svg/as-background-image/background-image-preserveaspectRatio-supp ort.html (adapted from testcase from bug 34521)
1974 svg/as-background-image/background-image-tiled.html (reduction fr om bug 16281)
1975 svg/as-background-image/same-image-two-instances-background-image .html
1976 svg/as-image/img-preserveAspectRatio-support-1.html (reduction fr om bug 34521)
1977 svg/as-image/same-image-two-instances.html
1978 svg/as-image/svg-as-relative-image-with-explicit-size.html
1979 svg/as-image/svg-image-change-content-size.xhtml (reduction from bug 42944)
1980 svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html
1981 svg/zoom/page/zoom-svg-as-image.html
1982 svg/zoom/page/zoom-svg-as-relative-image.html
1983
1984 * css/CSSImageGeneratorValue.cpp:
1985 (WebCore::CSSImageGeneratorValue::addClient): Pass default zoom factor.
1986 (WebCore::CSSImageGeneratorValue::getImage): Ditto.
1987 * loader/cache/CachedImage.cpp: Enable SVGImage <-> IntSize cache.
1988 (WebCore::CachedImage::lookupImageForSize): Use recently introduced Imag eBySizeCache, to lookup an image for a certain size.
1989 (WebCore::CachedImage::lookupOrCreateImageForRenderer): Use recently int roduced ImageBySizeCache, to dynamically create copies of m_image if needed.
1990 (WebCore::CachedImage::imageForRenderer): Lookup image by renderer, whic h first looks up a size for a renderer, then uses lookupImageForSize().
1991 (WebCore::CachedImage::setContainerSizeForRenderer): For SVGImages, pass on container size handling to ImageBySizeCache.
1992 (WebCore::CachedImage::imageSizeForRenderer): Figure out the image size, respecting per-renderer overrides, for a certain renderer.
1993 (WebCore::CachedImage::computeIntrinsicDimensions): Remove unnecessary R enderObject parameter.
1994 * loader/cache/CachedImage.h:
1995 * page/ChromeClient.h:
1996 (WebCore::ChromeClient::isSVGImageChromeClient): Used to identify whethe r a RenderSVGRoot is embedded through a SVGImage. Returns false, by default.
1997 * platform/graphics/Image.h:
1998 (WebCore::Image::setImageObserver): Add helper.
1999 * rendering/ImageBySizeCache.cpp: Cleanup code.
2000 (WebCore::ImageBySizeCache::addClient): Assert the passed renderer is va lid.
2001 (WebCore::ImageBySizeCache::removeClient): Ditto. Allow removeClient() t o be called w/o prio addClient() usage.
2002 (WebCore::ImageBySizeCache::getImage): Add zoom parameter.
2003 (WebCore::ImageBySizeCache::getRequestedSizeAndZoom): Add way to get req uested size from cache, instead of actual cached sizes.
2004 (WebCore::ImageBySizeCache::imageForSize): Respect empty sizes, just ret urn 0, instead of asserting.
2005 (WebCore::ImageBySizeCache::imageForRenderer): Added a helper that retri eves an image for a renderer, by lookup up its size and using imageForSize().
2006 * rendering/ImageBySizeCache.h: Cleaup code, introduce struct that repla ces the std::pair<IntSize, int>.
2007 (WebCore::SizeZoomAndCount::SizeZoomAndCount):
2008 * rendering/RenderBoxModelObject.cpp: Implement CSS 2.1 intrinsic size n egotiation for images.
2009 (WebCore::resolveWidthForRatio): New inline helper function used by calc ulateImageIntrinsicDimensions.
2010 (WebCore::resolveHeightForRatio): Ditto.
2011 (WebCore::resolveAgainstIntrinsicWidthOrHeightAndRatio): Ditto.
2012 (WebCore::resolveAgainstIntrinsicRatio): Ditto.
2013 (WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions): New helper function, containing the main algorithm, which is a pure transcription of the spec.
2014 (WebCore::RenderBoxModelObject::calculateFillTileSize): Use new calculat eImageIntrinsicDimensions() helper to figure out the intrinsic size.
2015 (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Propa gate calculateFillTileSize() result to the image resource, via setContainerSizeF orRenderer().
2016 (WebCore::RenderBoxModelObject::paintNinePieceImage): Use new calculateI mageIntrinsicDimensions() helper to figure out the intrinsic size.
2017 * rendering/RenderBoxModelObject.h: Clarify some variable names, added c alculateImageIntrinsicDimensions().
2018 * rendering/RenderImage.cpp:
2019 (WebCore::RenderImage::RenderImage): Use IntSize(), instead of IntSize(0 , 0).
2020 (WebCore::RenderImage::updateIntrinsicSizeIfNeeded): Refactored from ima geDimensionsChanged().
2021 (WebCore::RenderImage::imageDimensionsChanged): Use updateIntrinsicSizeI fNeeded().
2022 (WebCore::RenderImage::computeReplacedLogicalWidth): Use RenderReplaced: :computeReplacedLogicalWidth() exclusively. For this to work, the intrinsic size must be correct.
2023 (WebCore::RenderImage::computeIntrinsicRatioInformation): Default implem entation for non-SVGImages.
2024 (WebCore::RenderImage::needsPreferredWidthsRecalculation): Return true, just like RenderPart, if embeddedContentBox is not null.
2025 (WebCore::RenderImage::embeddedContentBox): Returns the RenderSVGRoot* r enderer of the embedded SVG, if possible.
2026 * rendering/RenderImage.h: Remove isLogicalWidth/HeightSpecified() / com puteReplacedLogicalHeight() / calcAspectRatioLogicalWidth/Height().
2027 * rendering/RenderImageResource.cpp:
2028 (WebCore::RenderImageResource::setContainerSizeForRenderer): Pass around new "float containerZoomFactor" parameter.
2029 * rendering/RenderImageResourceStyleImage.cpp:
2030 (WebCore::RenderImageResourceStyleImage::image): embeddedContentBox() is now calling image() earlier than before. We now have to handle the case that th e image is pending.
2031 (WebCore::RenderImageResourceStyleImage::setContainerSizeForRenderer): P ass zoom factor.
2032 * rendering/RenderImageResourceStyleImage.h:
2033 * rendering/RenderListMarker.cpp:
2034 (WebCore::RenderListMarker::computePreferredLogicalWidths): Pass effecti ve zoom to setContainerSizeForRenderer().
2035 * rendering/RenderReplaced.cpp:
2036 (WebCore::RenderReplaced::computeIntrinsicLogicalWidth): Generalized thi s code, as RenderImage is using it as well now. Marginal changes needed.
2037 (WebCore::RenderReplaced::computeIntrinsicLogicalHeight): Ditto.
2038 (WebCore::RenderReplaced::computeReplacedLogicalWidth): Ditto.
2039 * rendering/style/StyleCachedImage.cpp:
2040 (WebCore::StyleCachedImage::computeIntrinsicDimensions): Stop passing m_ renderer to CachedImage, it's no longer needed.
2041 (WebCore::StyleCachedImage::setContainerSizeForRenderer): Add "float con tainerZoomFactor" parameter.
2042 * rendering/style/StyleCachedImage.h: Add "float containerZoomFactor" pa rameter to setContainerSizeForRenderer.
2043 * rendering/style/StyleGeneratedImage.h:
2044 (WebCore::StyleGeneratedImage::setContainerSizeForRenderer): Ditto.
2045 * rendering/style/StyleImage.h: Ditto.
2046 * rendering/style/StylePendingImage.h:
2047 (WebCore::StylePendingImage::setContainerSizeForRenderer): Ditto.
2048 * rendering/svg/RenderSVGImage.cpp:
2049 (WebCore::RenderSVGImage::layout): Always supply a container size when e mbedding SVGs in <svg:image>.
2050 * rendering/svg/RenderSVGRoot.cpp: Move "override container size" from S VGSVGElement into RenderSVGRoot, where it belongs.
2051 (WebCore::RenderSVGRoot::isEmbeddedThroughImageElement): Add helper meth od to determine whether we're loaded through SVGImage.
2052 (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): If we have a vali d container size, it has precendence (only supplied via external SVGImages).
2053 (WebCore::RenderSVGRoot::computeReplacedLogicalHeight): Ditto.
2054 (WebCore::RenderSVGRoot::layout): Remove calcViewport() usage, no need t o track/override the viewport size anymore, all done in coputeReplacedLogical* n ow.
2055 (WebCore::RenderSVGRoot::paint): Use borderBoxRect() which now always ma tches the previously computed m_viewportSize.
2056 (WebCore::RenderSVGRoot::computeRectForRepaint): Ditto.
2057 * rendering/svg/RenderSVGRoot.h: Move "override container size" from SVG SVGElement into RenderSVGRoot, where it belongs.
2058 (WebCore::RenderSVGRoot::containerSize):
2059 (WebCore::RenderSVGRoot::setContainerSize):
2060 * svg/SVGLength.cpp:
2061 (WebCore::SVGLength::determineViewport): Resolve lengths against overrid e container size in documents embedded through SVGImage.
2062 * svg/SVGSVGElement.cpp: Remove "override container size" handling from SVGSVGElement.
2063 (WebCore::SVGSVGElement::SVGSVGElement): Ditto.
2064 (WebCore::SVGSVGElement::currentViewBoxRect): Always synthesize a viewBo x, if we're embedded through SVGImage, as demanded by SVG 1.1 2nd Edition.
2065 * svg/SVGSVGElement.h:
2066 * svg/graphics/SVGImage.cpp:
2067 (WebCore::SVGImageChromeClient::isSVGImageChromeClient): Return true, us ed to identify whether RenderSVGRoot is embedded through SVGImage.
2068 (WebCore::SVGImage::createWithDataAndSize): Add new helper function.
2069 (WebCore::SVGImage::setContainerZoom): Forwarded to Page::setPageZoomFac tor.
2070 (WebCore::SVGImage::setContainerSize): Assert that container size is not empty. We should never receive an empty container size.
2071 (WebCore::SVGImage::usesContainerSize): Adapt to override container size changes, it now lives in RenderSVGRoot instead of SVGSVGElement.
2072 (WebCore::SVGImage::size): New algorithm to figure out the size of an em bedded SVG, as demanded by the CSS/SVG specs.
2073 (WebCore::SVGImage::embeddedContentBox): Add helper which returns the Re nderSVGRoot of the document.
2074 (WebCore::SVGImage::computeIntrinsicDimensions): Implement intrinsic rat io calculation.
2075 (WebCore::SVGImage::dataChanged): Force calling FrameView::setCanHaveScr ollbars(false), as SVG images now always synthesize a viewBox, and thus never re ceive scrollbars.
2076 * svg/graphics/SVGImage.h:
2077
2078 2011-10-31 Yury Semikhatsky <yurys@chromium.org>
2079
2080 Unreviewed. Add ResourcePreviewView.js to the list of inspector front-en d
2081 files on Qt.
2082
2083 * inspector/front-end/WebKit.qrc:
2084
2085 2011-10-31 Pavel Feldman <pfeldman@google.com>
2086
2087 Web Inspector: do not map scripts generated with document.write to the d ocument resources.
2088 https://bugs.webkit.org/show_bug.cgi?id=71114
2089
2090 Reviewed by Yury Semikhatsky.
2091
2092 Test: inspector/debugger/bind-script-to-resource.html
2093
2094 * inspector/front-end/DebuggerPresentationModel.js:
2095 (WebInspector.DebuggerPresentationModel):
2096 (WebInspector.DebuggerPresentationModel.prototype._addScript):
2097 (WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSource Code):
2098 (WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScrip tWithURL):
2099 (WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScrip t):
2100 (WebInspector.DebuggerPresentationModel.prototype._scriptForRawSourceCod e):
2101 (WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
2102 * inspector/front-end/RawSourceCode.js:
2103 (WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestCon tent.didFormatContent):
2104 (WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestCon tent):
2105 (WebInspector.RawSourceCode.prototype._createSourceMapping):
2106 * inspector/front-end/Script.js:
2107
2108 2011-10-31 Antti Koivisto <antti@apple.com>
2109
2110 https://bugs.webkit.org/show_bug.cgi?id=71012
2111 Use StringHasher to generate the matched declaration cache hash
2112
2113 Reviewed by Sam Weinig.
2114
2115 Make sure the MatchedStyleDeclarations are fully zero-initialized as we calculate a hash over a raw memory array of these.
2116
2117 * css/CSSStyleSelector.cpp:
2118 (WebCore::CSSStyleSelector::MatchedStyleDeclaration::MatchedStyleDeclara tion):
2119 (WebCore::CSSStyleSelector::addMatchedDeclaration):
2120 * css/CSSStyleSelector.h:
2121
2122 2011-10-31 Carlos Garcia Campos <cgarcia@igalia.com>
2123
2124 Unreviewed. Fix make distcheck build.
2125
2126 * GNUmakefile.am: Add InFilesCompiler.pm to SCRIPTS_BINDINGS and
2127 EXTRA_DIST. Also remove duplicated entries in EXTRA_DIST.
2128
2129 2011-10-31 Pavel Feldman <pfeldman@chromium.org>
2130
2131 Web Inspector: factor out ResourceUtils, clean up externs.
2132 https://bugs.webkit.org/show_bug.cgi?id=71192
2133
2134 Reviewed by Yury Semikhatsky.
2135
2136 * WebCore.gypi:
2137 * WebCore.vcproj/WebCore.vcproj:
2138 * inspector/compile-front-end.sh:
2139 * inspector/front-end/ConsoleMessage.js:
2140 (WebInspector.ConsoleMessageImpl.prototype._linkifyLocation):
2141 * inspector/front-end/DebuggerPresentationModel.js:
2142 * inspector/front-end/ProfilesPanel.js:
2143 * inspector/front-end/Resource.js:
2144 (WebInspector.Resource.displayName):
2145 * inspector/front-end/ResourceTreeModel.js:
2146 (WebInspector.ResourceTreeModel.prototype._createResource):
2147 * inspector/front-end/ResourceUtils.js: Added.
2148 (WebInspector.resourceForURL):
2149 (WebInspector.forAllResources):
2150 (WebInspector.displayNameForURL):
2151 (WebInspector.linkifyStringAsFragmentWithCustomLinkifier):
2152 (WebInspector.registerLinkifierPlugin):
2153 (WebInspector.linkifyStringAsFragment):
2154 (WebInspector.linkifyURLAsNode):
2155 (WebInspector.linkifyURL):
2156 (WebInspector.formatLinkText):
2157 (WebInspector.linkifyResourceAsNode):
2158 (WebInspector.resourceURLForRelatedNode.callback):
2159 (WebInspector.resourceURLForRelatedNode):
2160 (WebInspector.populateHrefContextMenu):
2161 (WebInspector.completeURL):
2162 * inspector/front-end/StylesSidebarPane.js:
2163 (WebInspector.StylePropertyTreeElement.prototype.selectElement):
2164 * inspector/front-end/WebKit.qrc:
2165 * inspector/front-end/externs.js:
2166 * inspector/front-end/inspector.html:
2167 * inspector/front-end/inspector.js:
2168 (WebInspector.networkResourceById):
2169 * inspector/front-end/utilities.js:
2170 (setupPrototypeUtilities.Element.prototype.selectionLeftOffset):
2171
2172 2011-10-28 Alexander Pavlov <apavlov@chromium.org>
2173
2174 Web Inspector: Using keyboard to increment/decrement units is inconsiste nt
2175 https://bugs.webkit.org/show_bug.cgi?id=71119
2176
2177 Reviewed by Pavel Feldman.
2178
2179 This change makes the behavior consistent with that described at http:// trac.webkit.org/wiki/WebInspector
2180
2181 * inspector/front-end/StylesSidebarPane.js:
2182 (WebInspector.StylesSidebarPane.alteredFloatNumber):
2183 (WebInspector.StylesSidebarPane.prototype._attributesModified):
2184
2185 2011-10-29 Martin Robinson <mrobinson@igalia.com>
2186
2187 [GTK] Switch to a backing store approach for painting WebKitWebView
2188 https://bugs.webkit.org/show_bug.cgi?id=70213
2189
2190 Reviewed by Gustavo Noronha Silva.
2191
2192 No new tests. The changes to WebCore should not change
2193 behavior. The changes in WebKit are covered by existing
2194 tests.
2195
2196 * platform/cairo/WidgetBackingStore.h:
2197 (WebCore::WidgetBackingStore::size): Added this getter for the size.
2198 * platform/cairo/WidgetBackingStoreCairo.cpp:
2199 (WebCore::WidgetBackingStore::WidgetBackingStore): Initialize size.
2200 * platform/graphics/cairo/CairoUtilities.cpp:
2201 (WebCore::copyRectFromCairoSurfaceToContext): Added this new helper.
2202 (WebCore::copyRectFromOneSurfaceToAnother): Use the new helper.
2203 * platform/graphics/cairo/CairoUtilities.h:
2204 * platform/gtk/GtkWidgetBackingStoreX11.cpp:
2205 (WebCore::WidgetBackingStore::WidgetBackingStore): Initialize the size.
2206
2207 2011-10-30 Sheriff Bot <webkit.review.bot@gmail.com>
2208
2209 Unreviewed, rolling out r98803.
2210 http://trac.webkit.org/changeset/98803
2211 https://bugs.webkit.org/show_bug.cgi?id=71186
2212
2213 Causing test and assertion failures on some platforms
2214 (Requested by anttik on #webkit).
2215
2216 * css/CSSStyleSelector.cpp:
2217 (WebCore::CSSStyleSelector::applyMatchedDeclarations):
2218
2219 2011-10-29 Mark Rowe <mrowe@apple.com>
2220
2221 Build fix.
2222
2223 * platform/graphics/mac/WebLayer.mm:
2224 (drawLayerContents):
2225
2226 2011-10-29 Mark Rowe <mrowe@apple.com>
2227
2228 Build fix.
2229
2230 * editing/Editor.cpp:
2231 (WebCore::Editor::markMisspellingsAfterTypingToWord):
2232
2233 2011-10-29 Daniel Cheng <dcheng@chromium.org>
2234
2235 Rename DataTransferItems to DataTransferItemList
2236 https://bugs.webkit.org/show_bug.cgi?id=71151
2237
2238 Per feedback that Items and Item are hard to distinguish between, the HT ML5 spec renamed
2239 DataTransferItems to DataTransferItemList:
2240 http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#the -datatransferitemlist-interface
2241
2242 Reviewed by Tony Chang.
2243
2244 * CMakeLists.txt:
2245 * CodeGenerators.pri:
2246 * DerivedSources.cpp:
2247 * DerivedSources.make:
2248 * GNUmakefile.list.am:
2249 * WebCore.gypi:
2250 * WebCore.pro:
2251 * WebCore.vcproj/WebCore.vcproj:
2252 * WebCore.xcodeproj/project.pbxproj:
2253 * dom/Clipboard.h:
2254 * dom/Clipboard.idl:
2255 * dom/DataTransferItemList.cpp: Renamed from Source/WebCore/dom/DataTran sferItems.cpp.
2256 (WebCore::DataTransferItemList::DataTransferItemList):
2257 (WebCore::DataTransferItemList::length):
2258 (WebCore::DataTransferItemList::item):
2259 (WebCore::DataTransferItemList::deleteItem):
2260 (WebCore::DataTransferItemList::clear):
2261 (WebCore::DataTransferItemList::add):
2262 * dom/DataTransferItemList.h: Renamed from Source/WebCore/dom/DataTransf erItems.h.
2263 (WebCore::DataTransferItemList::~DataTransferItemList):
2264 * dom/DataTransferItemList.idl: Renamed from Source/WebCore/dom/DataTran sferItems.idl.
2265 * platform/chromium/ClipboardChromium.cpp:
2266 (WebCore::ClipboardChromium::items):
2267 * platform/chromium/ClipboardChromium.h:
2268 * platform/chromium/DataTransferItemListChromium.cpp: Renamed from Sourc e/WebCore/platform/chromium/DataTransferItemsChromium.cpp.
2269 (WebCore::DataTransferItemListChromium::create):
2270 (WebCore::DataTransferItemListChromium::DataTransferItemListChromium):
2271 (WebCore::DataTransferItemListChromium::addPasteboardItem):
2272 * platform/chromium/DataTransferItemListChromium.h: Renamed from Source/ WebCore/platform/chromium/DataTransferItemsChromium.h.
2273 * platform/qt/ClipboardQt.cpp:
2274 (WebCore::ClipboardQt::items):
2275 * platform/qt/ClipboardQt.h:
2276 * platform/qt/DataTransferItemListQt.cpp: Renamed from Source/WebCore/pl atform/qt/DataTransferItemsQt.cpp.
2277 (WebCore::DataTransferItemListQt::create):
2278 (WebCore::DataTransferItemListQt::DataTransferItemListQt):
2279 (WebCore::DataTransferItemListQt::addPasteboardItem):
2280 * platform/qt/DataTransferItemListQt.h: Renamed from Source/WebCore/plat form/qt/DataTransferItemsQt.h.
2281
2282 2011-10-03 Robert Hogan <robert@webkit.org>
2283
2284 CSS 2.1 failure: block-non-replaced-width-008.htm
2285 https://bugs.webkit.org/show_bug.cgi?id=69278
2286
2287 Reviewed by Simon Fraser.
2288
2289 * rendering/RenderBox.cpp:
2290 (WebCore::RenderBox::computeLogicalWidthUsing):
2291 Include the margins in the calculation of logical width even when the containing block's
2292 width is zero. This is required by section '10.3.3 Block-level, non-re placed elements in
2293 normal flow' in the CSS 2.1 spec. Tested by block-non-replaced-width-0 08.htm in the CSS
2294 test suite.
2295
2296 2011-10-29 Anna Cavender <annacc@chromium.org>
2297
2298 Make sure TextTracks are destructed if HTMLMediaElement goes away.
2299 https://bugs.webkit.org/show_bug.cgi?id=71148
2300
2301 Reviewed by Eric Carlson.
2302
2303 Test: media/track/track-text-track-destructor-crash.html
2304
2305 * html/HTMLMediaElement.cpp:
2306 (WebCore::HTMLMediaElement::~HTMLMediaElement):
2307 Destroy the client (this) on TextTracks.
2308 (WebCore::HTMLMediaElement::loadTextTracks):
2309 Move TextTrack creation to loadNextTextTrack.
2310 (WebCore::HTMLMediaElement::loadNextTextTrack):
2311 Keep track of new TextTrack in a list.
2312 (WebCore::HTMLMediaElement::addTrack):
2313 Keep track of new TextTrack in a list.
2314 * html/HTMLMediaElement.h:
2315 Add m_textTracks and loadNextTextTrack().
2316
2317 2011-10-29 Jochen Eisinger <jochen@chromium.org>
2318
2319 Implement IDBFactory.deleteDatabase
2320 https://bugs.webkit.org/show_bug.cgi?id=62622
2321
2322 Reviewed by Tony Chang.
2323
2324 Tests: storage/indexeddb/factory-deletedatabase-interactions.html
2325 storage/indexeddb/factory-deletedatabase.html
2326
2327 * storage/IDBBackingStore.h:
2328 * storage/IDBDatabaseBackendImpl.cpp:
2329 (WebCore::IDBDatabaseBackendImpl::PendingDeleteCall::create):
2330 (WebCore::IDBDatabaseBackendImpl::PendingDeleteCall::callbacks):
2331 (WebCore::IDBDatabaseBackendImpl::PendingDeleteCall::PendingDeleteCall):
2332 (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
2333 (WebCore::IDBDatabaseBackendImpl::openInternal):
2334 (WebCore::IDBDatabaseBackendImpl::processPendingCalls):
2335 (WebCore::IDBDatabaseBackendImpl::openConnection):
2336 (WebCore::IDBDatabaseBackendImpl::deleteDatabase):
2337 * storage/IDBDatabaseBackendImpl.h:
2338 * storage/IDBFactory.cpp:
2339 (WebCore::IDBFactory::deleteDatabase):
2340 * storage/IDBFactory.h:
2341 * storage/IDBFactory.idl:
2342 * storage/IDBFactoryBackendImpl.cpp:
2343 (WebCore::IDBFactoryBackendImpl::deleteDatabase):
2344 * storage/IDBFactoryBackendImpl.h:
2345 * storage/IDBFactoryBackendInterface.h:
2346 * storage/IDBLevelDBBackingStore.cpp:
2347 (WebCore::deleteRange):
2348 (WebCore::IDBLevelDBBackingStore::deleteDatabase):
2349 * storage/IDBLevelDBBackingStore.h:
2350 * storage/IDBRequest.cpp:
2351 (WebCore::IDBRequest::dispatchEvent):
2352
2353 2011-10-28 Robert Hogan <robert@webkit.org>
2354
2355 CSS 2.1 failure: dynamic-top-change-001 to 004 fail
2356 https://bugs.webkit.org/show_bug.cgi?id=68149
2357
2358 Reviewed by David Hyatt.
2359
2360 In these tests a child inherits its top value from its parent and the pa rent's top value
2361 is later updated by an onload event. The updated value is expected to ca scade to the child.
2362
2363 The tests were failing because updating the value did not cascade immedi ately to the child inheriting it, though
2364 it could be forced eventually with a full recalculation of the RenderSty le by changing the zoom factor
2365 or opening the inspector.
2366
2367 The fix is to let the parent RenderStyle know that a child inherits a pr operty explicitly and
2368 recalculate children's style if the parent ever changes. This only happe ns if the property is inherited
2369 explicitly, it does not apply to cases where the property is inherited b y default.
2370
2371 * css/CSSStyleSelector.cpp:
2372 (WebCore::CSSStyleSelector::applyProperty):
2373 * dom/Node.cpp:
2374 (WebCore::Node::diff):
2375 * rendering/style/RenderStyle.cpp:
2376 (WebCore::RenderStyle::RenderStyle):
2377 * rendering/style/RenderStyle.h:
2378 (WebCore::InheritedFlags::setHasExplicitlyInheritedProperties):
2379 (WebCore::InheritedFlags::hasExplicitlyInheritedProperties):
2380
2381 2011-10-29 Antti Koivisto <antti@apple.com>
2382
2383 Tighten font change conditions in matched declaration cache
2384 https://bugs.webkit.org/show_bug.cgi?id=71026
2385
2386 Reviewed by Darin Adler.
2387
2388 We currently test if font description has changed to see if all properti es need to be applied. However
2389 only a few size related metrics can actually affect other properties. We can just test those, making
2390 the cache somewhat more effective while also making the equality test fa ster.
2391
2392 * css/CSSStyleSelector.cpp:
2393 (WebCore::fontDifferenceAffectsNonInherited):
2394 (WebCore::CSSStyleSelector::applyMatchedDeclarations):
2395
2396 Test for text computedSize, xHeight and orientation only. Other text properties don't affect computed
2397 values of non-text CSS properties.
2398
2399 2011-10-29 Adam Barth <abarth@webkit.org>
2400
2401 DOMURL should keep its own state rather than storing it on ScriptExecuti onContext
2402 https://bugs.webkit.org/show_bug.cgi?id=71169
2403
2404 Reviewed by Eric Seidel.
2405
2406 This patch untwists this code. I think this code was originally
2407 twisted because these APIs moved onto DOMURL after they were first
2408 implemented.
2409
2410 * dom/ScriptExecutionContext.cpp:
2411 (WebCore::ScriptExecutionContext::~ScriptExecutionContext):
2412 * dom/ScriptExecutionContext.h:
2413 * fileapi/FileWriter.h:
2414 * html/DOMURL.cpp:
2415 (WebCore::DOMURL::contextDestroyed):
2416 (WebCore::DOMURL::createObjectURL):
2417 (WebCore::DOMURL::revokeObjectURL):
2418 * html/DOMURL.h:
2419
2420 2011-10-29 Sheriff Bot <webkit.review.bot@gmail.com>
2421
2422 Unreviewed, rolling out r98795.
2423 http://trac.webkit.org/changeset/98795
2424 https://bugs.webkit.org/show_bug.cgi?id=71171
2425
2426 Causes worker tests to crash (Requested by abarth on #webkit).
2427
2428 * dom/ActiveDOMObject.cpp:
2429 (WebCore::ContextDestructionObserver::contextDestroyed):
2430 * dom/MessagePort.cpp:
2431 (WebCore::MessagePort::MessagePort):
2432 (WebCore::MessagePort::contextDestroyed):
2433 * dom/MessagePort.h:
2434 * dom/ScriptExecutionContext.cpp:
2435 (WebCore::ScriptExecutionContext::~ScriptExecutionContext):
2436 (WebCore::ScriptExecutionContext::closeMessagePorts):
2437
2438 2011-10-28 Ryosuke Niwa <rniwa@webkit.org>
2439
2440 Potential crash in ReplaceNodeWithSpanCommand
2441 https://bugs.webkit.org/show_bug.cgi?id=71145
2442
2443 Reviewed by Ojan Vafai.
2444
2445 Fix a potential crash without tests because we don't have a reduction.
2446
2447 * editing/ReplaceNodeWithSpanCommand.cpp:
2448 (WebCore::swapInNodePreservingAttributesAndChildren):
2449
2450 2011-10-28 Adam Barth <abarth@webkit.org>
2451
2452 MessagePort should be a ContextDestructionObserver
2453 https://bugs.webkit.org/show_bug.cgi?id=71167
2454
2455 Reviewed by Eric Seidel.
2456
2457 I couldn't quite get rid of all the uses of the
2458 ScriptExecutionContext::m_messagePorts in this patch. I hope to get
2459 rid of them in the future as the "extra data" design for
2460 ScriptExecutionContext emerges.
2461
2462 * dom/ActiveDOMObject.cpp:
2463 (WebCore::ContextDestructionObserver::contextDestroyed):
2464 * dom/MessagePort.cpp:
2465 (WebCore::MessagePort::MessagePort):
2466 (WebCore::MessagePort::contextDestroyed):
2467 * dom/MessagePort.h:
2468 * dom/ScriptExecutionContext.cpp:
2469 (WebCore::ScriptExecutionContext::~ScriptExecutionContext):
2470 (WebCore::ScriptExecutionContext::closeMessagePorts):
2471
2472 2011-10-28 Ryosuke Niwa <rniwa@webkit.org>
2473
2474 The copy and paste result in nested scrollbars on http://dojotoolkit.org /widgets
2475 https://bugs.webkit.org/show_bug.cgi?id=70799
2476
2477 Reviewed by Enrica Casucci.
2478
2479 The bug was caused by WebKit's treating a fully selected root with backg round property as a special common ancestor.
2480 A variant of this bug was caused by treating any element with text-decor ation property as a presentational element.
2481
2482 Fixed the above two bugs by not serializing the said nodes. The effectiv e background color was already serialized
2483 by wrappingStyleForSerialization, there was nothing to be done besides s top including it in highestAncestorToWrapMarkup.
2484
2485 For text-decoration property, added the logic to compute the effective v alue in EditingStyle::init. Also treat it
2486 as a non-inheritable editing property so that the rest of EditingStyle j ust works.
2487
2488 Test: editing/pasteboard/avoid-copying-body-with-background.html
2489
2490 * editing/EditingStyle.cpp: Added CSSPropertyTextDecoration to the list of editing properties.
2491 (WebCore::copyEditingProperties):
2492 (WebCore::EditingStyle::init): Compute the effective text decoration whe n propertiesToInclude is
2493 EditingPropertiesInEffect.
2494 (WebCore::EditingStyle::prepareToApplyAt):
2495 (WebCore::EditingStyle::mergeInlineStyleOfElement):
2496 (WebCore::EditingStyle::wrappingStyleForSerialization):
2497 (WebCore::EditingStyle::removeStyleFromRulesAndContext):
2498 * editing/EditingStyle.h: Renamed EditingInheritablePropertiesAndBackgro undColorInEffect to
2499 EditingPropertiesInEffect.
2500 * editing/markup.cpp:
2501 (WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag): Removed an a ssertion that's no longer valid.
2502 (WebCore::isElementPresentational): Don't consider an element with text- decoration as a presentational element.
2503 (WebCore::highestAncestorToWrapMarkup): Don't consider fully selected ro ot as a special common ancestor ever.
2504 Background color is computed property when we compute the wrapping style .
2505 (WebCore::createMarkup):
2506
2507 2011-10-28 Adam Barth <abarth@webkit.org>
2508
2509 Rename ExceptionCodeDescription.in to DOMExceptions.in
2510 https://bugs.webkit.org/show_bug.cgi?id=71157
2511
2512 Reviewed by Eric Seidel.
2513
2514 This file is now used for more than just the descriptions of the excepti ons.
2515
2516 * CMakeLists.txt:
2517 * CodeGenerators.pri:
2518 * DerivedSources.make:
2519 * GNUmakefile.am:
2520 * WebCore.gyp/WebCore.gyp:
2521 * WebCore.gyp/scripts/action_makenames.py:
2522 * dom/DOMExceptions.in: Copied from Source/WebCore/dom/ExceptionCodeDesc ription.in.
2523 * dom/ExceptionCodeDescription.in: Removed.
2524 * dom/make_dom_exceptions.pl: Copied from Source/WebCore/dom/make_except ion_code_description.pl.
2525 * dom/make_exception_code_description.pl: Removed.
2526
2527 2011-10-28 Chris Rogers <crogers@google.com>
2528
2529 SincResampler must be able to resample progressively
2530 https://bugs.webkit.org/show_bug.cgi?id=71131
2531
2532 Reviewed by Kenneth Russell.
2533
2534 No new tests. There is not yet an implementation using progressive resa mpling to test.
2535
2536 * platform/audio/SincResampler.cpp:
2537 (WebCore::SincResampler::SincResampler):
2538 (WebCore::SincResampler::consumeSource):
2539 (WebCore::SincResampler::process):
2540 * platform/audio/SincResampler.h:
2541
2542 2011-10-28 Adam Klein <adamk@chromium.org>
2543
2544 [MutationObservers] Support attributeOldValue for attribute mutations
2545 https://bugs.webkit.org/show_bug.cgi?id=70861
2546
2547 Reviewed by Ryosuke Niwa.
2548
2549 Respect 'attributeOldValue' when passed to WebKitMutationObserver.observ e().
2550
2551 If multiple observers have different attributeOldValue settings in
2552 their registrations, two different MutationRecords are created (one is
2553 a wrapper around the other).
2554
2555 If a single observer has multiple registrations that apply to a single
2556 mutation, and those registrations have different values for
2557 attributeOldValue, the observer is passed the oldValue.
2558
2559 * dom/Element.cpp:
2560 (WebCore::hasOldValue):
2561 (WebCore::enqueueAttributesMutationRecord):
2562 (WebCore::Element::setAttribute):
2563 * dom/MutationRecord.cpp:
2564 (WebCore::MutationRecord::createAttributes):
2565 (WebCore::MutationRecord::createWithNullOldValue):
2566 * dom/MutationRecord.h:
2567 (WebCore::MutationRecord::oldValue):
2568
2569 2011-10-28 Adam Barth <abarth@webkit.org>
2570
2571 Delete ExceptionCode.cpp, which is empty
2572 https://bugs.webkit.org/show_bug.cgi?id=71159
2573
2574 Reviewed by Eric Seidel.
2575
2576 This file has been stripped down to nothing and can be removed.
2577
2578 * CMakeLists.txt:
2579 * GNUmakefile.list.am:
2580 * WebCore.gypi:
2581 * WebCore.pro:
2582 * WebCore.vcproj/WebCore.vcproj:
2583 * WebCore.xcodeproj/project.pbxproj:
2584 * dom/DOMAllInOne.cpp:
2585 * dom/ExceptionCode.cpp: Removed.
2586
2587 2011-10-28 Sheriff Bot <webkit.review.bot@gmail.com>
2588
2589 Unreviewed, rolling out r98776.
2590 http://trac.webkit.org/changeset/98776
2591 https://bugs.webkit.org/show_bug.cgi?id=71164
2592
2593 caused lots of test crashes (Requested by smfr on #webkit).
2594
2595 * rendering/RenderLayer.cpp:
2596 (WebCore::RenderLayer::updateVisibilityStatus):
2597 (WebCore::RenderLayer::dirtyZOrderLists):
2598 * rendering/RenderLayer.h:
2599 * rendering/RenderLayerCompositor.cpp:
2600 (WebCore::RenderLayerCompositor::enableCompositingMode):
2601
2602 2011-10-28 John Sullivan <sullivan@apple.com>
2603
2604 Improvement to the fix for:
2605 https://bugs.webkit.org/show_bug.cgi?id=71142
2606 Whether backspace goes Back should be configurable
2607
2608 Reviewed by Dan Bernstein.
2609
2610 * page/EventHandler.cpp:
2611 (WebCore::EventHandler::defaultBackspaceEventHandler):
2612 Do the frame->settings() check after the !page check, since
2613 a null page means null settings.
2614
2615 2011-10-28 Adam Barth <abarth@webkit.org>
2616
2617 Make DOMURL a ContextDestructionObserver
2618 https://bugs.webkit.org/show_bug.cgi?id=71162
2619
2620 Reviewed by Eric Seidel.
2621
2622 This removes a bunch of hand-rolled ifdefed code.
2623
2624 * dom/ActiveDOMObject.h:
2625 - One-argument constructors should be explicit.
2626 * dom/ScriptExecutionContext.cpp:
2627 (WebCore::ScriptExecutionContext::~ScriptExecutionContext):
2628 * dom/ScriptExecutionContext.h:
2629 * html/DOMURL.cpp:
2630 (WebCore::DOMURL::DOMURL):
2631 (WebCore::DOMURL::~DOMURL):
2632 * html/DOMURL.h:
2633
2634 2011-10-28 Adam Barth <abarth@webkit.org>
2635
2636 Factor ContextDestructionObserver out of ActiveDOMObject
2637 https://bugs.webkit.org/show_bug.cgi?id=71153
2638
2639 Reviewed by Sam Weinig.
2640
2641 This patch paves the way to make more objects observe the destruction
2642 of ScriptExecutioContext without needing to add ifdefs to
2643 ScriptExecutionContext.h/cpp. (As an example, see DOMURL.)
2644
2645 * dom/ActiveDOMObject.cpp:
2646 (WebCore::ContextDestructionObserver::ContextDestructionObserver):
2647 (WebCore::ContextDestructionObserver::~ContextDestructionObserver):
2648 (WebCore::ContextDestructionObserver::contextDestroyed):
2649 (WebCore::ActiveDOMObject::ActiveDOMObject):
2650 (WebCore::ActiveDOMObject::~ActiveDOMObject):
2651 * dom/ActiveDOMObject.h:
2652 (WebCore::ContextDestructionObserver::scriptExecutionContext):
2653 * dom/ScriptExecutionContext.cpp:
2654 (WebCore::ScriptExecutionContext::~ScriptExecutionContext):
2655 (WebCore::ScriptExecutionContext::didCreateActiveDOMObject):
2656 (WebCore::ScriptExecutionContext::willDestroyActiveDOMObject):
2657 (WebCore::didCreateDestructionObserver):
2658 (WebCore::willDestroyDestructionObserver):
2659 * dom/ScriptExecutionContext.h:
2660
2661 2011-10-28 Tim Horton <timothy_horton@apple.com>
2662
2663 One more unreviewed build fix due to r98775.
2664
2665 No new tests.
2666
2667 * WebCore.vcproj/WebCore.vcproj:
2668
2669 2011-10-28 James Robinson <jamesr@chromium.org>
2670
2671 [chromium] Track wheel event handler registration and pass to input filt er
2672 https://bugs.webkit.org/show_bug.cgi?id=71078
2673
2674 Reviewed by Kenneth Russell.
2675
2676 This propagates mouse wheel registration notifications to the compositor input filter. If there are any handlers
2677 registered, which includes JS handlers and scrollable areas other than t he main view, the input filter will pass
2678 mouse wheel events to the widget. Otherwise when threaded compositing is enabled the input filter translates
2679 wheel events into root layer scrolling.
2680
2681 Only changes behavior with an off-by-default flag enabled, so no tests.
2682
2683 * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
2684 (WebCore::CCLayerTreeHost::CCLayerTreeHost):
2685 (WebCore::CCLayerTreeHost::finishCommitOnImplThread):
2686 (WebCore::CCLayerTreeHost::setHaveWheelEventHandlers):
2687 * platform/graphics/chromium/cc/CCLayerTreeHost.h:
2688 * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
2689 (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
2690 (WebCore::CCLayerTreeHostImpl::haveWheelEventHandlers):
2691 * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
2692 (WebCore::CCLayerTreeHostImpl::setHaveWheelEventHandlers):
2693 * platform/graphics/chromium/cc/CCScrollController.h:
2694
2695 2011-10-28 Tim Horton <timothy_horton@apple.com>
2696
2697 Unreviewed build fix due to r98775.
2698
2699 No new tests.
2700
2701 * CMakeLists.txt:
2702 * GNUmakefile.list.am:
2703 * WebCore.gypi:
2704 * WebCore.pro:
2705
2706 2011-10-28 Simon Fraser <simon.fraser@apple.com>
2707
2708 If visibility changes while an accelerated animation is running, element jumps around
2709 https://bugs.webkit.org/show_bug.cgi?id=29984
2710
2711 Reviewed by Chris Marrin.
2712
2713 Compositing now affects whether RenderLayers for visibility:hidden eleme nts
2714 are included in z-order lists. So we have to dirty those lists when we e nter
2715 compopsiting mode.
2716
2717 Test: compositing/visibility/animation-visibility.html
2718
2719 * rendering/RenderLayer.cpp:
2720 (WebCore::RenderLayer::updateVisibilityStatus): Removed trailing whitesp ace.
2721 (WebCore::RenderLayer::dirtyZOrderLists): Call dirtyZOrderListsInternal( ), which doesn't have
2722 to ping the compositor.
2723 (WebCore::RenderLayer::dirtyZOrderListsInternal):
2724 (WebCore::RenderLayer::dirtyZOrderListsIncludingDescendants): Recursivel y dirty z-order
2725 lists.
2726 * rendering/RenderLayer.h:
2727 * rendering/RenderLayerCompositor.cpp:
2728 (WebCore::RenderLayerCompositor::enableCompositingMode): When going into compositing mode,
2729 dirty all z-order lists.
2730
2731 2011-10-28 Tim Horton <timothy_horton@apple.com>
2732
2733 Implement CSS3 Images cross-fade() image function
2734 https://bugs.webkit.org/show_bug.cgi?id=52162
2735 <rdar://problem/10209254>
2736
2737 Reviewed by Simon Fraser.
2738
2739 Parse -webkit-cross-fade according to the CSS3 Images Values specificati on.
2740
2741 Also, adjust other CSS parsing functions to support nested functions, by using a specific CSS value list
2742 instead of the global one. This allows - for example - cross-fade to pas s each of its arguments back into
2743 parseFillImage and to successfully parse image functions in this fashion .
2744
2745 Test: fast/css/getComputedStyle/computed-style-cross-fade.html
2746
2747 * WebCore.xcodeproj/project.pbxproj:
2748 * css/CSSCrossfadeValue.cpp: Added.
2749 (WebCore::CSSCrossfadeValue::~CSSCrossfadeValue):
2750 (WebCore::CSSCrossfadeValue::cssText):
2751 (WebCore::CSSCrossfadeValue::fixedSize):
2752 (WebCore::CSSCrossfadeValue::image):
2753 * css/CSSCrossfadeValue.h: Added.
2754 (WebCore::CSSCrossfadeValue::create):
2755 (WebCore::CSSCrossfadeValue::isFixedSize):
2756 (WebCore::CSSCrossfadeValue::setFromImage):
2757 (WebCore::CSSCrossfadeValue::setToImage):
2758 (WebCore::CSSCrossfadeValue::setPercentage):
2759 (WebCore::CSSCrossfadeValue::CSSCrossfadeValue):
2760 * css/CSSParser.cpp:
2761 (WebCore::CSSParser::parseValue):
2762 (WebCore::CSSParser::parseContent):
2763 (WebCore::CSSParser::parseFillImage):
2764 (WebCore::CSSParser::parseFillProperty):
2765 (WebCore::CSSParser::parseBorderImage):
2766 (WebCore::CSSParser::parseDeprecatedGradient):
2767 (WebCore::CSSParser::parseLinearGradient):
2768 (WebCore::CSSParser::parseRadialGradient):
2769 (WebCore::CSSParser::isGeneratedImageValue):
2770 (WebCore::CSSParser::parseGeneratedImage):
2771 (WebCore::CSSParser::parseCrossfade):
2772 (WebCore::CSSParser::parseCanvas):
2773 * css/CSSParser.h:
2774
2775 2011-10-28 Dan Bernstein <mitz@apple.com>
2776
2777 Attempted build fix after r98765.
2778
2779 * platform/graphics/mac/SimpleFontDataMac.mm:
2780 (WebCore::SimpleFontData::platformWidthForGlyph):
2781
2782 2011-10-28 Chris Marrin <cmarrin@apple.com>
2783
2784 CSS grammar doesn't support functions with no parameters
2785 https://bugs.webkit.org/show_bug.cgi?id=69110
2786
2787 Reviewed by Dean Jackson.
2788
2789 Add rule to grammar to accept functions with 0 args and return
2790 this case with a CSSParserValueList with 0 values. Also fixed
2791 filter creation function to properly handle filters with 0
2792 arguments.
2793
2794 * css/CSSGrammar.y:
2795 * css/CSSStyleSelector.cpp:
2796 (WebCore::CSSStyleSelector::createFilterOperations):
2797
2798 2011-10-28 Sheriff Bot <webkit.review.bot@gmail.com>
2799
2800 Unreviewed, rolling out r98757.
2801 http://trac.webkit.org/changeset/98757
2802 https://bugs.webkit.org/show_bug.cgi?id=71150
2803
2804 crashes webkit_unit_tests on chromium windows (Requested by
2805 johnny_g on #webkit).
2806
2807 * platform/graphics/chromium/LayerRendererChromium.cpp:
2808 (WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
2809 * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
2810 (WebCore::CCLayerTreeHost::paintLayerContents):
2811 (WebCore::CCLayerTreeHost::updateCompositorResources):
2812 * platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
2813 (WebCore::calculateDrawTransformsAndVisibilityInternal):
2814
2815 2011-10-28 Adam Barth <abarth@webkit.org>
2816
2817 Rubber-stamped by Eric Seidel.
2818
2819 Fix namespace indent in ScriptExecutionContext.h.
2820
2821 * dom/ScriptExecutionContext.h:
2822 (WebCore::ScriptExecutionContext::isDocument):
2823 (WebCore::ScriptExecutionContext::isWorkerContext):
2824 (WebCore::ScriptExecutionContext::setHasOpenDatabases):
2825 (WebCore::ScriptExecutionContext::hasOpenDatabases):
2826 (WebCore::ScriptExecutionContext::url):
2827 (WebCore::ScriptExecutionContext::completeURL):
2828 (WebCore::ScriptExecutionContext::securityOrigin):
2829 (WebCore::ScriptExecutionContext::contentSecurityPolicy):
2830 (WebCore::ScriptExecutionContext::activeDOMObjects):
2831 (WebCore::ScriptExecutionContext::suspendScriptedAnimationControllerCall backs):
2832 (WebCore::ScriptExecutionContext::resumeScriptedAnimationControllerCallb acks):
2833 (WebCore::ScriptExecutionContext::messagePorts):
2834 (WebCore::ScriptExecutionContext::domUrls):
2835 (WebCore::ScriptExecutionContext::ref):
2836 (WebCore::ScriptExecutionContext::deref):
2837 (WebCore::ScriptExecutionContext::Task::Task):
2838 (WebCore::ScriptExecutionContext::Task::isCleanupTask):
2839
2840 2011-10-28 John Sullivan <sullivan@apple.com>
2841
2842 WebCore part of:
2843 https://bugs.webkit.org/show_bug.cgi?id=71142
2844 Whether backspace goes Back should be configurable
2845
2846 Reviewed by Sam Weinig.
2847
2848 * page/EventHandler.cpp:
2849 (WebCore::EventHandler::defaultBackspaceEventHandler):
2850 Bail out if backspace navigation is not enabled.
2851
2852 * page/Settings.cpp:
2853 (WebCore::Settings::Settings):
2854 Initialize m_backspaceKeyNavigationEnabled to true to match current beha vior.
2855
2856 * page/Settings.h:
2857 Declared m_backspaceKeyNavigationEnabled.
2858 (WebCore::Settings::setBackspaceKeyNavigationEnabled):
2859 New function, simple setter.
2860 (WebCore::Settings::backspaceKeyNavigationEnabled):
2861 New function, simple getter.
2862
2863 2011-10-28 Emil A Eklund <eae@chromium.org>
2864
2865 Overridden clippedOverflowRectForRepaint() still uses IntRects
2866 https://bugs.webkit.org/show_bug.cgi?id=71046
2867
2868 Reviewed by Simon Fraser.
2869
2870 Change all virtual clippedOverflowRectForRepaint functions to use the
2871 same signature.
2872
2873 No new tests.
2874
2875 * rendering/RenderObject.cpp:
2876 (WebCore::RenderObject::rectWithOutlineForRepaint):
2877 (WebCore::RenderObject::clippedOverflowRectForRepaint):
2878 * rendering/RenderObject.h:
2879 * rendering/RenderReplaced.cpp:
2880 (WebCore::RenderReplaced::clippedOverflowRectForRepaint):
2881 * rendering/RenderReplaced.h:
2882 * rendering/RenderTableCell.cpp:
2883 (WebCore::RenderTableCell::clippedOverflowRectForRepaint):
2884 * rendering/RenderTableCell.h:
2885 * rendering/RenderTableCol.cpp:
2886 (WebCore::RenderTableCol::clippedOverflowRectForRepaint):
2887 * rendering/RenderTableCol.h:
2888 * rendering/RenderTableRow.cpp:
2889 (WebCore::RenderTableRow::clippedOverflowRectForRepaint):
2890 * rendering/RenderTableRow.h:
2891 * rendering/RenderText.cpp:
2892 (WebCore::RenderText::clippedOverflowRectForRepaint):
2893 * rendering/RenderText.h:
2894
2895 2011-10-28 Adam Klein <adamk@chromium.org>
2896
2897 Remove unused parsers for 'exception' and 'alias' IDL keywords
2898 https://bugs.webkit.org/show_bug.cgi?id=71140
2899
2900 Reviewed by Adam Barth.
2901
2902 * bindings/scripts/IDLParser.pm:
2903 (ParseInterface):
2904 (DetermineParseMode):
2905 (ProcessSection):
2906 * bindings/scripts/IDLStructure.pm:
2907
2908 2011-10-28 Dan Bernstein <mitz@apple.com>
2909
2910 <rdar://problem/10288006> Emoji characters are too close to each other i n small font size
2911
2912 Reviewed by Sam Weinig.
2913
2914 * platform/graphics/mac/SimpleFontDataMac.mm:
2915 (WebCore::SimpleFontData::platformWidthForGlyph): If the font is a color bitmap font, use
2916 -[NSFont advancementForGlyph:] instead of wkGetGlyphTransformedAdvances( ).
2917
2918 2011-10-28 Adam Barth <abarth@webkit.org>
2919
2920 Remove unused default constructor
2921 https://bugs.webkit.org/show_bug.cgi?id=71136
2922
2923 Reviewed by Eric Seidel.
2924
2925 No one is calling this constructor anymore now that we've fixed the
2926 callers.
2927
2928 * dom/make_exception_code_description.pl:
2929 (generateHeader):
2930
2931 2011-10-28 Ken Buchanan <kenrb@chromium.org>
2932
2933 Crash when splitting inline flows with generated floats
2934 https://bugs.webkit.org/show_bug.cgi?id=70458
2935
2936 Reviewed by David Hyatt.
2937
2938 When lineBoxes on a RenderBlock are being deleted, we now check the floa ting object list to
2939 ensure references to them are being cleared.
2940
2941 * rendering/RenderBlock.cpp:
2942 (WebCore::RenderBlock::deleteLineBoxTree): Remove references to lineBox when deleting them
2943
2944 2011-10-28 Simon Fraser <simon.fraser@apple.com>
2945
2946 Remove Leopard-only code from GraphicsLayerCA
2947 https://bugs.webkit.org/show_bug.cgi?id=71141
2948
2949 Reviewed by Chris Marrin.
2950
2951 Remove !HAVE_MODERN_QUARTZCORE code, which was only
2952 used on Leopard. updateContentsTransform() became a no-op,
2953 so could be removed.
2954
2955 * platform/graphics/ca/GraphicsLayerCA.cpp:
2956 (WebCore::getValueFunctionNameForTransformOperation):
2957 (WebCore::GraphicsLayerCA::GraphicsLayerCA):
2958 (WebCore::GraphicsLayerCA::addAnimation):
2959 (WebCore::GraphicsLayerCA::updateGeometry):
2960 (WebCore::GraphicsLayerCA::setTransformAnimationEndpoints):
2961 (WebCore::GraphicsLayerCA::setTransformAnimationKeyframes):
2962 (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
2963 (WebCore::GraphicsLayerCA::defaultContentsOrientation):
2964 (WebCore::GraphicsLayerCA::updateOpacityOnLayer):
2965 * platform/graphics/ca/GraphicsLayerCA.h:
2966
2967 2011-10-28 Adrienne Walker <enne@google.com>
2968
2969 [chromium] Implicitly skip render surfaces that won't be drawn
2970 https://bugs.webkit.org/show_bug.cgi?id=71038
2971
2972 Rather than having redundant checks in three places for how to walk
2973 through a render surface list, instead don't add render surfaces that
2974 don't need to get rendered to the render surface list.
2975
2976 Reviewed by James Robinson.
2977
2978 Covered by existing layout tests.
2979
2980 * platform/graphics/chromium/LayerRendererChromium.cpp:
2981 (WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
2982 * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
2983 (WebCore::CCLayerTreeHost::paintLayerContents):
2984 (WebCore::CCLayerTreeHost::updateCompositorResources):
2985 * platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
2986 (WebCore::calculateDrawTransformsAndVisibilityInternal):
2987
2988 2011-10-28 Adam Barth <abarth@webkit.org>
2989
2990 Autogenerate Exception-downcast code in bindings
2991 https://bugs.webkit.org/show_bug.cgi?id=71108
2992
2993 Reviewed by Eric Seidel.
2994
2995 This patch uses the same generated code style as we're using for Events
2996 to generate the downcasts for the Exception types in the bindings.
2997 This cause me to refactor more code from make_event_factory.pl into
2998 InFilesCompiler.pm.
2999
3000 After this patch, some of these files and scripts are misnamed. I'll
3001 rename them in a followup patch.
3002
3003 * DerivedSources.make:
3004 * GNUmakefile.am:
3005 * GNUmakefile.list.am:
3006 * WebCore.gyp/WebCore.gyp:
3007 * WebCore.gypi:
3008 * WebCore.vcproj/WebCore.vcproj:
3009 * WebCore.xcodeproj/project.pbxproj:
3010 * bindings/js/JSDOMBinding.cpp:
3011 (WebCore::setDOMException):
3012 * bindings/objc/ExceptionHandlers.mm:
3013 (WebCore::raiseDOMException):
3014 * bindings/scripts/InFilesCompiler.pm:
3015 (initializeFromCommandLine):
3016 (compile):
3017 (interfaceForItem):
3018 (toMacroStyle):
3019 (generateInterfacesHeader):
3020 (generateHeadersHeader):
3021 * bindings/v8/V8Proxy.cpp:
3022 (WebCore::V8Proxy::setDOMException):
3023 * dom/ExceptionCodeDescription.in:
3024 * dom/make_event_factory.pl:
3025 (generateCode):
3026 (generateImplementation):
3027 * dom/make_exception_code_description.pl:
3028 (defaultItemFactory):
3029 (generateCode):
3030
3031 2011-10-28 Simon Fraser <simon.fraser@apple.com>
3032
3033 Fix builds which have ACCELERATED_COMPOSITING disabled.
3034
3035 * rendering/RenderLayer.cpp:
3036 (WebCore::RenderLayer::updateZOrderLists):
3037
3038 2011-10-28 Erik Arvidsson <arv@chromium.org>
3039
3040 Remove LegacyDefaultOptionalArguments flag from inspector IDLs
3041 https://bugs.webkit.org/show_bug.cgi?id=65748
3042
3043 Reviewed by Adam Barth.
3044
3045 Covered by existing tests.
3046
3047 * inspector/InjectedScriptHost.idl:
3048 * inspector/InspectorFrontendHost.idl:
3049 * inspector/JavaScriptCallFrame.idl:
3050
3051 2011-10-28 Joshua Bell <jsbell@chromium.org>
3052
3053 IndexedDB: Database metadata changes should be tied to transaction
3054 https://bugs.webkit.org/show_bug.cgi?id=70974
3055
3056 Reviewed by Tony Chang.
3057
3058 Database metadata (that is, the version string) was rolled back
3059 on abort by an abort task. If the abort task didn't run e.g.
3060 due to a crash, the metadata would not be reverted. All of the
3061 other store/index/data changes were written into the transaction
3062 itself, so the metadata now is too. Refactored the metadata
3063 get/create/update methods for clarity as well.
3064
3065 Note that the new tests don't actually verify that the code handles
3066 this case; that will need to be done with persistence tests
3067 that span multiple runs of the browser and induce crashes.
3068 The new tests do verify that these changes don't cause regressions
3069 not caught by other tests.
3070
3071 Tests: storage/indexeddb/open-during-transaction.html
3072 storage/indexeddb/version-change-abort.html
3073
3074 * storage/IDBBackingStore.h:
3075 * storage/IDBDatabaseBackendImpl.cpp:
3076 (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
3077 (WebCore::IDBDatabaseBackendImpl::setVersionInternal):
3078 * storage/IDBLevelDBBackingStore.cpp:
3079 (WebCore::IDBLevelDBBackingStore::getIDBDatabaseMetaData):
3080 (WebCore::IDBLevelDBBackingStore::createIDBDatabaseMetaData):
3081 (WebCore::IDBLevelDBBackingStore::updateIDBDatabaseMetaData):
3082 * storage/IDBLevelDBBackingStore.h:
3083
3084 2011-10-28 Luke Macpherson <macpherson@chromium.org>
3085
3086 Use enum instead of bool to represent -webkit-column-span property.
3087 https://bugs.webkit.org/show_bug.cgi?id=70867
3088
3089 Reviewed by Darin Adler.
3090
3091 Covered by existing tests.
3092
3093 * css/CSSPrimitiveValueMappings.h:
3094 (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
3095 (WebCore::CSSPrimitiveValue::operator ColumnSpan):
3096 * css/CSSStyleSelector.cpp:
3097 (WebCore::CSSStyleSelector::applyProperty):
3098 * rendering/RenderBlock.cpp:
3099 (WebCore::RenderBlock::createAnonymousColumnSpanBlock):
3100 * rendering/RenderObject.cpp:
3101 (WebCore::RenderObject::propagateStyleToAnonymousChildren):
3102 * rendering/style/RenderStyle.h:
3103 (WebCore::InheritedFlags::columnSpan):
3104 (WebCore::InheritedFlags::setColumnSpan):
3105 (WebCore::InheritedFlags::initialColumnSpan):
3106 * rendering/style/RenderStyleConstants.h:
3107 * rendering/style/StyleMultiColData.h:
3108
3109 2011-10-28 Mark Hahnenberg <mhahnenberg@apple.com>
3110
3111 De-virtualize isGlobalObject, isVariableObject, isActivationObject, and isErrorInstance in JSObject
3112 https://bugs.webkit.org/show_bug.cgi?id=70968
3113
3114 Reviewed by Geoffrey Garen.
3115
3116 No new tests.
3117
3118 * bindings/js/JSDOMGlobalObject.h: Changed JSType provided to TypeInfo i n createStructure since this
3119 class inherits from JSGlobalObject.
3120 (WebCore::JSDOMGlobalObject::createStructure):
3121 * bindings/js/JSDOMWindowBase.h: Ditto
3122 (WebCore::JSDOMWindowBase::createStructure):
3123 * bindings/js/JSWorkerContextBase.h: Ditto
3124 (WebCore::JSWorkerContextBase::createStructure):
3125 * bindings/scripts/CodeGeneratorJS.pm: Added extra check to make sure su bclasses of JSGlobalObject,
3126 namely JSDOMWindow and JSWorkerContext, get their special JSType in thei r createStructure function.
3127 (GenerateHeader):
3128
3129 2011-10-28 Sheriff Bot <webkit.review.bot@gmail.com>
3130
3131 Unreviewed, rolling out r98736.
3132 http://trac.webkit.org/changeset/98736
3133 https://bugs.webkit.org/show_bug.cgi?id=71125
3134
3135 This patch broke perf/array-binary-search.html test (Requested
3136 by annacc on #webkit).
3137
3138 * html/HTMLMediaElement.cpp:
3139 (WebCore::HTMLMediaElement::loadTextTracks):
3140 (WebCore::HTMLMediaElement::addTrack):
3141 * html/HTMLMediaElement.h:
3142 * html/HTMLTrackElement.cpp:
3143 (WebCore::HTMLTrackElement::insertedIntoTree):
3144 (WebCore::HTMLTrackElement::willRemove):
3145 * html/HTMLTrackElement.h:
3146 * html/LoadableTextTrack.cpp:
3147 (WebCore::LoadableTextTrack::cueLoadingCompleted):
3148
3149 2011-10-28 Julien Chaffraix <jchaffraix@webkit.org>
3150
3151 RenderTableSection::recalcCells should not free its grid
3152 https://bugs.webkit.org/show_bug.cgi?id=71056
3153
3154 Reviewed by Darin Adler.
3155
3156 Refactoring only, no change in behavior.
3157
3158 r98614 had the bad side effect of clearing the row vector (m_grid) on
3159 the RenderTableSection when doing a recalcCells. This change removes the
3160 unneeded free and inline the |row| field into the RowStruct as it made
3161 no sense to have it as a pointer.
3162
3163 * rendering/RenderTableSection.cpp:
3164 (WebCore::setRowLogicalHeightToRowStyleLogicalHeightIfNotRelative):
3165 (WebCore::RenderTableSection::addChild):
3166 (WebCore::RenderTableSection::setCellLogicalWidths):
3167 (WebCore::RenderTableSection::calcRowLogicalHeight):
3168 (WebCore::RenderTableSection::firstLineBoxBaseline):
3169 (WebCore::RenderTableSection::appendColumn):
3170 (WebCore::RenderTableSection::splitColumn):
3171 Mechanical changes now that |row| is a member of RowStruct.
3172
3173 (WebCore::RenderTableSection::~RenderTableSection): Clear our row vector .
3174
3175 (WebCore::RenderTableSection::ensureRows):
3176 (WebCore::RenderTableSection::recalcCells):
3177 Those 2 functions were refactored to use fillRowsWithDefaultStartingAtPo sition.
3178
3179 (WebCore::RenderTableSection::fillRowsWithDefaultStartingAtPosition):
3180 Factored the code to fill the RowStruct structure with default values.
3181
3182 * rendering/RenderTableSection.h:
3183 (WebCore::RenderTableSection::cellAt):
3184 (WebCore::RenderTableSection::primaryCellAt):
3185 More mechanical change after the |row| field change.
3186
3187 2011-10-28 Anna Cavender <annacc@chromium.org>
3188
3189 Implement load notification and events for <track>.
3190 https://bugs.webkit.org/show_bug.cgi?id=71054
3191
3192 Reviewed by Eric Carlson.
3193
3194 Tests: media/track/track-load-error-readyState.html
3195 media/track/track-load-from-element-readyState.html
3196 media/track/track-load-from-src-readyState.html
3197
3198 * html/HTMLMediaElement.cpp:
3199 (WebCore::HTMLMediaElement::loadTextTracks):
3200 (WebCore::HTMLMediaElement::loadNextTextTrack):
3201 (WebCore::HTMLMediaElement::trackWasAdded):
3202 (WebCore::HTMLMediaElement::trackWillBeRemoved):
3203 (WebCore::HTMLMediaElement::trackSourceChanged):
3204 * html/HTMLMediaElement.h:
3205 * html/HTMLTrackElement.cpp:
3206 (WebCore::HTMLTrackElement::insertedIntoTree):
3207 (WebCore::HTMLTrackElement::willRemove):
3208 (WebCore::HTMLTrackElement::parseMappedAttribute):
3209 (WebCore::HTMLTrackElement::attributeChanged):
3210 * html/HTMLTrackElement.h:
3211 * html/LoadableTextTrack.cpp:
3212 (WebCore::LoadableTextTrack::cueLoadingCompleted):
3213
3214 2011-10-28 Simon Fraser <simon.fraser@apple.com>
3215
3216 The HTML5 video element in Safari does not respect "visibility:hidden" C SS property
3217 https://bugs.webkit.org/show_bug.cgi?id=38829
3218
3219 Reviewed by James Robinson.
3220
3221 Make compositing and CSS visibility play nicely together.
3222
3223 The main issue was that an old optimization (see bug 4377) caused
3224 visibility:hidden layers to not appear in the z-order lists, but those
3225 layers could still become composited, but would remain detached. In addi tion,
3226 composited layers which were visibility:hidden would become visible some times.
3227
3228 With this fix, the z-order lists always contain all layers when the page
3229 is in compositing mode. GraphicsLayer is changed to ensure that visibili ty:hidden
3230 layers show no content, and visible descendants of hidden layers work co rrectly.
3231
3232 Tests: compositing/visibility/visibility-composited-transforms.html
3233 compositing/visibility/visibility-composited.html
3234 compositing/visibility/visibility-image-layers-dynamic.html
3235 compositing/visibility/visibility-image-layers.html
3236
3237 * platform/graphics/GraphicsLayer.cpp:
3238 (WebCore::GraphicsLayer::GraphicsLayer): Init m_contentsVisible to true.
3239 (WebCore::GraphicsLayer::dumpProperties): Dump m_contentsVisible if not true.
3240 * platform/graphics/GraphicsLayer.h:
3241 (WebCore::GraphicsLayer::contentsAreVisible): Getter for m_contentsVisib le.
3242 (WebCore::GraphicsLayer::setContentsVisible): Setter for m_contentsVisib le.
3243 * platform/graphics/ca/GraphicsLayerCA.cpp:
3244 (WebCore::GraphicsLayerCA::setContentsVisible): Override setContentsVisi ble.
3245 (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): Handle Co ntentsVisibilityChanged
3246 flag
3247 (WebCore::GraphicsLayerCA::updateSublayerList): Only parent the m_conten tsLayer if the layer
3248 has visible contents.
3249 (WebCore::GraphicsLayerCA::updateContentsVisibility): For bits painted i nto the layer itself,
3250 we hide it by clearing the backing store.
3251 * platform/graphics/ca/GraphicsLayerCA.h: Removed obsolete comment on th e DrawsContentChanged flag,
3252 added ContentsVisibilityChanged flag.
3253 * rendering/RenderLayer.cpp:
3254 (WebCore::RenderLayer::updateZOrderLists): If we're in compositing mode, include all layers
3255 in the z-order lists.
3256 (WebCore::RenderLayer::collectLayers): New param to specify whether we n eed to collect all layers.
3257 * rendering/RenderLayer.h:
3258 (WebCore::RenderLayer::hasVisibleDescendant): Add comment about the need for an assertion in hasVisibleContent()
3259 , and assertion in hasVisibleDescendant().
3260 * rendering/RenderLayerBacking.cpp:
3261 (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Call setCont entsVisible() on the GraphicsLayer.
3262 (WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): We can use simple container layers in cases
3263 where visibility:hidden causes layer content to not be drawn.
3264 (WebCore::RenderLayerBacking::hasVisibleNonCompositingDescendants): Rena med from hasNonCompositingDescendants()
3265 because it now also looks at visibility to decide when things are visibl e.
3266 * rendering/RenderLayerBacking.h: hasNonCompositingDescendants() renamed to hasVisibleNonCompositingDescendants().
3267
3268 2011-10-22 Philippe Normand <pnormand@igalia.com>
3269
3270 [GTK] Build fixes for glib 2.31 (current master)
3271 https://bugs.webkit.org/show_bug.cgi?id=70679
3272
3273 Reviewed by Martin Robinson.
3274
3275 g_cond_new and g_mutex_new have been replaced by _init
3276 functions. Same for _free, replaced by _clear.
3277
3278 * platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
3279 (webkit_video_sink_init):
3280 (webkit_video_sink_dispose):
3281
3282 2011-10-28 Jochen Eisinger <jochen@chromium.org>
3283
3284 Rename a number of methods mentioning JavaScript to just Script instead
3285 https://bugs.webkit.org/show_bug.cgi?id=71105
3286
3287 Reviewed by Adam Barth.
3288
3289 * WebCore.exp.in:
3290 * bindings/ScriptControllerBase.cpp:
3291 (WebCore::ScriptController::canExecuteScripts):
3292 * bindings/v8/V8Proxy.cpp:
3293 (WebCore::V8Proxy::handleOutOfMemory):
3294 * loader/FrameLoaderClient.h:
3295 (WebCore::FrameLoaderClient::allowScript):
3296 * loader/cache/CachedResourceLoader.cpp:
3297 (WebCore::CachedResourceLoader::canRequest):
3298 * page/Settings.cpp:
3299 (WebCore::Settings::Settings):
3300 (WebCore::Settings::setScriptEnabled):
3301 * page/Settings.h:
3302 (WebCore::Settings::isScriptEnabled):
3303 * svg/graphics/SVGImage.cpp:
3304 (WebCore::SVGImage::dataChanged):
3305
3306 2011-10-28 Pavel Feldman <pfeldman@google.com>
3307
3308 Reset line numbers for scripts generated with document.write.
3309 https://bugs.webkit.org/show_bug.cgi?id=71099
3310
3311 Reviewed by Yury Semikhatsky.
3312
3313 Test: http/tests/inspector-enabled/document-write.html
3314
3315 * dom/Document.h:
3316 (WebCore::Document::isInDocumentWrite):
3317 * dom/ScriptElement.cpp:
3318 (WebCore::ScriptElement::prepareScript):
3319
3320 2011-10-28 Adam Roben <aroben@apple.com>
3321
3322 Mac build fix after r98711
3323
3324 * WebCore.xcodeproj/project.pbxproj: Mark ExceptionCodeDescription.h pri vate so WebKit can
3325 find it.
3326
3327 2011-10-28 Antti Koivisto <antti@apple.com>
3328
3329 [Chromium] css3/font-feature-settings-rendering.html has incorrect image result after r98542
3330 https://bugs.webkit.org/show_bug.cgi?id=71019
3331
3332 Reviewed by Andreas Kling.
3333
3334 These properties need to be marked inherited too.
3335
3336 Note that the new test case doesn't fail even without the patch. If I un derstand correctly
3337 the image test in the title is pretty much the only way to see this. How ever the
3338 new test improves code coverage and protects against future regressions.
3339
3340 Test: fast/css/inherited-properties-rare-text.html
3341
3342 * css/CSSProperty.cpp:
3343 (WebCore::CSSProperty::isInheritedProperty):
3344
3345 2011-10-28 Adam Barth <abarth@webkit.org>
3346
3347 Remove getExceptionCodeDescription()
3348 https://bugs.webkit.org/show_bug.cgi?id=71103
3349
3350 Reviewed by Eric Seidel.
3351
3352 This function serves no purpose.
3353
3354 * bindings/js/JSDOMBinding.cpp:
3355 (WebCore::setDOMException):
3356 * bindings/objc/ExceptionHandlers.mm:
3357 (WebCore::raiseDOMException):
3358 * bindings/scripts/CodeGeneratorGObject.pm:
3359 ():
3360 * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
3361 (webkit_dom_test_obj_method_that_requires_all_args_and_throws):
3362 (webkit_dom_test_obj_method_with_exception):
3363 (webkit_dom_test_obj_with_script_state_void_exception):
3364 (webkit_dom_test_obj_with_script_state_obj_exception):
3365 (webkit_dom_test_obj_get_attr_with_getter_exception):
3366 (webkit_dom_test_obj_set_attr_with_getter_exception):
3367 (webkit_dom_test_obj_set_attr_with_setter_exception):
3368 (webkit_dom_test_obj_set_string_attr_with_getter_exception):
3369 (webkit_dom_test_obj_set_string_attr_with_setter_exception):
3370 * bindings/v8/V8Proxy.cpp:
3371 (WebCore::V8Proxy::setDOMException):
3372 * dom/ExceptionCode.cpp:
3373 * dom/ExceptionCode.h:
3374
3375 2011-10-19 Alexander Pavlov <apavlov@chromium.org>
3376
3377 Web Inspector: CSS background-image applied inline shows a warning, but still works.
3378 https://bugs.webkit.org/show_bug.cgi?id=70325
3379
3380 Reviewed by Antti Koivisto.
3381
3382 This change eliminates the "non-parsed property" warning displayed next to any
3383 "background-image" property of an element's inline style.
3384
3385 * css/CSSParser.cpp:
3386 (WebCore::CSSParser::parseDeclaration):
3387 * css/CSSParser.h:
3388 * inspector/InspectorStyleSheet.cpp:
3389 (WebCore::InspectorStyle::setPropertyText):
3390 (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
3391
3392 2011-10-28 Adam Barth <abarth@webkit.org>
3393
3394 Attempt to fixenate Qt.
3395
3396 * CodeGenerators.pri:
3397 * dom/make_event_factory.pl:
3398 (toMacroStyle):
3399
3400 2011-10-28 Adam Barth <abarth@webkit.org>
3401
3402 ExceptionCode.cpp shouldn't need to know about every feature that throws exceptions
3403 https://bugs.webkit.org/show_bug.cgi?id=70890
3404
3405 Reviewed by Eric Seidel.
3406
3407 Generate the feature-specific parts of ExceptionCode.cpp from a ".in"
3408 file. This is an incremental step towards inlining
3409 getExceptionCodeDescription into its callers and replacing the switch
3410 statements at those locations with autogenerated code.
3411
3412 * CMakeLists.txt:
3413 * CodeGenerators.pri:
3414 * DerivedSources.make:
3415 * GNUmakefile.am:
3416 * GNUmakefile.list.am:
3417 * WebCore.gyp/WebCore.gyp:
3418 * WebCore.gyp/scripts/action_makenames.py:
3419 * WebCore.gypi:
3420 * WebCore.vcproj/WebCore.vcproj:
3421 * WebCore.xcodeproj/project.pbxproj:
3422 * bindings/js/JSDOMBinding.cpp:
3423 (WebCore::setDOMException):
3424 * bindings/v8/V8Proxy.cpp:
3425 (WebCore::V8Proxy::setDOMException):
3426 * dom/DOMCoreException.cpp:
3427 (WebCore::DOMCoreException::initializeDescription):
3428 * dom/ExceptionCode.cpp:
3429 (WebCore::getExceptionCodeDescription):
3430 * dom/ExceptionCode.h:
3431 * dom/ExceptionCodeDescription.in: Added.
3432 * dom/make_exception_code_description.pl: Added.
3433 (defaultItemFactory):
3434 (generateCode):
3435 (generateHeader):
3436 (generateImplementation):
3437
3438 2011-10-28 Yury Semikhatsky <yurys@chromium.org>
3439
3440 Web Inspector: CallStackSidebarPane should remove discarded Placards fro m RawSourceCode listeners list
3441 https://bugs.webkit.org/show_bug.cgi?id=70996
3442
3443 Reviewed by Pavel Feldman.
3444
3445 Test: inspector/debugger/callstack-placards-discarded.html
3446
3447 * inspector/front-end/CallStackSidebarPane.js:
3448 (WebInspector.CallStackSidebarPane.prototype.update):
3449 * inspector/front-end/DebuggerPresentationModel.js:
3450 (WebInspector.DebuggerPresentationModel.prototype.createPlacard):
3451 (WebInspector.DebuggerPresentationModel.CallFramePlacard):
3452 (WebInspector.DebuggerPresentationModel.CallFramePlacard.prototype.disca rd):
3453 (WebInspector.DebuggerPresentationModel.CallFramePlacard.prototype._upda te):
3454 * inspector/front-end/Placard.js:
3455 (WebInspector.Placard.prototype.toggleSelected):
3456 (WebInspector.Placard.prototype.discard):
3457
3458 2011-10-28 Jochen Eisinger <jochen@chromium.org>
3459
3460 Add allowScriptFromSource callback to FrameLoaderClient
3461 https://bugs.webkit.org/show_bug.cgi?id=71013
3462
3463 Reviewed by Darin Fisher.
3464
3465 Test: platform/chromium/permissionclient/script-permissions.html
3466
3467 * loader/FrameLoaderClient.h:
3468 (WebCore::FrameLoaderClient::allowScriptFromSource):
3469 * loader/cache/CachedResourceLoader.cpp:
3470 (WebCore::CachedResourceLoader::canRequest):
3471
3472 2011-10-27 Adam Barth <abarth@webkit.org>
3473
3474 Refactor make_event_factory.pl to use InFilesCompiler.pm
3475 https://bugs.webkit.org/show_bug.cgi?id=71094
3476
3477 Reviewed by Eric Seidel.
3478
3479 This refactoring helps share code with
3480 make_exception_code_descriptions.pl, which is coming in a future patch.
3481 I have a dream of refactoring make_names.pl to use this module as well.
3482
3483 * CodeGenerators.pri:
3484 * DerivedSources.make:
3485 * GNUmakefile.am:
3486 * WebCore.gyp/scripts/action_makenames.py:
3487 * bindings/scripts/InFilesCompiler.pm: Added.
3488 (itemHandler):
3489 (parameterHandler):
3490 (new):
3491 (compile):
3492 (license):
3493 * dom/make_event_factory.pl:
3494 (defaultItemFactory):
3495 (interfaceForEvent):
3496 (generateCode):
3497 (printFactoryFile):
3498 (printMacroFile):
3499 (printHeadersFile):
3500
3501 2011-10-26 Nat Duca <nduca@chromium.org>
3502
3503 [chromium] Implement frame rate control portions of CCScheduler
3504 https://bugs.webkit.org/show_bug.cgi?id=70713
3505
3506 Reviewed by James Robinson.
3507
3508 * WebCore.gypi:
3509 * platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp: Added.
3510 (WebCore::CCDelayBasedTimeSource::setActive):
3511 (WebCore::CCDelayBasedTimeSource::postTickTask):
3512 (WebCore::CCDelayBasedTimeSource::onTick):
3513 * platform/graphics/chromium/cc/CCDelayBasedTimeSource.h: Added.
3514 (WebCore::CCDelayBasedTimeSource::CCDelayBasedTimeSource):
3515 (WebCore::CCDelayBasedTimeSource::~CCDelayBasedTimeSource):
3516 (WebCore::CCDelayBasedTimeSource::setClient):
3517 (WebCore::CCDelayBasedTimeSource::monotonicallyIncreasingTime):
3518 * platform/graphics/chromium/cc/CCFrameRateController.cpp: Added.
3519 (WebCore::CCFrameRateControllerTimeSourceAdapter::create):
3520 (WebCore::CCFrameRateControllerTimeSourceAdapter::~CCFrameRateController TimeSourceAdapter):
3521 (WebCore::CCFrameRateControllerTimeSourceAdapter::onTimerTick):
3522 (WebCore::CCFrameRateControllerTimeSourceAdapter::CCFrameRateControllerT imeSourceAdapter):
3523 (WebCore::CCFrameRateController::CCFrameRateController):
3524 (WebCore::CCFrameRateController::~CCFrameRateController):
3525 (WebCore::CCFrameRateController::onTimerTick):
3526 (WebCore::CCFrameRateController::didBeginFrame):
3527 (WebCore::CCFrameRateController::didFinishFrame):
3528 (WebCore::CCFrameRateController::didAbortAllPendingFrames):
3529 * platform/graphics/chromium/cc/CCFrameRateController.h: Added.
3530 (WebCore::CCFrameRateControllerClient::~CCFrameRateControllerClient):
3531 (WebCore::CCFrameRateController::setClient):
3532 (WebCore::CCFrameRateController::setActive):
3533 * platform/graphics/chromium/cc/CCTimeSource.h: Added.
3534 (WebCore::CCTimeSourceClient::~CCTimeSourceClient):
3535 (WebCore::CCTimeSource::~CCTimeSource):
3536
3537 2011-10-27 Kentaro Hara <haraken@chromium.org>
3538
3539 Deprecate [V8ConstructorSetsActiveDOMWrapper] IDL
3540 https://bugs.webkit.org/show_bug.cgi?id=71088
3541
3542 Reviewed by Adam Barth.
3543
3544 I introduced [V8ConstructorSetsActiveDOMWrapper] IDL in bug 66536,
3545 but I found that it has the same meaning as [ActiveDOMObject] IDL.
3546 This patch removes [V8ConstructorSetsActiveDOMWrapper] IDL.
3547
3548 No change in behavior.
3549
3550 Tests: fast/dom/global-constructors.html
3551 fast/eventsource/eventsource-constructor.html
3552 fast/eventsource/eventsource-attribute-listeners.html
3553 fast/files/blob-slice-test.html
3554 fast/files/file-reader-abort.html
3555 ui_tests:WorkerTest.FLAKY_SharedWorkerFastConstructor
3556 ui_tests:WorkerTest.FLAKY_SharedWorkerFastName
3557 ui_tests:WorkerTest.FLAKY_WorkerConstructor
3558 ui_tests:WorkerTest.FLAKY_WorkerEventListener
3559
3560 * bindings/scripts/CodeGeneratorV8.pm: Replaced "V8ConstructorSetsActive DOMWrapper" with "ActiveDOMObject".
3561 (GenerateConstructorCallback):
3562 * bindings/scripts/test/TestInterface.idl: Ditto.
3563 * bindings/scripts/test/JS/JSTestInterface.cpp: Updated a test result.
3564 (WebCore::isObservable):
3565 (WebCore::JSTestInterfaceOwner::isReachableFromOpaqueRoots):
3566 (WebCore::JSTestInterfaceOwner::finalize):
3567 * bindings/scripts/test/JS/JSTestInterface.h: Ditto.
3568 (WebCore::wrapperOwner):
3569 (WebCore::wrapperContext):
3570 * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Ditto.
3571 * bindings/scripts/test/JS/JSTestMediaQueryListListener.h: Ditto.
3572 * bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
3573 * bindings/scripts/test/JS/JSTestObj.h: Ditto.
3574 * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Dit to.
3575 * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h: Ditto .
3576 * bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.
3577 (WebCore::V8TestInterface::toActiveDOMObject):
3578 (WebCore::V8TestInterface::wrapSlow):
3579 * bindings/scripts/test/V8/V8TestInterface.h: Ditto.
3580 (WebCore::V8TestInterface::existingWrapper):
3581 * fileapi/FileReader.idl: Removed [V8ConstructorSetsActiveDOMWrapper] ID L.
3582 * mediastream/PeerConnection.idl: Ditto.
3583 * page/EventSource.idl: Ditto.
3584 * workers/SharedWorker.idl: Ditto.
3585 * workers/Worker.idl: Ditto.
3586
3587 2011-10-28 Yuta Kitamura <yutak@chromium.org>
3588
3589 Race condition in SocketStreamHandleCFNet when PAC script is used
3590 https://bugs.webkit.org/show_bug.cgi?id=70894
3591
3592 Reviewed by Alexey Proskuryakov.
3593
3594 Pass callback functions that call ref() or deref() as retain/release mem ber
3595 of CFStreamClientContext.
3596
3597 No new tests, as it is not possible to write a test with PAC script enab led.
3598
3599 * platform/network/cf/SocketStreamHandle.h:
3600 * platform/network/cf/SocketStreamHandleCFNet.cpp:
3601 (WebCore::SocketStreamHandle::scheduleStreams):
3602 (WebCore::SocketStreamHandle::retainSocketStreamHandle):
3603 (WebCore::SocketStreamHandle::releaseSocketStreamHandle):
3604 (WebCore::SocketStreamHandle::pacExecutionCallbackMainThread):
3605 This callback may be called after platformClose() is already called. We should
3606 not create new streams in this case.
3607 (WebCore::SocketStreamHandle::executePACFileURL):
3608 (WebCore::SocketStreamHandle::readStreamCallback):
3609 This manual ref/deref can be safely removed as m_readStream holds the re ference.
3610 (WebCore::SocketStreamHandle::writeStreamCallback):
3611 Ditto.
3612
3613 2011-10-27 Arthur Hsu <arthurhsu@chromium.org>
3614
3615 Reland patch ensure font load before calling Skia during printing
3616 https://bugs.webkit.org/show_bug.cgi?id=70390
3617
3618 Reviewed by James Robinson.
3619
3620 * platform/graphics/chromium/FontChromiumWin.cpp:
3621 (WebCore::Font::drawGlyphs):
3622 * platform/graphics/skia/SkiaFontWin.cpp:
3623 (WebCore::paintSkiaText):
3624
3625 2011-10-27 Adam Barth <abarth@webkit.org>
3626
3627 Attempt to fix the Qt build.
3628
3629 * WebCore.pro:
3630
3631 2011-10-27 Ryosuke Niwa <rniwa@webkit.org>
3632
3633 binding test rebaseline after r98679.
3634
3635 * bindings/scripts/test/JS/JSTestInterface.cpp:
3636 (WebCore::JSTestInterfaceConstructor::constructJSTestInterface):
3637 * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
3638 (WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
3639 * bindings/scripts/test/JS/JSTestObj.cpp:
3640 (WebCore::setJSTestObjStringAttr):
3641 (WebCore::setJSTestObjStringAttrWithGetterException):
3642 (WebCore::setJSTestObjStringAttrWithSetterException):
3643 (WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
3644 (WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
3645 (WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
3646 (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgs):
3647 (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
3648 (WebCore::jsTestObjPrototypeFunctionSerializedValue):
3649 (WebCore::jsTestObjPrototypeFunctionIdbKey):
3650 (WebCore::jsTestObjPrototypeFunctionOptionsObject):
3651 (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
3652 (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg):
3653 (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg):
3654 (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture):
3655 (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
3656 (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
3657 (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalA rg):
3658 (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOption alArgs):
3659 (WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackA rg):
3660 (WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
3661 (WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
3662 (WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
3663 (WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
3664 (WebCore::jsTestObjPrototypeFunctionOverloadedMethod6):
3665 (WebCore::jsTestObjPrototypeFunctionOverloadedMethod7):
3666 (WebCore::jsTestObjPrototypeFunctionClassMethodWithOptional):
3667
3668 2011-10-27 Adam Barth <abarth@webkit.org>
3669
3670 Move type-specific exception descriptions into the implementation files for each type
3671 https://bugs.webkit.org/show_bug.cgi?id=71081
3672
3673 Reviewed by Eric Seidel.
3674
3675 There's no reason to centralize this information. It belongs with each
3676 exception type. This patch is in preparation for autogenerating the cen tral file.
3677
3678 * WebCore.xcodeproj/project.pbxproj:
3679 * dom/DOMCoreException.cpp: Added.
3680 (WebCore::DOMCoreException::initializeDescription):
3681 * dom/DOMCoreException.h:
3682 * dom/EventException.cpp: Copied from Source/WebCore/xml/XMLHttpRequestE xception.h.
3683 (WebCore::EventException::initializeDescription):
3684 * dom/EventException.h:
3685 * dom/ExceptionBase.h:
3686 (WebCore::ExceptionBase::code):
3687 (WebCore::ExceptionBase::name):
3688 (WebCore::ExceptionBase::message):
3689 (WebCore::ExceptionBase::description):
3690 * dom/ExceptionCode.cpp:
3691 (WebCore::getExceptionCodeDescription):
3692 * dom/RangeException.cpp: Copied from Source/WebCore/xml/XPathException. h.
3693 (WebCore::RangeException::initializeDescription):
3694 * dom/RangeException.h:
3695 * fileapi/FileException.cpp: Added.
3696 (WebCore::FileException::initializeDescription):
3697 * fileapi/FileException.h:
3698 * fileapi/OperationNotAllowedException.cpp: Copied from Source/WebCore/x ml/XMLHttpRequestException.h.
3699 (WebCore::OperationNotAllowedException::initializeDescription):
3700 * fileapi/OperationNotAllowedException.h:
3701 * storage/IDBDatabaseException.cpp: Added.
3702 (WebCore::IDBDatabaseException::initializeDescription):
3703 * storage/IDBDatabaseException.h:
3704 * storage/SQLException.cpp: Added.
3705 (WebCore::SQLException::initializeDescription):
3706 * storage/SQLException.h:
3707 * svg/SVGException.cpp: Copied from Source/WebCore/dom/EventException.h.
3708 (WebCore::SVGException::initializeDescription):
3709 * svg/SVGException.h:
3710 * xml/XMLHttpRequestException.cpp: Copied from Source/WebCore/xml/XMLHtt pRequestException.h.
3711 (WebCore::XMLHttpRequestException::initializeDescription):
3712 * xml/XMLHttpRequestException.h:
3713 * xml/XPathException.cpp: Copied from Source/WebCore/xml/XPathException. h.
3714 (WebCore::XPathException::initializeDescription):
3715 * xml/XPathException.h:
3716
3717 2011-10-27 Kentaro Hara <haraken@chromium.org>
3718
3719 Generate WebKitCSSMatrix constructor for JSC by [Constructor] IDL
3720 https://bugs.webkit.org/show_bug.cgi?id=70215
3721
3722 Reviewed by Adam Barth.
3723
3724 This patch implements [Optional=CallWithNullValue] IDL for JSC.
3725 While a parameter specified as [Optional=CallWithDefaultValue] is
3726 handled as a string "undefined", a parameter specified as
3727 [Optional=CallWithNullValue] is handled as a null string.
3728 (Note: not a string "null", but a null string).
3729
3730 c.f. [Optional=CallWithNullValue] is implemented in V8 in bug 67458.
3731
3732 Tests: fast/dom/global-constructors.html
3733 transforms/svg-vs-css.xhtml
3734 transforms/cssmatrix-2d-interface.xhtml
3735 transforms/cssmatrix-3d-interface.xhtml
3736
3737 * GNUmakefile.list.am: Removed JSWebKitCSSMatrixCustom.cpp.
3738 * UseJSC.cmake: Ditto.
3739 * WebCore.gypi: Ditto.
3740 * WebCore.pro: Ditto.
3741 * WebCore.xcodeproj/project.pbxproj: Ditto.
3742 * bindings/js/JSBindingsAllInOne.cpp: Ditto.
3743 * bindings/js/JSDOMBinding.h: MAYBE_MISSING_PARAMETER(exec, index, polic y) returns the index-th parameter, if the parameter exists. It returns an undefi ned value, if the index-th parameter is missing and the policy is MissingIsUndef ined. It returns an empty value, otherwise (i.e. if the index-th parameter is mi ssing and the policy is MissingIsEmpty).
3744 * bindings/js/JSWebKitCSSMatrixCustom.cpp: Removed.
3745 * bindings/scripts/CodeGeneratorJS.pm:
3746 (GenerateParametersCheck): Supported [Optional=CallWithNullValue].
3747 (GenerateConstructorDefinition): Supported [Optional=CallWithNullValue].
3748 * css/WebKitCSSMatrix.idl: Removed [JSCustomConstructor].
3749
3750 2011-10-27 Julien Chaffraix <jchaffraix@webkit.org>
3751
3752 RenderTableCell m_row and m_column should not be signed values
3753 https://bugs.webkit.org/show_bug.cgi?id=70369
3754
3755 Reviewed by Darin Adler.
3756
3757 No new tests, refactoring only.
3758
3759 The gist of the change is to update row / column handling in the table's
3760 rendering code to use unsigned values. Not all the code is switched over
3761 to unsigned but this is a good start.
3762
3763 Using unsigned makes a lot more sense that allowing some negative indexe s
3764 to creep in the algorithms. Also it enables us to "free" the unused sign ed
3765 bit on the 2 RenderTableCell fields that can be used to pack 2 bits in a
3766 follow-up patch.
3767
3768 * accessibility/AccessibilityTable.cpp:
3769 (WebCore::AccessibilityTable::cellForColumnAndRow):
3770 Removed 2 casts to int as the left side now computes to an unsigned too.
3771 Added some ASSERT to make sure we don't get negative values (colSpan / r owSpan
3772 are always >= 1 by definition but better to be safe).
3773
3774 * accessibility/AccessibilityTableColumn.cpp:
3775 (WebCore::AccessibilityTableColumn::headerObjectForSection):
3776 * accessibility/AccessibilityTableColumn.h:
3777 Switched m_columnIndex to unsigned to remove any signed / unsigned compa risons.
3778
3779 * rendering/RenderTable.cpp:
3780 (WebCore::RenderTable::splitColumn):
3781 (WebCore::RenderTable::calcBorderEnd):
3782 (WebCore::RenderTable::cellAbove):
3783 (WebCore::RenderTable::cellBelow):
3784 (WebCore::RenderTable::cellBefore):
3785 (WebCore::RenderTable::cellAfter):
3786 Mostly mechanical changes to avoid signed / unsigned comparisons or cast s.
3787
3788 * rendering/RenderTable.h:
3789 (WebCore::RenderTable::numEffCols):
3790 (WebCore::RenderTable::colToEffCol):
3791 Updated a couple of functions to use an unsigned.
3792
3793 * rendering/RenderTableCell.cpp:
3794 (WebCore::RenderTableCell::RenderTableCell):
3795 * rendering/RenderTableCell.h:
3796 (WebCore::RenderTableCell::col):
3797 (WebCore::RenderTableCell::setCol):
3798 (WebCore::RenderTableCell::row):
3799 (WebCore::RenderTableCell::setRow):
3800 Updated after switching the fields to unsigned. Also added 2 constants
3801 to cover the not-initialized-yet value for row and column indexes.
3802 Note: we don't enforce that you can't reach those indexes but neither
3803 did the previous code!
3804
3805 * rendering/RenderTableSection.cpp:
3806 (WebCore::RenderTableSection::RenderTableSection):
3807 (WebCore::RenderTableSection::addChild):
3808 (WebCore::RenderTableSection::ensureRows):
3809 (WebCore::RenderTableSection::setCellLogicalWidths):
3810 (WebCore::RenderTableSection::calcRowLogicalHeight):
3811 (WebCore::RenderTableSection::layoutRows):
3812 (WebCore::RenderTableSection::calcOuterBorderStart):
3813 (WebCore::RenderTableSection::calcOuterBorderEnd):
3814 (WebCore::RenderTableSection::recalcCells):
3815 (WebCore::RenderTableSection::clearGrid):
3816 (WebCore::RenderTableSection::numColumns):
3817 (WebCore::RenderTableSection::appendColumn):
3818 (WebCore::RenderTableSection::splitColumn):
3819 Lots of mechanical: signed -> unsigned changes. However we had
3820 to change the logic a bit as it assumed that m_cRow started at
3821 -1 and increased from there. The new meaning of m_cRow is the
3822 number of rows seen and m_cRow - 1 is where to insert your new
3823 cells.
3824
3825 (WebCore::RenderTableSection::addCell):
3826 Checked the callers and all increase m_cRow before calling the function.
3827 Added an ASSERT to catch up wrong usage in the future.
3828
3829 * rendering/RenderTableSection.h:
3830 (WebCore::RenderTableSection::numRows): Switched to unsigned.
3831
3832 2011-10-27 Dan Bernstein <mitz@apple.com>
3833
3834 Assertion failure (m_text) in RenderText::RenderText() at icanhascheezbu rger.com
3835 https://bugs.webkit.org/show_bug.cgi?id=71085
3836
3837 Reviewed by Jon Honeycutt.
3838
3839 Test: fast/css-generated-content/attr-missing.html
3840
3841 * css/CSSStyleSelector.cpp:
3842 (WebCore::CSSStyleSelector::applyProperty): If the element does not have the attribute specified
3843 in the attr() function in the content property, set the content to the e mpty string, per
3844 <http://www.w3.org/TR/CSS21/generate.html#content>.
3845
3846 2011-10-27 Helder Correia <helder.correia@palm.com>
3847
3848 [Qt] Failure to build when QT_NO_CURSOR defined
3849 https://bugs.webkit.org/show_bug.cgi?id=71060
3850
3851 Reviewed by Noam Rosenthal.
3852
3853 PlatformVideoWindowQt needs to wrap some code around #ifndef
3854 QT_NO_CURSOR in order to build QtWebKit when QT_NO_CURSOR is defined.
3855
3856 Build fix, no new tests.
3857
3858 * platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:
3859 (FullScreenVideoWindow::FullScreenVideoWindow):
3860 (FullScreenVideoWindow::closeEvent):
3861 (FullScreenVideoWindow::hideCursor):
3862 (FullScreenVideoWindow::showCursor):
3863
3864 2011-10-27 Shawn Singh <shawnsingh@chromium.org>
3865
3866 [chromium] Track when CCLayerImpl properties have changed.
3867 https://bugs.webkit.org/show_bug.cgi?id=70442
3868
3869 Reviewed by James Robinson.
3870
3871 To determine a good scissor rect, we must determine what
3872 will change on the screen on the next redraw. This patch
3873 tracks the necessary information on CCLayerImpl and marks
3874 a flag indicating whether this layer will "damage" the screen.
3875 The other portion of "change", the updateRect, was already
3876 landed in https://bugs.webkit.org/show_bug.cgi?id=69441.
3877
3878 New unit test added to CCLayerImplTest to test this patch.
3879
3880 * platform/graphics/chromium/cc/CCLayerImpl.cpp:
3881 (WebCore::CCLayerImpl::CCLayerImpl):
3882 (WebCore::CCLayerImpl::scrollBy):
3883 (WebCore::CCLayerImpl::noteLayerPropertyChangedForSubtree):
3884 (WebCore::CCLayerImpl::noteLayerPropertyChangedForDescendants):
3885 (WebCore::CCLayerImpl::setBounds):
3886 (WebCore::CCLayerImpl::setMaskLayer):
3887 (WebCore::CCLayerImpl::setReplicaLayer):
3888 (WebCore::CCLayerImpl::setDrawsContent):
3889 (WebCore::CCLayerImpl::setAnchorPoint):
3890 (WebCore::CCLayerImpl::setAnchorPointZ):
3891 (WebCore::CCLayerImpl::setMasksToBounds):
3892 (WebCore::CCLayerImpl::setOpaque):
3893 (WebCore::CCLayerImpl::setOpacity):
3894 (WebCore::CCLayerImpl::setPosition):
3895 (WebCore::CCLayerImpl::setPreserves3D):
3896 (WebCore::CCLayerImpl::setSublayerTransform):
3897 (WebCore::CCLayerImpl::setTransform):
3898 (WebCore::CCLayerImpl::setDebugBorderColor):
3899 (WebCore::CCLayerImpl::setDebugBorderWidth):
3900 (WebCore::CCLayerImpl::setContentBounds):
3901 (WebCore::CCLayerImpl::setScrollPosition):
3902 (WebCore::CCLayerImpl::setScrollDelta):
3903 (WebCore::CCLayerImpl::setDoubleSided):
3904 * platform/graphics/chromium/cc/CCLayerImpl.h:
3905 (WebCore::CCLayerImpl::layerPropertyChanged):
3906 (WebCore::CCLayerImpl::resetLayerPropertyChanged):
3907
3908 2011-10-27 Anders Carlsson <andersca@apple.com>
3909
3910 Add a Plugin::geometryDidChange that will work with transforms
3911 https://bugs.webkit.org/show_bug.cgi?id=71072
3912
3913 Reviewed by Simon Fraser.
3914
3915 Export symbols needed by WebKit2.
3916
3917 * WebCore.exp.in:
3918
3919 2011-10-27 Adam Barth <abarth@webkit.org>
3920
3921 Exception subtypes have incorrect namespace indentation
3922 https://bugs.webkit.org/show_bug.cgi?id=71075
3923
3924 Reviewed by Eric Seidel.
3925
3926 This patch is in preparation for editing these headers. We decided to
3927 not indent namespaces in headers and update the headers as we edited
3928 them.
3929
3930 * dom/DOMCoreException.h:
3931 (WebCore::DOMCoreException::create):
3932 (WebCore::DOMCoreException::DOMCoreException):
3933 * dom/EventException.h:
3934 (WebCore::EventException::create):
3935 (WebCore::EventException::EventException):
3936 * dom/RangeException.h:
3937 (WebCore::RangeException::create):
3938 (WebCore::RangeException::RangeException):
3939 * xml/XMLHttpRequestException.h:
3940 (WebCore::XMLHttpRequestException::create):
3941 (WebCore::XMLHttpRequestException::XMLHttpRequestException):
3942 * xml/XPathException.h:
3943 (WebCore::XPathException::create):
3944 (WebCore::XPathException::XPathException):
3945
3946 2011-10-27 Kenneth Russell <kbr@google.com>
3947
3948 Implement new restrictions on uniform and attribute location lengths
3949 https://bugs.webkit.org/show_bug.cgi?id=70981
3950
3951 Reviewed by Chris Marrin.
3952
3953 Tests: fast/canvas/webgl/attrib-location-length-limits.html
3954 fast/canvas/webgl/uniform-location-length-limits.html
3955
3956 * html/canvas/WebGLRenderingContext.cpp:
3957 (WebCore::WebGLRenderingContext::bindAttribLocation):
3958 (WebCore::WebGLRenderingContext::getAttribLocation):
3959 (WebCore::WebGLRenderingContext::getUniformLocation):
3960 (WebCore::WebGLRenderingContext::validateLocationLength):
3961 * html/canvas/WebGLRenderingContext.h:
3962
3963 2011-10-27 Rafael Weinstein <rafaelw@chromium.org>
3964
3965 [MutationObservers] Implement subtree observation of transiently disconn ected nodes
3966 https://bugs.webkit.org/show_bug.cgi?id=70788
3967
3968 Reviewed by Ryosuke Niwa.
3969
3970 This patch adds support for observing all descendant nodes reachable fro m a subtree
3971 observation until delivery of mutations -- even if they become detached. We do this by
3972 introducing a "transient registration" which can exist for a short time along side
3973 normal registrations on Node. Transient registrations have a reference t o the node
3974 which "owns" the subtree observation registration (the "registrationNode "). Transient
3975 registrations are cleared immediately before mutations are delivered to an observer,
3976 or when the observer re-observes at the registrationNode, in-effect rese tting the
3977 observation.
3978
3979 New tests added to fast/mutation/observe-subtree.html.
3980
3981 * dom/CharacterData.cpp:
3982 (WebCore::CharacterData::dispatchModifiedEvent):
3983 * dom/ChildListMutationScope.cpp:
3984 (WebCore::MutationAccumulationRouter::ChildListMutationAccumulator::Chil dListMutationAccumulator):
3985 (WebCore::MutationAccumulationRouter::ChildListMutationAccumulator::enqu eueMutationRecord):
3986 (WebCore::MutationAccumulationRouter::MutationAccumulationRouter::increm entScopingLevel):
3987 * dom/ContainerNode.cpp:
3988 (WebCore::dispatchChildRemovalEvents):
3989 * dom/Element.cpp:
3990 (WebCore::enqueueAttributesMutationRecord):
3991 * dom/Node.cpp:
3992 (WebCore::addMatchingObservers):
3993 (WebCore::Node::getRegisteredMutationObserversOfType):
3994 (WebCore::Node::registerMutationObserver):
3995 (WebCore::Node::unregisterMutationObserver):
3996 (WebCore::Node::notifySubtreeObserversOfDisconnection):
3997 * dom/Node.h:
3998 * dom/NodeRareData.h:
3999 (WebCore::MutationObserverEntry::MutationObserverEntry):
4000 (WebCore::MutationObserverEntry::operator==):
4001 * dom/WebKitMutationObserver.cpp:
4002 (WebCore::WebKitMutationObserver::observe):
4003 (WebCore::unregisterTransientEntries):
4004 (WebCore::WebKitMutationObserver::disconnect):
4005 (WebCore::WebKitMutationObserver::observedNodeDestructed):
4006 (WebCore::WebKitMutationObserver::observedSubtreeWillDisconnect):
4007 (WebCore::WebKitMutationObserver::clearTransientEntries):
4008 (WebCore::WebKitMutationObserver::deliver):
4009 * dom/WebKitMutationObserver.h:
4010
4011 2011-10-27 Pratik Solanki <psolanki@apple.com>
4012
4013 Ask CG to not parse image metadata
4014 https://bugs.webkit.org/show_bug.cgi?id=71029
4015
4016 Reviewed by Simon Fraser.
4017
4018 We don't need CG to parse the image metadata since WebCore never uses it . Passing this
4019 option shaves off time spent under CGImageSourceCopyPropertiesAtIndex. U nder Instruments I
4020 saw the time drop from ~75ms to ~25ms when loading http://boston.com/big picture and the
4021 first link on that page.
4022
4023 No new tests because no change in functionality.
4024
4025 * platform/graphics/ImageSource.h:
4026 * platform/graphics/cg/ImageSourceCG.cpp:
4027 (WebCore::imageSourceOptions):
4028 (WebCore::ImageSource::isSizeAvailable):
4029 (WebCore::ImageSource::frameSizeAtIndex):
4030 (WebCore::ImageSource::getHotSpot):
4031 (WebCore::ImageSource::repetitionCount):
4032 (WebCore::ImageSource::createFrameAtIndex):
4033 (WebCore::ImageSource::frameDurationAtIndex):
4034
4035 2011-10-27 David Grogan <dgrogan@chromium.org>
4036
4037 Move eventqueue from Document to ScriptExecutionContext so that it can b e accessed from workers
4038 https://bugs.webkit.org/show_bug.cgi?id=57789
4039
4040 Extract interface from EventQueue and create two new subclasses:
4041 DocumentEventQueue and WorkerEventQueue. DocumentEventQueue is the
4042 old EventQueue implementation that uses DOMTimer(0) to post async
4043 events. WorkerEventQueue posts events to its thread's message loop.
4044
4045 Reviewed by David Levin.
4046
4047 No new tests - IndexedDB will use this but isn't ready yet. I don't
4048 know of any other API available in workers that I can test this with.
4049
4050 * GNUmakefile.list.am:
4051 * WebCore.gypi:
4052 * WebCore.pro:
4053 * WebCore.xcodeproj/project.pbxproj:
4054 * dom/DOMAllInOne.cpp:
4055 * dom/Document.cpp:
4056 (WebCore::Document::Document):
4057 * dom/Document.h:
4058 (WebCore::Document::eventQueue):
4059 * dom/DocumentEventQueue.cpp: Renamed from Source/WebCore/dom/EventQueue .cpp.
4060 (WebCore::shouldDispatchScrollEventSynchronously):
4061 (WebCore::DocumentEventQueueTimer::DocumentEventQueueTimer):
4062 (WebCore::DocumentEventQueueTimer::fired):
4063 (WebCore::DocumentEventQueue::create):
4064 (WebCore::DocumentEventQueue::DocumentEventQueue):
4065 (WebCore::DocumentEventQueue::~DocumentEventQueue):
4066 (WebCore::DocumentEventQueue::enqueueEvent):
4067 (WebCore::DocumentEventQueue::enqueueOrDispatchScrollEvent):
4068 (WebCore::DocumentEventQueue::cancelEvent):
4069 (WebCore::DocumentEventQueue::close):
4070 (WebCore::DocumentEventQueue::pendingEventTimerFired):
4071 (WebCore::DocumentEventQueue::dispatchEvent):
4072 * dom/DocumentEventQueue.h: Copied from Source/WebCore/dom/EventQueue.h.
4073 * dom/EventQueue.h:
4074 * dom/ScriptExecutionContext.h:
4075 * page/EventHandler.cpp: Change EventQueue to DocumentEventQueue.
4076 (WebCore::EventHandler::sendScrollEvent): Change EventQueue to DocumentE ventQueue.
4077 * rendering/RenderLayer.cpp:
4078 (WebCore::RenderLayer::scrollTo): Change EventQueue to DocumentEventQueu e.
4079 * rendering/RenderListBox.cpp:
4080 (WebCore::RenderListBox::scrollTo): Change EventQueue to DocumentEventQu eue.
4081 * storage/IDBDatabase.cpp:
4082 * storage/IDBRequest.cpp:
4083 * storage/IDBTransaction.cpp:
4084 * workers/WorkerContext.cpp:
4085 (WebCore::WorkerContext::eventQueue):
4086 * workers/WorkerContext.h:
4087 * workers/WorkerEventQueue.cpp: Added.
4088 (WebCore::WorkerEventQueue::create):
4089 (WebCore::WorkerEventQueue::WorkerEventQueue):
4090 (WebCore::WorkerEventQueue::~WorkerEventQueue):
4091 (WebCore::WorkerEventQueue::EventDispatcherTask::create):
4092 (WebCore::WorkerEventQueue::EventDispatcherTask::dispatchEvent):
4093 (WebCore::WorkerEventQueue::EventDispatcherTask::performTask):
4094 (WebCore::WorkerEventQueue::EventDispatcherTask::cancel):
4095 (WebCore::WorkerEventQueue::EventDispatcherTask::EventDispatcherTask):
4096 (WebCore::WorkerEventQueue::removeEvent):
4097 (WebCore::WorkerEventQueue::enqueueEvent):
4098 (WebCore::WorkerEventQueue::cancelEvent):
4099 (WebCore::WorkerEventQueue::close):
4100 * workers/WorkerEventQueue.h: Copied from Source/WebCore/dom/EventQueue. h.
4101
4102 2011-10-27 Jonathon Jongsma <jonathon.jongsma@collabora.co.uk>
4103
4104 [GStreamer] Prevent memory leak when fullscreening a video
4105 https://bugs.webkit.org/show_bug.cgi?id=71043
4106
4107 Reviewed by Gustavo Noronha Silva.
4108
4109 * platform/graphics/gstreamer/GStreamerGWorld.cpp:
4110 (WebCore::GStreamerGWorld::GStreamerGWorld):
4111 (WebCore::GStreamerGWorld::enterFullscreen):
4112 (WebCore::GStreamerGWorld::exitFullscreen):
4113 * platform/graphics/gstreamer/GStreamerGWorld.h:
4114
4115 2011-10-27 Joseph Pecoraro <pecoraro@apple.com>
4116
4117 Reviewed by David Kilzer.
4118
4119 Make FeatureDefines Identical Across OS X Projects
4120 https://bugs.webkit.org/show_bug.cgi?id=71051
4121
4122 * Configurations/FeatureDefines.xcconfig:
4123
4124 2011-10-27 Joseph Pecoraro <pecoraro@apple.com>
4125
4126 Correctly Guard Exported REQUEST_ANIMATION_FRAME Symbols
4127 https://bugs.webkit.org/show_bug.cgi?id=71047
4128
4129 Reviewed by David Kilzer.
4130
4131 * WebCore.exp.in:
4132
4133 2011-10-27 Sheriff Bot <webkit.review.bot@gmail.com>
4134
4135 Unreviewed, rolling out r98626.
4136 http://trac.webkit.org/changeset/98626
4137 https://bugs.webkit.org/show_bug.cgi?id=71066
4138
4139 Does not compile on cr-win (Requested by jamesr_ on #webkit).
4140
4141 * platform/graphics/chromium/FontChromiumWin.cpp:
4142 (WebCore::Font::drawGlyphs):
4143 * platform/graphics/skia/SkiaFontWin.cpp:
4144 (WebCore::paintSkiaText):
4145
4146 2011-10-27 Tony Chang <tony@chromium.org>
4147
4148 Fix a compiler warning caught by gcc 4.6.1. Need to return something.
4149
4150 * platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
4151 (WebCore::CCSchedulerStateMachine::nextAction):
4152
4153 2011-10-27 Vsevolod Vlasov <vsevik@chromium.org>
4154
4155 Web Inspector: Advanced search style fixes.
4156 https://bugs.webkit.org/show_bug.cgi?id=71036
4157
4158 Reviewed by Pavel Feldman.
4159
4160 * inspector/front-end/AdvancedSearchController.js:
4161 (WebInspector.SearchView):
4162 * inspector/front-end/Images/statusbarButtonGlyphs.png:
4163 * inspector/front-end/inspector.css:
4164 (.search-view .search-panel):
4165 (.search-view .search-panel input[type="search"].search-config-search):
4166 (.search-view .search-panel input[type="checkbox"].search-config-checkbo x):
4167 (body:not(.platform-mac) .search-view .search-panel input[type="checkbox "].search-config-checkbox):
4168 (body.platform-mac .search-view .search-panel input[type="checkbox"].sea rch-config-checkbox):
4169 (#drawer-status-bar .search-status-bar-progress):
4170 (body:not(.platform-mac) #drawer-status-bar .search-status-bar-progress) :
4171 (body.platform-mac #drawer-status-bar .search-status-bar-progress):
4172
4173 2011-10-27 David Hyatt <hyatt@apple.com>
4174
4175 https://bugs.webkit.org/show_bug.cgi?id=71061
4176
4177 [CSS Line Grid] Add support for parsing the line-grid property.
4178
4179 New tests in fast/line-grid.
4180
4181 Reviewed by Dan Bernstein.
4182
4183 * css/CSSComputedStyleDeclaration.cpp:
4184 (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
4185 * css/CSSParser.cpp:
4186 (WebCore::CSSParser::parseValue):
4187 * css/CSSProperty.cpp:
4188 (WebCore::CSSProperty::isInheritedProperty):
4189 * css/CSSPropertyNames.in:
4190 * css/CSSStyleSelector.cpp:
4191 (WebCore::CSSStyleSelector::applyProperty):
4192 * rendering/style/RenderStyle.h:
4193 (WebCore::InheritedFlags::lineGrid):
4194 (WebCore::InheritedFlags::setLineGrid):
4195 (WebCore::InheritedFlags::initialLineGrid):
4196 * rendering/style/StyleRareInheritedData.cpp:
4197 (WebCore::StyleRareInheritedData::StyleRareInheritedData):
4198 (WebCore::StyleRareInheritedData::operator==):
4199 * rendering/style/StyleRareInheritedData.h:
4200
4201 2011-10-27 Fady Samuel <fsamuel@chromium.org>
4202
4203 iframes seem to occasionally doubly scale or scale incorrectly when page ScaleFactor != 1.0
4204 https://bugs.webkit.org/show_bug.cgi?id=70552
4205
4206 Reviewed by Simon Fraser.
4207
4208 Test: fast/frames/iframe-double-scale-contents.html
4209
4210 The iframe's document style was using the page's scale factor, rather th an the frame's (1.0).
4211 If the page scale factor was set after layout was complete, then this wo uld have no impact because the iframe's document style and layout is not recompu ted,
4212 but if the page scale factor is set prior to creating and laying out the iframe, the iframe's content would be doubly scaled.
4213
4214 * css/CSSStyleSelector.cpp:
4215 (WebCore::CSSStyleSelector::styleForDocument):
4216
4217 2011-10-27 Nat Duca <nduca@chromium.org>
4218
4219 Unreviewed, fix CCSchedulerStateMachine build errors.
4220
4221 * platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
4222 * platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
4223
4224 2011-10-27 Tony Chang <tony@chromium.org>
4225
4226 fix sizing of auto sized flexbox
4227 https://bugs.webkit.org/show_bug.cgi?id=70839
4228
4229 Reviewed by David Hyatt.
4230
4231 Correctly set the height of the flexbox when we have a column flow
4232 and the height is auto.
4233
4234 Tests: css3/flexbox/columns-auto-size.html
4235 css3/flexbox/flex-flow-margins-auto-size.html
4236
4237 * rendering/RenderFlexibleBox.cpp:
4238 (WebCore::RenderFlexibleBox::layoutBlock): Always computeLogicalHeight() after we're done placing children.
4239 (WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection): Set the height as we place children.
4240
4241 2011-10-25 Vangelis Kokkevis <vangelis@chromium.org>
4242
4243 Add support for creating compositing layers for fixed position elements.
4244 https://bugs.webkit.org/show_bug.cgi?id=69796
4245
4246 position:fixed elements will get a compositing layer if:
4247 1. Settings:acceleratedCompositingForFixedPositionEnabled() returns true ,
4248 2. The element has its own stacking context (e.g. has a z-index), and
4249 3. The element's container is the RenderView (e.g. not a descendant of a transformed element)
4250
4251 Reviewed by Simon Fraser.
4252
4253
4254 Test: compositing/geometry/fixed-position-composited-switch.html
4255
4256 * page/Settings.cpp:
4257 (WebCore::Settings::Settings):
4258 * page/Settings.h:
4259 (WebCore::Settings::setAcceleratedCompositingForFixedPositionEnabled):
4260 (WebCore::Settings::acceleratedCompositingForFixedPositionEnabled):
4261 * rendering/RenderLayerCompositor.cpp:
4262 (WebCore::RenderLayerCompositor::RenderLayerCompositor):
4263 (WebCore::RenderLayerCompositor::updateCompositingLayers):
4264 (WebCore::RenderLayerCompositor::requiresCompositingLayer):
4265 (WebCore::RenderLayerCompositor::requiresCompositingForPosition):
4266 * rendering/RenderLayerCompositor.h:
4267 * testing/Internals.cpp:
4268 (WebCore::Internals::setEnableCompositingForFixedPosition):
4269 * testing/Internals.h:
4270 * testing/Internals.idl:
4271
4272 2011-10-27 Arthur Hsu <arthurhsu@chromium.org>
4273
4274 https://bugs.webkit.org/show_bug.cgi?id=70390
4275 Ensure font load for Skia backend during printing.
4276
4277 Reviewed by James Robinson.
4278
4279 * platform/graphics/chromium/FontChromiumWin.cpp:
4280 (WebCore::Font::drawGlyphs):
4281 * platform/graphics/skia/SkiaFontWin.cpp:
4282 (WebCore::paintSkiaText):
4283
4284 2011-10-27 Michael Saboff <msaboff@apple.com>
4285
4286 Investigate storing strings in 8-bit buffers when possible
4287 https://bugs.webkit.org/show_bug.cgi?id=66161
4288
4289 Changes to support 8 bit StringImpl changes.
4290
4291 Reviewed by Geoffrey Garen.
4292
4293 No new tests, refactored StringImpl for 8 bit strings.
4294
4295 * platform/text/cf/StringImplCF.cpp:
4296 (WTF::StringImpl::createCFString):
4297
4298 2011-10-27 Nat Duca <nduca@chromium.org>
4299
4300 [chromium] Encapsulate state machine parts of scheduling in CCSchedulerS tateMachine
4301 https://bugs.webkit.org/show_bug.cgi?id=70714
4302
4303 Reland of ill-fated r98612.
4304
4305 Reviewed by James Robinson.
4306
4307 * WebCore.gypi:
4308 * platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp: Added.
4309 (WebCore::CCSchedulerStateMachine::nextAction):
4310 (WebCore::CCSchedulerStateMachine::updateState):
4311 * platform/graphics/chromium/cc/CCSchedulerStateMachine.h: Added.
4312 (WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
4313 (WebCore::CCSchedulerStateMachine::operator=):
4314 (WebCore::CCSchedulerStateMachine::commitPending):
4315 (WebCore::CCSchedulerStateMachine::setNeedsRedraw):
4316 (WebCore::CCSchedulerStateMachine::setNeedsCommit):
4317 (WebCore::CCSchedulerStateMachine::beginFrameComplete):
4318 (WebCore::CCSchedulerStateMachine::updateResourcesComplete):
4319
4320 2011-10-27 Pavel Podivilov <podivilov@chromium.org>
4321
4322 Get rid of optional parameters in the middle in IDLs.
4323 https://bugs.webkit.org/show_bug.cgi?id=70816
4324
4325 Reviewed by Adam Barth.
4326
4327 Optional parameters in the middle are prohibited by WebIDL spec.
4328
4329 * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
4330 * bindings/scripts/CodeGeneratorJS.pm:
4331 (GenerateHeader):
4332 (GenerateImplementation):
4333 * bindings/scripts/CodeGeneratorV8.pm:
4334 (GenerateHeader):
4335 (GenerateArgumentsCountCheck):
4336 (GenerateImplementation):
4337 * bindings/scripts/test/JS/JSTestObj.cpp:
4338 (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOption alArgs):
4339 * bindings/scripts/test/TestObj.idl:
4340 * bindings/scripts/test/V8/V8TestObj.cpp:
4341 (WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCal lback):
4342 * html/canvas/CanvasRenderingContext2D.idl:
4343 * page/DOMWindow.idl:
4344
4345 2011-10-27 Antti Koivisto <antti@apple.com>
4346
4347 REGRESSION(r98542): tables/mozilla_expected_failures/bugs/bug14007-2.htm l
4348 https://bugs.webkit.org/show_bug.cgi?id=71032
4349
4350 Reviewed by Dave Hyatt.
4351
4352 If we apply an explicitly inherited property, we need to apply any furth er
4353 non-inherited properties as the property might get overridden again.
4354
4355 * css/CSSStyleSelector.cpp:
4356 (WebCore::CSSStyleSelector::styleForKeyframe):
4357 (WebCore::CSSStyleSelector::styleForPage):
4358 (WebCore::CSSStyleSelector::applyDeclaration):
4359 (WebCore::CSSStyleSelector::applyDeclarations):
4360 * css/CSSStyleSelector.h:
4361
4362 2011-10-27 Julien Chaffraix <jchaffraix@webkit.org>
4363
4364 Remove RenderTableSection::m_gridRows
4365 https://bugs.webkit.org/show_bug.cgi?id=70570
4366
4367 Reviewed by Darin Adler.
4368
4369 No new test, refactoring only.
4370
4371 Just nuke the old field that was duplicating
4372 m_grid.size().
4373
4374 * rendering/RenderTableSection.h:
4375 (WebCore::RenderTableSection::numRows):
4376 * rendering/RenderTableSection.cpp:
4377 (WebCore::RenderTableSection::RenderTableSection):
4378 (WebCore::RenderTableSection::ensureRows):
4379 (WebCore::RenderTableSection::setCellLogicalWidths):
4380 (WebCore::RenderTableSection::calcRowLogicalHeight):
4381 (WebCore::RenderTableSection::layoutRows):
4382 (WebCore::RenderTableSection::calcOuterBorderBefore):
4383 (WebCore::RenderTableSection::calcOuterBorderAfter):
4384 (WebCore::RenderTableSection::calcOuterBorderStart):
4385 (WebCore::RenderTableSection::calcOuterBorderEnd):
4386 (WebCore::RenderTableSection::firstLineBoxBaseline):
4387 (WebCore::RenderTableSection::paint):
4388 (WebCore::RenderTableSection::paintObject):
4389 (WebCore::RenderTableSection::clearGrid):
4390 (WebCore::RenderTableSection::numColumns):
4391 (WebCore::RenderTableSection::appendColumn):
4392 (WebCore::RenderTableSection::splitColumn):
4393 s/m_gridRows/m_grid.size()/.
4394 Also updated the code as m_grid.size() is unsigned.
4395
4396 (WebCore::RenderTableSection::recalcCells):
4397 The old code would keep the grid's memory but we have to clear it to pro perly
4398 count the elements. To avoid lots of small reallocations, we reallocate the
4399 buffer at the old capacity upfront.
4400
4401 2011-10-27 Nat Duca <nduca@chromium.org>
4402
4403 Unreviewed, rolling out r98612.
4404 http://trac.webkit.org/changeset/98612
4405 https://bugs.webkit.org/show_bug.cgi?id=70714
4406
4407 Broke build
4408
4409 * WebCore.gypi:
4410 * platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp: Removed.
4411 * platform/graphics/chromium/cc/CCSchedulerStateMachine.h: Removed.
4412
4413 2011-10-24 Nat Duca <nduca@chromium.org>
4414
4415 [chromium] Encapsulate state machine parts of scheduling in CCSchedulerS tateMachine
4416 https://bugs.webkit.org/show_bug.cgi?id=70714
4417
4418 Reviewed by James Robinson.
4419
4420 * WebCore.gypi:
4421 * platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp: Added.
4422 (WebCore::CCSchedulerStateMachine::nextAction):
4423 (WebCore::CCSchedulerStateMachine::updateState):
4424 * platform/graphics/chromium/cc/CCSchedulerStateMachine.h: Added.
4425 (WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
4426 (WebCore::CCSchedulerStateMachine::operator=):
4427 (WebCore::CCSchedulerStateMachine::commitPending):
4428 (WebCore::CCSchedulerStateMachine::setNeedsRedraw):
4429 (WebCore::CCSchedulerStateMachine::setNeedsCommit):
4430 (WebCore::CCSchedulerStateMachine::beginFrameComplete):
4431 (WebCore::CCSchedulerStateMachine::updateResourcesComplete):
4432
4433 2011-10-27 Dan Bernstein <mitz@apple.com>
4434
4435 <rdar://problem/10262205> Allow column progression to be independent of writing mode
4436 https://bugs.webkit.org/show_bug.cgi?id=71028
4437
4438 Reviewed by Darin Adler.
4439
4440 Tests: fast/multicol/block-axis-horizontal-bt.html
4441 fast/multicol/block-axis-horizontal-tb.html
4442 fast/multicol/block-axis-vertical-lr.html
4443 fast/multicol/block-axis-vertical-rl.html
4444 fast/multicol/flipped-blocks-hit-test.html
4445
4446 Allow “columns” to be stacked along the block axis rather than the inlin e axis. This can facilitate
4447 paginated interfaces. A column-axis property is added in order to enable this mode.
4448
4449 * css/CSSComputedStyleDeclaration.cpp:
4450 (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Handle the column-axis property.
4451 * css/CSSParser.cpp:
4452 (WebCore::CSSParser::parseValue): Ditto.
4453 * css/CSSPrimitiveValueMappings.h:
4454 (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Map ColumnAxis values t o identifiers.
4455 (WebCore::CSSPrimitiveValue::operator ColumnAxis): Map identifiers to Co lumnAxis values.
4456 * css/CSSProperty.cpp:
4457 (WebCore::CSSProperty::isInheritedProperty): Updated to return false for the column-axis property.
4458 * css/CSSPropertyNames.in: Added -webkit-column-axis.
4459 * css/CSSStyleSelector.cpp:
4460 (WebCore::CSSStyleSelector::applyProperty): Handle column-axis.
4461 * rendering/ColumnInfo.h:
4462 (WebCore::ColumnInfo::ColumnInfo): Added m_progressionAxis to the initia lization list.
4463 (WebCore::ColumnInfo::progressionAxis): Added this getter.
4464 (WebCore::ColumnInfo::setProgressionAxis): Added this setter.
4465 * rendering/RenderBlock.cpp:
4466 (WebCore::RenderBlock::addOverflowFromChildren): Simplified, and thus al so made this function work
4467 with block-axis column progression.
4468 (WebCore::RenderBlock::paintColumnRules): Added code to paint rules betw een columns with block-axis
4469 progression.
4470 (WebCore::RenderBlock::paintColumnContents): Adjusted the painting offse t for the block-axis
4471 column progression case.
4472 (WebCore::RenderBlock::nodeAtPoint): Fixed hit-testing in flipped-blocks writing modes. This is
4473 covered by flipped-blocks-hit-test.html.
4474 (WebCore::RenderBlock::hitTestColumns): Adjusted the offset for the bloc k-axis column progression
4475 case.
4476 (WebCore::RenderBlock::calcColumnWidth): Set the column width to the con tent logical width in
4477 the block-axis column progression case. The column-width and column-coun t properties are ignored.
4478 (WebCore::RenderBlock::setDesiredColumnCountAndWidth): Set the column pr ogression axis based on
4479 the style.
4480 (WebCore::RenderBlock::columnCount): Broke up an assertion into two.
4481 (WebCore::RenderBlock::columnRectAt): Updated for block-axis column prog ression.
4482 (WebCore::RenderBlock::adjustPointToColumnContents): Ditto.
4483 (WebCore::RenderBlock::adjustRectForColumns): Ditto.
4484 (WebCore::RenderBlock::adjustForColumns): Ditto.
4485 * rendering/RenderLayer.cpp:
4486 (WebCore::RenderLayer::paintChildLayerIntoColumns): Adjusted the offser for the block-axis column
4487 progression case.
4488 (WebCore::RenderLayer::hitTestChildLayerColumns): Ditto.
4489 * rendering/style/RenderStyle.h:
4490 (WebCore::InheritedFlags::columnAxis): Added this getter.
4491 (WebCore::InheritedFlags::hasInlineColumnAxis): Added. Checks the column axis against the writing
4492 mode.
4493 (WebCore::InheritedFlags::specifiesColumns): Changed to return true if t he specified column axis
4494 is the block axis.
4495 (WebCore::InheritedFlags::setColumnAxis): Added this setter.
4496 (WebCore::InheritedFlags::initialColumnAxis): Added. Returns AutoColumnA xis.
4497 * rendering/style/RenderStyleConstants.h: Added a ColumnAxis enum.
4498 * rendering/style/StyleMultiColData.cpp:
4499 (WebCore::StyleMultiColData::StyleMultiColData): Added m_axis to the ini tialization list.
4500 (WebCore::StyleMultiColData::operator==): Compare m_axis.
4501 * rendering/style/StyleMultiColData.h: Added m_axis member variable.
4502
4503 2011-10-27 Mihnea Ovidenie <mihnea@adobe.com>
4504
4505 [CSSRegions]Flag regions with custom styling
4506 https://bugs.webkit.org/show_bug.cgi?id=70733
4507
4508 Reviewed by David Hyatt.
4509
4510 Region elements that have custom region styling are now marked according ly.
4511
4512 Test: fast/regions/render-region-custom-style-mark.html
4513
4514 * css/CSSStyleSelector.cpp:
4515 (WebCore::CSSStyleSelector::checkRegionStyle):
4516 * css/CSSStyleSelector.h:
4517 * rendering/RenderRegion.cpp:
4518 (WebCore::RenderRegion::RenderRegion):
4519 (WebCore::RenderRegion::styleDidChange):
4520 * rendering/RenderRegion.h:
4521 (WebCore::RenderRegion::hasCustomRegionStyle):
4522 (WebCore::RenderRegion::setHasCustomRegionStyle):
4523 * rendering/RenderTreeAsText.cpp:
4524 (WebCore::writeRenderFlowThreads):
4525
4526 2011-10-27 Sheriff Bot <webkit.review.bot@gmail.com>
4527
4528 Unreviewed, rolling out r98556.
4529 http://trac.webkit.org/changeset/98556
4530 https://bugs.webkit.org/show_bug.cgi?id=71031
4531
4532 The test added by the patch doesn't pass on Snow Leopard
4533 (Requested by rniwa on #webkit).
4534
4535 * editing/TextCheckingHelper.cpp:
4536 (WebCore::checkTextOfParagraph):
4537 * testing/Internals.cpp:
4538 * testing/Internals.h:
4539 * testing/Internals.idl:
4540
4541 2011-10-27 Mike Reed <reed@google.com>
4542
4543 [skia] replace offscreen technique with native support for antialiased c lipping
4544 https://bugs.webkit.org/show_bug.cgi?id=70748
4545
4546 Reviewed by Stephen White.
4547
4548 ~100 layout tests need to be rebaselined, as the native aa-clipping diff ers sometimes in the low
4549 bits of the result. Other than that, the results should be the same, exc ept that now the drawing
4550 can go directly to the canvas, rather than being direct offscreen and th en have that result
4551 "clipped" during the restore. This has the effect of allowing LCD text t o be drawing inside a
4552 antialiased clip area.
4553
4554 * platform/graphics/skia/PlatformContextSkia.cpp:
4555 (WebCore::PlatformContextSkia::State::State):
4556 (WebCore::PlatformContextSkia::State::cloneInheritedProperties):
4557 (WebCore::PlatformContextSkia::clipPathAntiAliased):
4558 (WebCore::PlatformContextSkia::restore):
4559 * platform/graphics/skia/PlatformContextSkia.h:
4560
4561 2011-10-27 Tony Chang <tony@chromium.org>
4562
4563 use main/cross instead of logical width/height when talking about flow d irection
4564 https://bugs.webkit.org/show_bug.cgi?id=70977
4565
4566 Reviewed by Ojan Vafai.
4567
4568 Flexbox code uses logical in function names to refer to the flow
4569 direction. This is confusing because writing mode also uses logical,
4570 but this is a diffent usage. To avoid confusion, be explicit about
4571 main vs cross axis. Extent is used instead of width/height.
4572
4573 No new tests, just a refactoring.
4574
4575 * rendering/RenderFlexibleBox.cpp:
4576 (WebCore::RenderFlexibleBox::mainAxisLengthForChild):
4577 (WebCore::RenderFlexibleBox::crossAxisLength):
4578 (WebCore::RenderFlexibleBox::setCrossExtent):
4579 (WebCore::RenderFlexibleBox::crossExtentForChild):
4580 (WebCore::RenderFlexibleBox::mainExtentForChild):
4581 (WebCore::RenderFlexibleBox::crossAxisExtent):
4582 (WebCore::RenderFlexibleBox::mainAxisExtent):
4583 (WebCore::RenderFlexibleBox::crossAxisContentExtent):
4584 (WebCore::RenderFlexibleBox::mainAxisContentExtent):
4585 (WebCore::RenderFlexibleBox::crossAxisBorderAndPaddingExtent):
4586 (WebCore::RenderFlexibleBox::crossAxisMarginExtentForChild):
4587 (WebCore::RenderFlexibleBox::flowAwareLocationForChild):
4588 (WebCore::RenderFlexibleBox::setFlowAwareLocationForChild):
4589 (WebCore::RenderFlexibleBox::mainAxisBorderAndPaddingExtentForChild):
4590 (WebCore::RenderFlexibleBox::mainAxisScrollbarExtentForChild):
4591 (WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForFlexItem):
4592 (WebCore::RenderFlexibleBox::layoutInlineDirection):
4593 (WebCore::RenderFlexibleBox::positiveFlexForChild): Since flex only
4594 matters in the main axis, there's no reason to deambiguate it here.
4595 (WebCore::RenderFlexibleBox::negativeFlexForChild): Ditto.
4596 (WebCore::RenderFlexibleBox::availableAlignmentSpaceForChild): Alignment is always
4597 in the cross axis direction, so don't include that in the method nam e.
4598 (WebCore::RenderFlexibleBox::marginBoxAscent):
4599 (WebCore::RenderFlexibleBox::computePreferredMainAxisExtent):
4600 (WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmInlineDirect ion):
4601 (WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
4602 (WebCore::RenderFlexibleBox::adjustAlignmentForChild): Alignment is alw ays
4603 in the cross axis direction, so don't include that in the method nam e.
4604 (WebCore::RenderFlexibleBox::alignChildrenBlockDirection):
4605 * rendering/RenderFlexibleBox.h:
4606
4607 2011-10-27 Mark Hahnenberg <mhahnenberg@apple.com>
4608
4609 De-virtualize JSCell::toThisObject
4610 https://bugs.webkit.org/show_bug.cgi?id=70958
4611
4612 Reviewed by Geoffrey Garen.
4613
4614 No new tests.
4615
4616 Converted all instances of toThisObject to static functions,
4617 added toThisObject to the MethodTable, and replaced all call sites
4618 with a corresponding lookup in the MethodTable.
4619
4620 * bindings/js/JSDOMWindowBase.cpp:
4621 (WebCore::JSDOMWindowBase::toThisObject):
4622 * bindings/js/JSDOMWindowBase.h:
4623 * bindings/js/JSErrorHandler.cpp:
4624 (WebCore::JSErrorHandler::handleEvent):
4625 * bridge/NP_jsobject.cpp:
4626 (_NPN_Invoke):
4627 * bridge/qt/qt_runtime.cpp:
4628 (JSC::Bindings::QtRuntimeConnectionMethod::call):
4629
4630 2011-10-27 Adam Roben <aroben@apple.com>
4631
4632 Windows build fix after r98512
4633
4634 * html/HTMLMediaElement.cpp: Moved a Web Audio-related #include inside a n appropriate ENABLE
4635 guard.
4636
4637 2011-10-27 Adam Roben <aroben@apple.com>
4638
4639 Regenerate WebCore's Localizable.strings file
4640
4641 All I did was run update-webkit-localizable-strings. A few localizer com ments changed, and
4642 some strings (which must have been hand-added) got moved to a different part of the file.