Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 849193002: win: Some %zu to PRIuS (Closed)

Created:
5 years, 11 months ago by scottmg
Modified:
5 years, 11 months ago
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

win: Some %zu to PRIuS %zu aborts in system printf functions on Windows, so use PRIuS instead. R=mark@chromium.org, rsesek@chromium.org BUG=crashpad:1 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/cb8c01f4105fdca78a3035cb63a72b7227e87df3

Patch Set 1 #

Patch Set 2 : similarity #

Patch Set 3 : use format_macros.h instead #

Patch Set 4 : remove header #

Patch Set 5 : fix include order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
M util/misc/uuid_test.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M util/numeric/checked_range_test.cc View 1 2 5 chunks +8 lines, -5 lines 0 comments Download
M util/stdlib/strlcpy_test.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
scottmg
5 years, 11 months ago (2015-01-15 04:35:41 UTC) #1
Robert Sesek
Why don't we pull in https://chromium.googlesource.com/chromium/src/+/master/base/format_macros.h to mini_chromium and use PRIuS?
5 years, 11 months ago (2015-01-15 06:42:28 UTC) #3
scottmg
On 2015/01/15 06:42:28, Robert Sesek wrote: > Why don't we pull in > https://chromium.googlesource.com/chromium/src/+/master/base/format_macros.h to ...
5 years, 11 months ago (2015-01-15 17:28:13 UTC) #4
scottmg
On 2015/01/15 17:28:13, scottmg wrote: > On 2015/01/15 06:42:28, Robert Sesek wrote: > > Why ...
5 years, 11 months ago (2015-01-15 17:38:06 UTC) #5
Mark Mentovai
Roll DEPS to pick up mini_chromium, and LGTM
5 years, 11 months ago (2015-01-15 17:46:29 UTC) #6
scottmg
5 years, 11 months ago (2015-01-15 18:00:46 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
cb8c01f4105fdca78a3035cb63a72b7227e87df3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698