Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 799633006: Pull in base/format_macros.h from Chromium, unmodified (Closed)

Created:
5 years, 11 months ago by scottmg
Modified:
5 years, 11 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/mini_chromium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Pull in base/format_macros.h from Chromium, unmodified Needed for portable size_t format strings. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/chromium/mini_chromium/+/3ce1cc29260d5b49ac21d96454a778c02f583172

Patch Set 1 #

Patch Set 2 : add to gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -0 lines) Patch
M base/base.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
A base/format_macros.h View 1 chunk +101 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
5 years, 11 months ago (2015-01-15 17:24:45 UTC) #1
Robert Sesek
This should be listed in base.gyp too.
5 years, 11 months ago (2015-01-15 17:26:53 UTC) #2
scottmg
On 2015/01/15 17:26:53, Robert Sesek wrote: > This should be listed in base.gyp too. Done.
5 years, 11 months ago (2015-01-15 17:44:24 UTC) #3
Robert Sesek
LGTM
5 years, 11 months ago (2015-01-15 17:44:42 UTC) #4
scottmg
5 years, 11 months ago (2015-01-15 17:51:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3ce1cc29260d5b49ac21d96454a778c02f583172 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698