Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: tools/json_schema_compiler/idl_schema.py

Issue 849103005: Cleanup most pylint errors in json_schema_compiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/json_schema_compiler/h_generator.py ('k') | tools/json_schema_compiler/model.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/json_schema_compiler/idl_schema.py
diff --git a/tools/json_schema_compiler/idl_schema.py b/tools/json_schema_compiler/idl_schema.py
index a9137569cc348f0583110e279e9a523b016c7543..45f0609e49bc3878e5df3328a2995d2021b61b87 100755
--- a/tools/json_schema_compiler/idl_schema.py
+++ b/tools/json_schema_compiler/idl_schema.py
@@ -271,7 +271,6 @@ class Typeref(object):
properties['additionalProperties'] = OrderedDict()
properties['additionalProperties']['type'] = 'any'
elif self.parent.GetPropertyLocal('Union'):
- choices = []
properties['choices'] = [Typeref(node.GetProperty('TYPEREF'),
node,
OrderedDict()).process(callbacks)
@@ -303,7 +302,7 @@ class Enum(object):
self.node = enum_node
self.description = ''
- def process(self, callbacks):
+ def process(self):
enum = []
for node in self.node.GetChildren():
if node.cls == 'EnumItem':
@@ -327,7 +326,7 @@ class Enum(object):
if self.node.GetProperty(property_name):
result[property_name] = self.node.GetProperty(property_name)
if self.node.GetProperty('deprecated'):
- result[deprecated] = self.node.GetProperty('deprecated')
+ result['deprecated'] = self.node.GetProperty('deprecated')
return result
@@ -369,7 +368,7 @@ class Namespace(object):
elif node.cls == 'Interface' and node.GetName() == 'Events':
self.events = self.process_interface(node)
elif node.cls == 'Enum':
- self.types.append(Enum(node).process(self.callbacks))
+ self.types.append(Enum(node).process())
else:
sys.exit('Did not process %s %s' % (node.cls, node))
if self.compiler_options is not None:
@@ -391,7 +390,7 @@ class Namespace(object):
members = []
for member in node.GetChildren():
if member.cls == 'Member':
- name, properties = Member(member).process(self.callbacks)
+ _, properties = Member(member).process(self.callbacks)
members.append(properties)
return members
« no previous file with comments | « tools/json_schema_compiler/h_generator.py ('k') | tools/json_schema_compiler/model.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698