Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Unified Diff: include/images/SkDecodingImageGenerator.h

Issue 849103004: Make SkStream *not* ref counted. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Rebase, just in case. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/core/SkTypeface.h ('k') | include/utils/SkFrontBufferedStream.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/images/SkDecodingImageGenerator.h
diff --git a/include/images/SkDecodingImageGenerator.h b/include/images/SkDecodingImageGenerator.h
index 6cb39be8d84ada83173a549aab4e8ce8fb29dfd4..0a5ec56fe8e2207e387f23afb42eef6a21d1d556 100644
--- a/include/images/SkDecodingImageGenerator.h
+++ b/include/images/SkDecodingImageGenerator.h
@@ -85,20 +85,8 @@ namespace SkDecodingImageGenerator {
* The SkData version of this function is preferred. If the stream
* has an underlying SkData (such as a SkMemoryStream) pass that in.
*
- * This object will unref the stream when done or on failure. Since
- * streams have internal state (position), the caller should not pass
- * a shared stream in. Pass either a new duplicated stream in or
- * transfer ownership of the stream. This factory asserts
- * stream->unique().
- *
- * For example:
- * SkStreamRewindable* stream;
- * ...
- * SkImageGenerator* gen
- * = SkDecodingImageGenerator::Create(
- * stream->duplicate(), SkDecodingImageGenerator::Options());
- * ...
- * SkDELETE(gen);
+ * This object, if non-NULL, takes ownership of stream and deletes stream
+ * upon deletion. If NULL is returned, stream is deleted immediately.
*
* @param Options (see above)
*
« no previous file with comments | « include/core/SkTypeface.h ('k') | include/utils/SkFrontBufferedStream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698