Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: include/core/SkTypeface.h

Issue 849103004: Make SkStream *not* ref counted. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Rebase, just in case. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/core/SkStream.h ('k') | include/images/SkDecodingImageGenerator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/core/SkTypeface.h
diff --git a/include/core/SkTypeface.h b/include/core/SkTypeface.h
index c2aa543ab2748003f018e7f5fe4ea5019da44b38..ecf582bd88243a47b6d9b52f6f6feb60bca6a2e0 100644
--- a/include/core/SkTypeface.h
+++ b/include/core/SkTypeface.h
@@ -145,6 +145,7 @@ public:
to a typeface referring to the same font. If that font is not available,
return null. If an instance is returned, the caller is responsible for
calling unref() when they are done with it.
+ Does not affect ownership of SkStream.
*/
static SkTypeface* Deserialize(SkStream*);
@@ -276,6 +277,7 @@ public:
* If ttcIndex is not null, it is set to the TrueTypeCollection index
* of this typeface within the stream, or 0 if the stream is not a
* collection.
+ * The caller is responsible for deleting the stream.
*/
SkStream* openStream(int* ttcIndex) const;
« no previous file with comments | « include/core/SkStream.h ('k') | include/images/SkDecodingImageGenerator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698