tests/PDFPrimitivesTest.cpp - Issue 849103004: Make SkStream *not* ref counted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/PDFPrimitivesTest.cpp

Issue 849103004: Make SkStream *not* ref counted. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Treat SkFontMgr::createFromStream as taking ownership of the stream (is this correct?) Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/PDFPrimitivesTest.cpp

diff --git a/tests/PDFPrimitivesTest.cpp b/tests/PDFPrimitivesTest.cpp

index 3a4c6f6ab0b73b54eb97f1fae280107b558aeb19..3610dd958101381a0ea6eb30e4b5a4671b88b212 100644

--- a/tests/PDFPrimitivesTest.cpp

+++ b/tests/PDFPrimitivesTest.cpp

@@ -119,7 +119,7 @@ static void SimpleCheckObjectOutput(skiatest::Reporter* reporter,

static void TestPDFStream(skiatest::Reporter* reporter) {

char streamBytes[] = "Test\nFoo\tBar";

- SkAutoTUnref<SkMemoryStream> streamData(new SkMemoryStream(

+ SkAutoTDelete<SkMemoryStream> streamData(new SkMemoryStream(

streamBytes, strlen(streamBytes), true));

SkAutoTUnref<SkPDFStream> stream(new SkPDFStream(streamData.get()));

SimpleCheckObjectOutput(