tests/KtxTest.cpp - Issue 849103004: Make SkStream *not* ref counted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/KtxTest.cpp

Issue 849103004: Make SkStream *not* ref counted. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Treat SkFontMgr::createFromStream as taking ownership of the stream (is this correct?) Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/KtxTest.cpp

diff --git a/tests/KtxTest.cpp b/tests/KtxTest.cpp

index 23c1d709001dc0bd6eb706c0c8194d69682ef81b..53caabdd910719de086c0451c5c68ce16ac6405f 100644

--- a/tests/KtxTest.cpp

+++ b/tests/KtxTest.cpp

@@ -55,7 +55,7 @@ DEF_TEST(KtxReadWrite, reporter) {

SkAutoDataUnref encodedData(SkImageEncoder::EncodeData(bm8888, SkImageEncoder::kKTX_Type, 0));

REPORTER_ASSERT(reporter, encodedData);

- SkAutoTUnref<SkMemoryStream> stream(SkNEW_ARGS(SkMemoryStream, (encodedData)));

+ SkAutoTDelete<SkMemoryStream> stream(SkNEW_ARGS(SkMemoryStream, (encodedData)));

REPORTER_ASSERT(reporter, stream);

SkBitmap decodedBitmap;

@@ -107,7 +107,7 @@ DEF_TEST(KtxReadUnpremul, reporter) {

0xFF, 0xFF, 0xFF, 0x80, // Pixel 3

0xFF, 0xFF, 0xFF, 0x80};// Pixel 4

- SkAutoTUnref<SkMemoryStream> stream(

+ SkAutoTDelete<SkMemoryStream> stream(

SkNEW_ARGS(SkMemoryStream, (kHalfWhiteKTX, sizeof(kHalfWhiteKTX))));

REPORTER_ASSERT(reporter, stream);