dm/DM.cpp - Issue 849103004: Make SkStream *not* ref counted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dm/DM.cpp

Issue 849103004: Make SkStream *not* ref counted. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Treat SkFontMgr::createFromStream as taking ownership of the stream (is this correct?) Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dm/DM.cpp

diff --git a/dm/DM.cpp b/dm/DM.cpp

index 7113ad839a02e4e61cc028adf608c389e389edea..14b3e823c224eca08f10bc2cd40cac25aefbd682 100644

--- a/dm/DM.cpp

+++ b/dm/DM.cpp

@@ -151,7 +151,7 @@ static void kick_off_skps(const SkTArray<SkString>& skps,

DM::Reporter* reporter,

DM::TaskRunner* tasks) {

for (int i = 0; i < skps.count(); ++i) {

- SkAutoTUnref<SkStream> stream(SkStream::NewFromFile(skps[i].c_str()));

+ SkAutoTDelete<SkStream> stream(SkStream::NewFromFile(skps[i].c_str()));

if (stream.get() == NULL) {

SkDebugf("Could not read %s.\n", skps[i].c_str());

exit(1);

« no previous file with comments | « bench/nanobench.cpp ('k') | dm/DMImageTask.cpp » ('j') | gm/gmmain.cpp » ('J')