bench/nanobench.cpp - Issue 849103004: Make SkStream *not* ref counted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: bench/nanobench.cpp

Issue 849103004: Make SkStream *not* ref counted. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Treat SkFontMgr::createFromStream as taking ownership of the stream (is this correct?) Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: bench/nanobench.cpp

diff --git a/bench/nanobench.cpp b/bench/nanobench.cpp

index 36a9177e576e38e2a47ba702e42644b86f6f6213..0201ce4b4da993276438d2ee77cb5d661e6fe2fb 100644

--- a/bench/nanobench.cpp

+++ b/bench/nanobench.cpp

@@ -482,7 +482,7 @@ public:

return false;

}

- SkAutoTUnref<SkStream> stream(SkStream::NewFromFile(path));

+ SkAutoTDelete<SkStream> stream(SkStream::NewFromFile(path));

if (stream.get() == NULL) {

SkDebugf("Could not read %s.\n", path);

return false;

« no previous file with comments | « no previous file | dm/DM.cpp » ('j') | gm/gmmain.cpp » ('J')