runtime/vm/assembler_arm64.cc - Issue 849093002: Tweak CanLoadFromObjectPool to return true even if obj.InVMHeap().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/assembler_arm64.cc

Issue 849093002: Tweak CanLoadFromObjectPool to return true even if obj.InVMHeap(). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/assembler_arm64.cc

diff --git a/runtime/vm/assembler_arm64.cc b/runtime/vm/assembler_arm64.cc

index d56cb3c714426f9db0c16dee2bd763d843ee353e..e42124715a08bbc1055bd812f4c35d94ca7a7d5d 100644

--- a/runtime/vm/assembler_arm64.cc

+++ b/runtime/vm/assembler_arm64.cc

@@ -511,10 +511,7 @@ bool Assembler::CanLoadObjectFromPool(const Object& object) {

}

ASSERT(object.IsNotTemporaryScopedHandle());

ASSERT(object.IsOld());

- return (Isolate::Current() != Dart::vm_isolate()) &&

- // Not in the VMHeap, OR is one of the VMHeap objects we put in every

- // object pool.

- (!object.InVMHeap() || IsAlwaysInConstantPool(object));

+ return (Isolate::Current() != Dart::vm_isolate());

}

« no previous file with comments | « no previous file | runtime/vm/assembler_x64.cc » ('j') | runtime/vm/assembler_x64.cc » ('J')