Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Unified Diff: runtime/vm/assembler_x64.cc

Issue 849093002: Tweak CanLoadFromObjectPool to return true even if obj.InVMHeap(). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/assembler_x64.cc
diff --git a/runtime/vm/assembler_x64.cc b/runtime/vm/assembler_x64.cc
index 169db47a7302eb96019a9a3ec04dbc6e29954450..aa3faa39dfd5903e2d47c9370bbc75a3cb522f96 100644
--- a/runtime/vm/assembler_x64.cc
+++ b/runtime/vm/assembler_x64.cc
@@ -2842,10 +2842,7 @@ bool Assembler::CanLoadFromObjectPool(const Object& object) {
}
ASSERT(object.IsNotTemporaryScopedHandle());
ASSERT(object.IsOld());
- return (Isolate::Current() != Dart::vm_isolate()) &&
- // Not in the VMHeap, OR is one of the VMHeap objects we put in every
- // object pool.
- (!object.InVMHeap() || IsAlwaysInConstantPool(object));
+ return (Isolate::Current() != Dart::vm_isolate());
}

Powered by Google App Engine
This is Rietveld 408576698